From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E8116352FF2; Tue, 26 Aug 2025 14:37:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756219053; cv=none; b=WRGv8sKCqPVhe/F2MtNUyxzMgUWomoQwCuc+uvdQH7KuQ66ZcRGaBo0vJ7ByGdtuMMnI6dWl0Mls42TiDITQY8rXVROvqFjgRgCuiWkr+B5xxRbFrI85QLSVeDVkWWgYBQEdBdz0/GjeHUKsD3zy7i9u5XL8AZuyrkWNV8/petk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756219053; c=relaxed/simple; bh=QJKpUPyt97u/gLOv76JAdgP9BELmb22NBJRsMaPGNcw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=qChB+EuIhVoRpu6gQziqOxNjl+yARlaiVCExUYhmtc8oCEMOF68PDWv6TF+pcVqkXpvBt+wnjM7cvWY8j5+U1d+FGDiNP0Umng4gRGlM+KE8GDjlDocEXeJSP3lbiXeAGApUg5L9Im+Bo3VlkDg2icR/RWLZ23lWLiGY7RNUpjI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=P82hU8Ht; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="P82hU8Ht" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 769EAC4CEF1; Tue, 26 Aug 2025 14:37:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1756219052; bh=QJKpUPyt97u/gLOv76JAdgP9BELmb22NBJRsMaPGNcw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=P82hU8Ht0QfFZf19/YRxrBAgLn4EfHLMXwgjdUGaB7dagjuaaGym4+KBEKcfGVnWr 4wdgfA7EkGbYv5yHKJORguFm64WpVHFO0U8aCfE1E3wLBh/ld73VFbNUptYDdnXxPd ZLUmbhLWag5YZhrCl6xDMmRfGiTWYCWTb3igX8jA= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Amir Mohammad Jahangirzad , Mike Marshall , Sasha Levin Subject: [PATCH 5.4 235/403] fs/orangefs: use snprintf() instead of sprintf() Date: Tue, 26 Aug 2025 13:09:21 +0200 Message-ID: <20250826110913.324394362@linuxfoundation.org> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20250826110905.607690791@linuxfoundation.org> References: <20250826110905.607690791@linuxfoundation.org> User-Agent: quilt/0.68 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.4-stable review patch. If anyone has any objections, please let me know. ------------------ From: Amir Mohammad Jahangirzad [ Upstream commit cdfa1304657d6f23be8fd2bb0516380a3c89034e ] sprintf() is discouraged for use with bounded destination buffers as it does not prevent buffer overflows when the formatted output exceeds the destination buffer size. snprintf() is a safer alternative as it limits the number of bytes written and ensures NUL-termination. Replace sprintf() with snprintf() for copying the debug string into a temporary buffer, using ORANGEFS_MAX_DEBUG_STRING_LEN as the maximum size to ensure safe formatting and prevent memory corruption in edge cases. EDIT: After this patch sat on linux-next for a few days, Dan Carpenter saw it and suggested that I use scnprintf instead of snprintf. I made the change and retested. Signed-off-by: Amir Mohammad Jahangirzad Signed-off-by: Mike Marshall Signed-off-by: Sasha Levin --- fs/orangefs/orangefs-debugfs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/orangefs/orangefs-debugfs.c b/fs/orangefs/orangefs-debugfs.c index b57140ebfad0..cd4bfd92ebd6 100644 --- a/fs/orangefs/orangefs-debugfs.c +++ b/fs/orangefs/orangefs-debugfs.c @@ -354,7 +354,7 @@ static ssize_t orangefs_debug_read(struct file *file, goto out; mutex_lock(&orangefs_debug_lock); - sprintf_ret = sprintf(buf, "%s", (char *)file->private_data); + sprintf_ret = scnprintf(buf, ORANGEFS_MAX_DEBUG_STRING_LEN, "%s", (char *)file->private_data); mutex_unlock(&orangefs_debug_lock); read_ret = simple_read_from_buffer(ubuf, count, ppos, buf, sprintf_ret); -- 2.39.5