From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 860E8352084; Tue, 26 Aug 2025 14:39:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756219193; cv=none; b=pRwmgU/Vv2Qu/mTX4nnSeKFh0KFajp4hde1IDvem5U4jFFqZkdwtaKkK9objWN2Tyk/9ZoD4+SYR3wdfg4OblQXcNUo+aUDG951PihMrFsAMB3POrKIvmk/rtlUwvLfq7s707ZRfgu8o1nfSc8jkTNu8DUXXwa4vGhdPLETpbio= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756219193; c=relaxed/simple; bh=a3JDrf12o7JmvsJhmydU9ECZ+Rg9n/TiXaLQ7fRf4PY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=pwSYN/0fKHzELK8w7DEJE4Pz9KdHEsy8TMpaLNQsJG98kifMteEjxj7G49IMKkx3/rIeIKy/rn1S9ePV6+r2bdzK/9PD0NS9MMo63v6uiVCPhBpSJBOeNbyzjz2K2Cjg4BKJTzP//gXLCWAY91cQAJ1r9M/BGoWaZrciB0eIYVw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=TwkjSj3J; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="TwkjSj3J" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 19D8EC113CF; Tue, 26 Aug 2025 14:39:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1756219193; bh=a3JDrf12o7JmvsJhmydU9ECZ+Rg9n/TiXaLQ7fRf4PY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=TwkjSj3JolewCln9SA3W/KSyPxd7+D56BbTjUcD4jTRF8PbL5wQZ46mylEs5EsvA6 RRDbNURNDyLohOB5+ZVXlZnENy2JuoFpm9C8bUZZK1NaFrhwtXxJg4/QFZ6tY+Px3E W9AvVgwiAMG5MikvrXcRQwqOUjRPrKEhTWCe/kXY= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Shankari Anand , Masahiro Yamada , Randy Dunlap , Nicolas Schier , Sasha Levin Subject: [PATCH 5.4 258/403] kconfig: nconf: Ensure null termination where strncpy is used Date: Tue, 26 Aug 2025 13:09:44 +0200 Message-ID: <20250826110913.947561415@linuxfoundation.org> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20250826110905.607690791@linuxfoundation.org> References: <20250826110905.607690791@linuxfoundation.org> User-Agent: quilt/0.68 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.4-stable review patch. If anyone has any objections, please let me know. ------------------ From: Shankari Anand [ Upstream commit f468992936894c9ce3b1659cf38c230d33b77a16 ] strncpy() does not guarantee null-termination if the source string is longer than the destination buffer. Ensure the buffer is explicitly null-terminated to prevent potential string overflows or undefined behavior. Signed-off-by: Shankari Anand Signed-off-by: Masahiro Yamada Acked-by: Randy Dunlap Tested-by: Randy Dunlap Tested-by: Nicolas Schier Acked-by: Nicolas Schier Signed-off-by: Sasha Levin --- scripts/kconfig/nconf.c | 2 ++ scripts/kconfig/nconf.gui.c | 1 + 2 files changed, 3 insertions(+) diff --git a/scripts/kconfig/nconf.c b/scripts/kconfig/nconf.c index 331b2cc917ec..af56d27693d0 100644 --- a/scripts/kconfig/nconf.c +++ b/scripts/kconfig/nconf.c @@ -580,6 +580,8 @@ static void item_add_str(const char *fmt, ...) tmp_str, sizeof(k_menu_items[index].str)); + k_menu_items[index].str[sizeof(k_menu_items[index].str) - 1] = '\0'; + free_item(curses_menu_items[index]); curses_menu_items[index] = new_item( k_menu_items[index].str, diff --git a/scripts/kconfig/nconf.gui.c b/scripts/kconfig/nconf.gui.c index 77f525a8617c..8b3e9bc893a7 100644 --- a/scripts/kconfig/nconf.gui.c +++ b/scripts/kconfig/nconf.gui.c @@ -398,6 +398,7 @@ int dialog_inputbox(WINDOW *main_window, x = (columns-win_cols)/2; strncpy(result, init, *result_len); + result[*result_len - 1] = '\0'; /* create the windows */ win = newwin(win_lines, win_cols, y, x); -- 2.39.5