From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3F49F2367D9; Tue, 26 Aug 2025 14:39:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756219175; cv=none; b=E/tJTUnRVKln2EcdeNvF3gKohsBBmI+EPqBqW+5oR9yeaxllXyBHedXrUuSeXUXcKoHsQzO0XyF70ojNoGkspMdGM1yGdBrWWyTrXGRZEt2//FnP09dtS+yhiJxCmIYv3HFxxBjILLoHvE2IvoXGAN+CH8gcaXw4McWMD7rCzXk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756219175; c=relaxed/simple; bh=c6qfqw6q6ATNj7aUMW1VNF3kQm6gOgu6bKwbY6QqxsI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=H0oZglL3LU7ePwIEjhIPchL26U8eFP81u0dtCKaSAhQmSohj94K68Q1unURJ5hdopPlX91bhdPDLGvV5n8bID72ezZOldpPr/3pLUFfSvDX8UAg638c82m2D3utK/9l9+Tx9HrOYpVkx2tH/IWTlYdx409qg+GGJGhWyUd/NqjA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=ZKAvZsl7; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="ZKAvZsl7" Received: by smtp.kernel.org (Postfix) with ESMTPSA id C696EC113CF; Tue, 26 Aug 2025 14:39:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1756219175; bh=c6qfqw6q6ATNj7aUMW1VNF3kQm6gOgu6bKwbY6QqxsI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ZKAvZsl7qMECKFZDReh9BEscckI83k8smCLgj2E4i61c70Ei7rZjjkmEpQDKfDrJ0 a7WEeN1uSy+6hRoDc5JViPsWQBeNmoSiozAvwhRESMljRsNR2LBetUFLmURqM3ICHv cXuBdspBNahvhGvjd7fkNcnk/lUahLu5RwbOGt1k= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Youngjun Lee , Laurent Pinchart , Ricardo Ribalda , Hans Verkuil Subject: [PATCH 5.4 280/403] media: uvcvideo: Fix 1-byte out-of-bounds read in uvc_parse_format() Date: Tue, 26 Aug 2025 13:10:06 +0200 Message-ID: <20250826110914.541597757@linuxfoundation.org> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20250826110905.607690791@linuxfoundation.org> References: <20250826110905.607690791@linuxfoundation.org> User-Agent: quilt/0.68 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.4-stable review patch. If anyone has any objections, please let me know. ------------------ From: Youngjun Lee commit 782b6a718651eda3478b1824b37a8b3185d2740c upstream. The buffer length check before calling uvc_parse_format() only ensured that the buffer has at least 3 bytes (buflen > 2), buf the function accesses buffer[3], requiring at least 4 bytes. This can lead to an out-of-bounds read if the buffer has exactly 3 bytes. Fix it by checking that the buffer has at least 4 bytes in uvc_parse_format(). Signed-off-by: Youngjun Lee Reviewed-by: Laurent Pinchart Fixes: c0efd232929c ("V4L/DVB (8145a): USB Video Class driver") Cc: stable@vger.kernel.org Reviewed-by: Ricardo Ribalda Link: https://lore.kernel.org/r/20250610124107.37360-1-yjjuny.lee@samsung.com Signed-off-by: Laurent Pinchart Signed-off-by: Hans Verkuil Signed-off-by: Greg Kroah-Hartman --- drivers/media/usb/uvc/uvc_driver.c | 3 +++ 1 file changed, 3 insertions(+) --- a/drivers/media/usb/uvc/uvc_driver.c +++ b/drivers/media/usb/uvc/uvc_driver.c @@ -452,6 +452,9 @@ static int uvc_parse_format(struct uvc_d unsigned int i, n; u8 ftype; + if (buflen < 4) + return -EINVAL; + format->type = buffer[2]; format->index = buffer[3];