From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4107E34AAF8; Tue, 26 Aug 2025 14:40:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756219235; cv=none; b=daQ/u3rFhH/2pzT5UYV73lpBWk3XkeBjq/y6el8hhVvdNWAclY1KqwjVfbEoQbZVCovUY1lss3CI718dIMZLglqGMwrv7591w6kXpbdSC0OTHjgkGJ76DNAMLNr+ieKvoOEpNdaEOwF8gJQq4hiGfClpJmiX5si/KekR9HxjpAA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756219235; c=relaxed/simple; bh=hLzU+RKR2FepF8MVOJ3mqL/j7SgFIQFhcP+Ez93asr8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=fHfqc+Ww7x5CW5mWq+IvSWidI2vsNt/gK4cU5j7zRuvMK75XPdRe0OMOvb4rktSLSx9LCl2zyZAPo/KEfBdty0LSF8t5SGJjoq8PaQyS5wbWKWjTkrh6VWZpPPVhCfulUaZxPFq01OTP+5PLgv2888whs17ew/L7HnZLuR5rkWA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=vmBBFGYs; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="vmBBFGYs" Received: by smtp.kernel.org (Postfix) with ESMTPSA id C8EB3C4CEF1; Tue, 26 Aug 2025 14:40:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1756219235; bh=hLzU+RKR2FepF8MVOJ3mqL/j7SgFIQFhcP+Ez93asr8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=vmBBFGYsc9PmcFCz+kgHrRl9Adm6hAlssgV61eQ/TVqUelw022NbT/F7Y6ssHgUFF YDrqdA+NSlS9e3fnecCgG2cHX1uKk1OYS50MTSTz6WwiHse8hEkKPCiM3pcCuShpFN +2jKETxbB0A3+R0CK/8XMBAB/DfZIi4NR8DZ9fSY= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Haoxiang Li , Dan Carpenter , Nicolas Dufresne , Hans Verkuil Subject: [PATCH 5.4 304/403] media: imx: fix a potential memory leak in imx_media_csc_scaler_device_init() Date: Tue, 26 Aug 2025 13:10:30 +0200 Message-ID: <20250826110915.215407705@linuxfoundation.org> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20250826110905.607690791@linuxfoundation.org> References: <20250826110905.607690791@linuxfoundation.org> User-Agent: quilt/0.68 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.4-stable review patch. If anyone has any objections, please let me know. ------------------ From: Haoxiang Li commit fc5f8aec77704373ee804b5dba0e0e5029c0f180 upstream. Add video_device_release() in label 'err_m2m' to release the memory allocated by video_device_alloc() and prevent potential memory leaks. Remove the reduntant code in label 'err_m2m'. Fixes: a8ef0488cc59 ("media: imx: add csc/scaler mem2mem device") Cc: stable@vger.kernel.org Signed-off-by: Haoxiang Li Reviewed-by: Dan Carpenter Signed-off-by: Nicolas Dufresne Signed-off-by: Hans Verkuil Signed-off-by: Greg Kroah-Hartman --- drivers/staging/media/imx/imx-media-csc-scaler.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/staging/media/imx/imx-media-csc-scaler.c +++ b/drivers/staging/media/imx/imx-media-csc-scaler.c @@ -911,7 +911,7 @@ imx_media_csc_scaler_device_init(struct return &priv->vdev; err_m2m: - video_set_drvdata(vfd, NULL); + video_device_release(vfd); err_vfd: kfree(priv); return ERR_PTR(ret);