From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1E157350D72; Tue, 26 Aug 2025 14:05:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756217128; cv=none; b=TuZ0a7CRYURG6zAcnDeke/2e+aYEzTtdgkxNpbuNvAvOfAAEWFy/0Oavh+dPPevN4pDgW7kSE0MxTC9+c/864pGhHk8EIXlBsXuwMjCDef1eOPR/B6/vx/wuOE2rRey5ScCCE4L34Xuto/JS1+NHvbsV2qzIre7ytDM9/zwYH0I= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756217128; c=relaxed/simple; bh=Y53HQ5ggBKVthhqoijIynZR5p7dAM5h77bYvB2klQqQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=rqXz2DccYt5yH76EYXXXv2FJwpRc+Jvx7ETXm4gGJsQcYHdC0nPJjku+MwHjnvqFU94rJv9OEaPnIr3EY320k91h4uLqya19M6uFIqvcJSdMUJOGPzTUU4eM1CaP/jhI5rxQMTpW6kKIcfZ+PWT1ZGty/jiP7g9SRwaDUYYjy5E= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=L9jZMCz4; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="L9jZMCz4" Received: by smtp.kernel.org (Postfix) with ESMTPSA id AA00AC4CEF1; Tue, 26 Aug 2025 14:05:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1756217128; bh=Y53HQ5ggBKVthhqoijIynZR5p7dAM5h77bYvB2klQqQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=L9jZMCz4gkfUBZj9rsq/sRBwfAajpXQubZOOvU9sv0mUUF3B5MNnmfnhQ49Dr6dW8 SwFDKsxwUKqsCa34VcNSHBXmRuZ+naxXFaGAmrhiI6FUQzfOjgKYt54eWNOdKJDber ogtZs6dp5VfjdYnxs+xB58GHVwAybN+7EAyX7lyI= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Chen Ni , =?UTF-8?q?Nuno=20S=C3=A1?= , Fabrice Gasnier , Stable@vger.kernel.org, Jonathan Cameron Subject: [PATCH 5.10 026/523] iio: adc: stm32-adc: Fix race in installing chained IRQ handler Date: Tue, 26 Aug 2025 13:03:56 +0200 Message-ID: <20250826110925.239438976@linuxfoundation.org> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20250826110924.562212281@linuxfoundation.org> References: <20250826110924.562212281@linuxfoundation.org> User-Agent: quilt/0.68 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Chen Ni commit e8ad595064f6ebd5d2d1a5d5d7ebe0efce623091 upstream. Fix a race where a pending interrupt could be received and the handler called before the handler's data has been setup, by converting to irq_set_chained_handler_and_data(). Fixes: 1add69880240 ("iio: adc: Add support for STM32 ADC core") Signed-off-by: Chen Ni Reviewed-by: Nuno Sá Tested-by: Fabrice Gasnier Reviewed-by: Fabrice Gasnier Link: https://patch.msgid.link/20250515083101.3811350-1-nichen@iscas.ac.cn Cc: Signed-off-by: Jonathan Cameron Signed-off-by: Greg Kroah-Hartman --- drivers/iio/adc/stm32-adc-core.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) --- a/drivers/iio/adc/stm32-adc-core.c +++ b/drivers/iio/adc/stm32-adc-core.c @@ -391,10 +391,9 @@ static int stm32_adc_irq_probe(struct pl return -ENOMEM; } - for (i = 0; i < priv->cfg->num_irqs; i++) { - irq_set_chained_handler(priv->irq[i], stm32_adc_irq_handler); - irq_set_handler_data(priv->irq[i], priv); - } + for (i = 0; i < priv->cfg->num_irqs; i++) + irq_set_chained_handler_and_data(priv->irq[i], + stm32_adc_irq_handler, priv); return 0; }