From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 710EB342CA7; Tue, 26 Aug 2025 14:08:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756217295; cv=none; b=c2AMsV8alXGPwVYvUBMuVsG3qWkWUOlzMATpq2MiaKDHgAy6Mp2wrT/yqaX2ArenhSDFjRbuvLaWxg1SAt0aBcRQCKZqgiV4D9jwmKPijbN0zisk2v7nBiCYpprnJXp1IWRnW9nfQ9rlss1U0X3tpcFR0504YpZSQp4QDS00Mpk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756217295; c=relaxed/simple; bh=hvtYllONwQsXFsEWln5gQUvtOSQZaaMw/vWdY61SVys=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Uz2/kbBt4VjL+upQ3a4j1QDJTkOkMj9ztSkU18Bt7ynnkJT/n2xHkrebNWrPodVfDPiRrHQi+/702c/3chzgGrY8Ol3XW3gtNA4lN5x/MoA9lIus5cKQKQt9lxQg0gE7brmgwK9KRVPixQ/CIEJ62KkysqKDU7AGF2EIt5jzoT8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=NbssmULo; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="NbssmULo" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 00B60C113CF; Tue, 26 Aug 2025 14:08:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1756217295; bh=hvtYllONwQsXFsEWln5gQUvtOSQZaaMw/vWdY61SVys=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=NbssmULooh+F5Q7SboxVheo7rGaimGuzD6xqPOCmtE72lt2varNFLk8Iuj+kHJ1Jo 189r71lqF+0l9sx2QdOusqzzFBALjFhOPnMYl4ZSYVTb0wKJI+RETApXfu7maVOkyf W0vVFKLAe9pcYL5jM3Ni7KMXWoI327av4zTZRyaw= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Lifeng Zheng , "Rafael J. Wysocki" , Sasha Levin Subject: [PATCH 5.10 089/523] cpufreq: Initialize cpufreq-based frequency-invariance later Date: Tue, 26 Aug 2025 13:04:59 +0200 Message-ID: <20250826110926.747222425@linuxfoundation.org> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20250826110924.562212281@linuxfoundation.org> References: <20250826110924.562212281@linuxfoundation.org> User-Agent: quilt/0.68 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Lifeng Zheng [ Upstream commit 2a6c727387062a2ea79eb6cf5004820cb1b0afe2 ] The cpufreq-based invariance is enabled in cpufreq_register_driver(), but never disabled after registration fails. Move the invariance initialization to where all other initializations have been successfully done to solve this problem. Fixes: 874f63531064 ("cpufreq: report whether cpufreq supports Frequency Invariance (FI)") Signed-off-by: Lifeng Zheng Link: https://patch.msgid.link/20250709104145.2348017-2-zhenglifeng1@huawei.com [ rjw: New subject ] Signed-off-by: Rafael J. Wysocki Signed-off-by: Sasha Levin --- drivers/cpufreq/cpufreq.c | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/drivers/cpufreq/cpufreq.c b/drivers/cpufreq/cpufreq.c index 6294e10657b4..6e03526ee759 100644 --- a/drivers/cpufreq/cpufreq.c +++ b/drivers/cpufreq/cpufreq.c @@ -2780,15 +2780,6 @@ int cpufreq_register_driver(struct cpufreq_driver *driver_data) cpufreq_driver = driver_data; write_unlock_irqrestore(&cpufreq_driver_lock, flags); - /* - * Mark support for the scheduler's frequency invariance engine for - * drivers that implement target(), target_index() or fast_switch(). - */ - if (!cpufreq_driver->setpolicy) { - static_branch_enable_cpuslocked(&cpufreq_freq_invariance); - pr_debug("supports frequency invariance"); - } - if (driver_data->setpolicy) driver_data->flags |= CPUFREQ_CONST_LOOPS; @@ -2820,6 +2811,15 @@ int cpufreq_register_driver(struct cpufreq_driver *driver_data) hp_online = ret; ret = 0; + /* + * Mark support for the scheduler's frequency invariance engine for + * drivers that implement target(), target_index() or fast_switch(). + */ + if (!cpufreq_driver->setpolicy) { + static_branch_enable_cpuslocked(&cpufreq_freq_invariance); + pr_debug("supports frequency invariance"); + } + pr_debug("driver %s up and running\n", driver_data->name); goto out; -- 2.39.5