From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7B65621D3F2; Tue, 26 Aug 2025 14:09:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756217385; cv=none; b=sYtSlE7g8Tocoyda9OLd47PbR15Uu9a8vt9+Wfmmi0WxfqzN2zPw7dsucaRZbrUXPJwNtkB4lR/n9KRiz56sRzfNVCI8ngtTDrNf1gv3d2UG1rwFp6mZy2FMdDK2XncXYOT3OK5nLPet/LztliZLgtc+sZMI1zkEQmprg0zO+UU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756217385; c=relaxed/simple; bh=ODWWMA8sZCLZXEH/rE+EZ2CBuWxunC349OKk4vldwLA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=N78hyf0LrEexk6gucimqm6Lg5tfv7LqOSO9BsBfdNW8lb6mPIhA+JC+V5AZLWu4EriZj3QhxavVTu8fc6ucnJpVb3tRKed6KnJo3to+xR2cgZ9hAiV9cU5N0iL5dx/Or4M8cSOgrPGDbsmJKhk3CLbfkh0iHN4kjSRqPVpK+a14= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=JyZGZWxG; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="JyZGZWxG" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 10B4DC4CEF1; Tue, 26 Aug 2025 14:09:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1756217385; bh=ODWWMA8sZCLZXEH/rE+EZ2CBuWxunC349OKk4vldwLA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=JyZGZWxGbt3ZXbjiotuI2CKXzrrGbHaBk5oA2eQoGE4bzLALujLEk9ilJ94dC3Uh3 /8p5/6hGCqbS0QuQGsUv+dYHm0QCd+gNzKFlQceKAyZ/obhxDDLgLmR9eGWPrsea67 gtTsYOEKM7toztE2OmQF03IoV0tHulFnw/UoFGvU= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Henry Martin , David Lechner , Stephen Boyd , Sasha Levin Subject: [PATCH 5.10 123/523] clk: davinci: Add NULL check in davinci_lpsc_clk_register() Date: Tue, 26 Aug 2025 13:05:33 +0200 Message-ID: <20250826110927.548755369@linuxfoundation.org> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20250826110924.562212281@linuxfoundation.org> References: <20250826110924.562212281@linuxfoundation.org> User-Agent: quilt/0.68 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Henry Martin [ Upstream commit 13de464f445d42738fe18c9a28bab056ba3a290a ] devm_kasprintf() returns NULL when memory allocation fails. Currently, davinci_lpsc_clk_register() does not check for this case, which results in a NULL pointer dereference. Add NULL check after devm_kasprintf() to prevent this issue and ensuring no resources are left allocated. Fixes: c6ed4d734bc7 ("clk: davinci: New driver for davinci PSC clocks") Signed-off-by: Henry Martin Link: https://lore.kernel.org/r/20250401131341.26800-1-bsdhenrymartin@gmail.com Reviewed-by: David Lechner Signed-off-by: Stephen Boyd Signed-off-by: Sasha Levin --- drivers/clk/davinci/psc.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/clk/davinci/psc.c b/drivers/clk/davinci/psc.c index 7387e7f6276e..4e1abfc1e564 100644 --- a/drivers/clk/davinci/psc.c +++ b/drivers/clk/davinci/psc.c @@ -278,6 +278,11 @@ davinci_lpsc_clk_register(struct device *dev, const char *name, lpsc->pm_domain.name = devm_kasprintf(dev, GFP_KERNEL, "%s: %s", best_dev_name(dev), name); + if (!lpsc->pm_domain.name) { + clk_hw_unregister(&lpsc->hw); + kfree(lpsc); + return ERR_PTR(-ENOMEM); + } lpsc->pm_domain.attach_dev = davinci_psc_genpd_attach_dev; lpsc->pm_domain.detach_dev = davinci_psc_genpd_detach_dev; lpsc->pm_domain.flags = GENPD_FLAG_PM_CLK; -- 2.39.5