From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 38DD23568E8; Tue, 26 Aug 2025 14:14:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756217656; cv=none; b=hNKTDf8d7ottmlHIrcbVwKbG8CiZES6UNUCEXjbwhZU08GicdcF2gv/sR5RNSKjX7XJSaqQFnTB9NJYDDAADvErssC7H4TpFONHBtWNwXOIGc+RuGjQb7SJPnUcJGOupS5QhRJLHvLGf6YmgvvpwvtvuXany70f1XbKS4P+wPjQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756217656; c=relaxed/simple; bh=816Sulas25PwN509S3mkFEsvuZa6oq6fv0wk2DjBSLo=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Sm6ovipn2/t634R2cHyX+LcgkP3NkCAC+qwcu1nL5GblaRWVCldgDqex4G9ri+Jq0fXWIznUbCejLTBNp/5tDu/WAu3hOdEI2lJF2xFIioLlIxmwc1MbhHKSvaVts77j3AYgGNJ/gQd1IAbuCBucKeYlCE+lZtvbKk65IHEFClU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=1w+aGhRU; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="1w+aGhRU" Received: by smtp.kernel.org (Postfix) with ESMTPSA id C0FD0C4CEF1; Tue, 26 Aug 2025 14:14:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1756217656; bh=816Sulas25PwN509S3mkFEsvuZa6oq6fv0wk2DjBSLo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=1w+aGhRUCE/Y0pYAeIlTk9Bu7nWLKLaZg802uSM4/X1FezJLYsNLBMTmGipkayDkp OobmRAqzAo+TDC8n/q+VVjBlYPM7lZepzRQbwoPd/ih9nS70GL3t34kUEQktv8lYpq cEfoBG0PxBmaXSvIXMDaUJGwJhM5J4j6JI7glFWY= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Mario Limonciello , Mathias Nyman , Sasha Levin Subject: [PATCH 5.10 225/523] usb: xhci: Avoid showing warnings for dying controller Date: Tue, 26 Aug 2025 13:07:15 +0200 Message-ID: <20250826110930.010079496@linuxfoundation.org> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20250826110924.562212281@linuxfoundation.org> References: <20250826110924.562212281@linuxfoundation.org> User-Agent: quilt/0.68 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Mario Limonciello [ Upstream commit 65fc0fc137b5da3ee1f4ca4f61050fcb203d7582 ] When a USB4 dock is unplugged from a system it won't respond to ring events. The PCI core handles the surprise removal event and notifies all PCI drivers. The XHCI PCI driver sets a flag that the device is being removed, and when the device stops responding a flag is also added to indicate it's dying. When that flag is set don't bother to show warnings about a missing controller. Signed-off-by: Mario Limonciello Signed-off-by: Mathias Nyman Acked-by: Mathias Nyman Link: https://lore.kernel.org/r/20250717073107.488599-3-mathias.nyman@linux.intel.com Signed-off-by: Greg Kroah-Hartman Signed-off-by: Sasha Levin --- drivers/usb/host/xhci.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/usb/host/xhci.c b/drivers/usb/host/xhci.c index 908445cff24f..235824d1822a 100644 --- a/drivers/usb/host/xhci.c +++ b/drivers/usb/host/xhci.c @@ -118,7 +118,8 @@ int xhci_halt(struct xhci_hcd *xhci) ret = xhci_handshake(&xhci->op_regs->status, STS_HALT, STS_HALT, XHCI_MAX_HALT_USEC); if (ret) { - xhci_warn(xhci, "Host halt failed, %d\n", ret); + if (!(xhci->xhc_state & XHCI_STATE_DYING)) + xhci_warn(xhci, "Host halt failed, %d\n", ret); return ret; } xhci->xhc_state |= XHCI_STATE_HALTED; @@ -175,7 +176,8 @@ int xhci_reset(struct xhci_hcd *xhci, u64 timeout_us) state = readl(&xhci->op_regs->status); if (state == ~(u32)0) { - xhci_warn(xhci, "Host not accessible, reset failed.\n"); + if (!(xhci->xhc_state & XHCI_STATE_DYING)) + xhci_warn(xhci, "Host not accessible, reset failed.\n"); return -ENODEV; } -- 2.39.5