From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3BE111D5CD4; Tue, 26 Aug 2025 14:17:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756217866; cv=none; b=e7mCcOgZ7JGQJOjcN1hbSt5EGms1e7xawKBHYg9U91Hp/8DdbBQpIfZjF0wuzEm4uZitc+RoJR5ZjE1TDiujMY26btxvng40pHMx6QNTPQhcVfd4E9x7zqvwHzVGWMLQVDrPwdRQDj/jUb8BWT50ZRZeSa9SExbe7gQN7SxUgqQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756217866; c=relaxed/simple; bh=ZKuuJiDvp6DNEDGXzYx/VJ35GTQc2b0VH0nwsaUDjpo=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=g0hMVsXWzuDKsMfzr6txgaOqfB6gGla47SCJOH6vQgJdnflbLxmzwNykO+llKMM9qUbrH3qrpiVDfmty3uBZkhgVaMGH+LeOulTehacIw1kQWJgR52kBfneh+jkMTOheVbUpQKTpQPNaEioC/j+ajKKBb4QKLdPvH6ZtzWGgOSc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=kLbX8U1b; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="kLbX8U1b" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 620F2C4CEF1; Tue, 26 Aug 2025 14:17:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1756217865; bh=ZKuuJiDvp6DNEDGXzYx/VJ35GTQc2b0VH0nwsaUDjpo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=kLbX8U1bKSmKJ7UDu7vzlPcJ8rfGw+ywZiSn5UIlCZILdvPxrv8JDfrV/ezLNXawM GULj0NWYRl5/y1akc7On8cjEGHTTOiRVd1TVb9fbqpbSpZHHuSngOXhW4hqsSYtbo4 IxQ59cX9z1Pvch9znEMLW07HnvEv8mTsVhwN+H1k= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Nevenko Stupar , Ilya Bakoulin , Ray Wu , Daniel Wheeler , Alex Deucher , Sasha Levin Subject: [PATCH 5.10 273/523] drm/amd/display: Separate set_gsl from set_gsl_source_select Date: Tue, 26 Aug 2025 13:08:03 +0200 Message-ID: <20250826110931.164151421@linuxfoundation.org> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20250826110924.562212281@linuxfoundation.org> References: <20250826110924.562212281@linuxfoundation.org> User-Agent: quilt/0.68 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Ilya Bakoulin [ Upstream commit 660a467a5e7366cd6642de61f1aaeaf0d253ee68 ] [Why/How] Separate the checks for set_gsl and set_gsl_source_select, since source_select may not be implemented/necessary. Reviewed-by: Nevenko Stupar Signed-off-by: Ilya Bakoulin Signed-off-by: Ray Wu Tested-by: Daniel Wheeler Signed-off-by: Alex Deucher Signed-off-by: Sasha Levin --- drivers/gpu/drm/amd/display/dc/dcn20/dcn20_hwseq.c | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/amd/display/dc/dcn20/dcn20_hwseq.c b/drivers/gpu/drm/amd/display/dc/dcn20/dcn20_hwseq.c index c6c4888c6665..b6dc99317d7f 100644 --- a/drivers/gpu/drm/amd/display/dc/dcn20/dcn20_hwseq.c +++ b/drivers/gpu/drm/amd/display/dc/dcn20/dcn20_hwseq.c @@ -159,14 +159,13 @@ static void dcn20_setup_gsl_group_as_lock( } /* at this point we want to program whether it's to enable or disable */ - if (pipe_ctx->stream_res.tg->funcs->set_gsl != NULL && - pipe_ctx->stream_res.tg->funcs->set_gsl_source_select != NULL) { + if (pipe_ctx->stream_res.tg->funcs->set_gsl != NULL) { pipe_ctx->stream_res.tg->funcs->set_gsl( pipe_ctx->stream_res.tg, &gsl); - - pipe_ctx->stream_res.tg->funcs->set_gsl_source_select( - pipe_ctx->stream_res.tg, group_idx, enable ? 4 : 0); + if (pipe_ctx->stream_res.tg->funcs->set_gsl_source_select != NULL) + pipe_ctx->stream_res.tg->funcs->set_gsl_source_select( + pipe_ctx->stream_res.tg, group_idx, enable ? 4 : 0); } else BREAK_TO_DEBUGGER(); } -- 2.39.5