From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6211C35690E; Tue, 26 Aug 2025 14:17:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756217871; cv=none; b=fhaHfWdgTcG5pgUN4WunQX7gFWEj42PQ5Fp+zTknOVtrHLuFd3akv4T8Mg7MQ8buHEllOUQt8TRX5558JmZI/iYdS+LnAjHkRGNXD8R6NNtmMajXH2JZ+JU/hmcVbmo09vg+p6gdXb7qGdPWXQx91d8mzjfPcPuLwRkYJPUmY24= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756217871; c=relaxed/simple; bh=PomSzC9CSBk6qDVQ5l57wHXCIsqm1JlOsOECyTUgk6c=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=nOscLaF9Ugy7DmD65cc0wY8bSQZJwGBcZQ4ctOUKAWYzlavfYNKTY1f/MgA/GjFxXbNZwx2nDJr3y8zAxXtlQ3dNtJhbcL6l8LhM1NCdKGtDvymgnOpR1rTDE63ZKp1+6jv13l4Lpvw0PDk4GLmafJZhdQvgo0PMQc8AdEG6z2E= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=ku9uAeJq; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="ku9uAeJq" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 99D65C4CEF1; Tue, 26 Aug 2025 14:17:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1756217871; bh=PomSzC9CSBk6qDVQ5l57wHXCIsqm1JlOsOECyTUgk6c=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ku9uAeJqlu9Mzjfn3i7p2XO5PrRBahUVy0IYhKKUXrVnN4sYaHQz1ivrCqEpPPMRo xvsUW+Y9R6DPbbPPKIK2imG8UiaSo4UPDdbs+UO8a3VkefELYHkRB8eZPxHZQn+60N Ht3yG/hnIqqF442DwTJC3fRDD3CRhuE2Rz2l2hE8= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Pagadala Yesu Anjaneyulu , Miri Korenblit , Sasha Levin Subject: [PATCH 5.10 275/523] wifi: iwlwifi: fw: Fix possible memory leak in iwl_fw_dbg_collect Date: Tue, 26 Aug 2025 13:08:05 +0200 Message-ID: <20250826110931.214548332@linuxfoundation.org> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20250826110924.562212281@linuxfoundation.org> References: <20250826110924.562212281@linuxfoundation.org> User-Agent: quilt/0.68 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Pagadala Yesu Anjaneyulu [ Upstream commit cc8d9cbf269dab363c768bfa9312265bc807fca5 ] Ensure descriptor is freed on error to avoid memory leak. Signed-off-by: Pagadala Yesu Anjaneyulu Signed-off-by: Miri Korenblit Link: https://patch.msgid.link/20250611222325.8158d15ec866.Ifa3e422c302397111f20a16da7509e6574bc19e3@changeid Signed-off-by: Sasha Levin --- drivers/net/wireless/intel/iwlwifi/fw/dbg.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/net/wireless/intel/iwlwifi/fw/dbg.c b/drivers/net/wireless/intel/iwlwifi/fw/dbg.c index 558caf78a56d..37c1158b9225 100644 --- a/drivers/net/wireless/intel/iwlwifi/fw/dbg.c +++ b/drivers/net/wireless/intel/iwlwifi/fw/dbg.c @@ -2507,6 +2507,7 @@ int iwl_fw_dbg_collect(struct iwl_fw_runtime *fwrt, struct iwl_fw_dump_desc *desc; unsigned int delay = 0; bool monitor_only = false; + int ret; if (trigger) { u16 occurrences = le16_to_cpu(trigger->occurrences) - 1; @@ -2537,7 +2538,11 @@ int iwl_fw_dbg_collect(struct iwl_fw_runtime *fwrt, desc->trig_desc.type = cpu_to_le32(trig); memcpy(desc->trig_desc.data, str, len); - return iwl_fw_dbg_collect_desc(fwrt, desc, monitor_only, delay); + ret = iwl_fw_dbg_collect_desc(fwrt, desc, monitor_only, delay); + if (ret) + kfree(desc); + + return ret; } IWL_EXPORT_SYMBOL(iwl_fw_dbg_collect); -- 2.39.5