From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3DB43352067; Tue, 26 Aug 2025 14:21:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756218067; cv=none; b=g8HsfpmedN9CI0WWvzrAdq3fQH5E1bxjEbNYjHLZf6UTBChzjPd9xYLatmh4c1oxqwuVQmD+rjto3hOBXXE9qQJGJYJAyGugpuJKBd6TaT3fs+9BOqHi1VJv2912/UE7MRC15eoHcrR5PhxzjrB3+w9MYVlLvQAqHzfxABHm1Zw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756218067; c=relaxed/simple; bh=yHmpKuJusqM14UMOksodTrjM95biyJp+WXj6kiFU2fY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=bcVqGF0SzaqWDv0Z+yXcW8DlDixQYf0TEsLWe4ymY8Uyv1i9OOhRpckTcwgiYCBUO5XZCld1e+VHnoFpQJy4Oux0t0HT1FycLW9a5VnMPIZHxZVRS7af4MVbWyutoNJ5B0UrH805IwyOSD0baroZVFSxf4nuaDtLe+fHpwF1pkQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=bnVoif/J; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="bnVoif/J" Received: by smtp.kernel.org (Postfix) with ESMTPSA id B7085C4CEF1; Tue, 26 Aug 2025 14:21:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1756218067; bh=yHmpKuJusqM14UMOksodTrjM95biyJp+WXj6kiFU2fY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=bnVoif/JuuGm8y6Jj3uvQYXYJOSLcp3jDIYfAYrd4iCJOOU6UNgkfCHWenWgYmAb7 24CKAXHWKig5p7jDcLamA01I7Vi7BJOEi0eXGobc4id4IF2tclevq7kA5lhr/LG/ce FltJavbT9wNFQCbdlUaDjsBzRXnrzlk+HiCIzZpg= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Gui-Dong Han , Hans Verkuil Subject: [PATCH 5.10 381/523] media: rainshadow-cec: fix TOCTOU race condition in rain_interrupt() Date: Tue, 26 Aug 2025 13:09:51 +0200 Message-ID: <20250826110933.861572078@linuxfoundation.org> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20250826110924.562212281@linuxfoundation.org> References: <20250826110924.562212281@linuxfoundation.org> User-Agent: quilt/0.68 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Gui-Dong Han commit 7af160aea26c7dc9e6734d19306128cce156ec40 upstream. In the interrupt handler rain_interrupt(), the buffer full check on rain->buf_len is performed before acquiring rain->buf_lock. This creates a Time-of-Check to Time-of-Use (TOCTOU) race condition, as rain->buf_len is concurrently accessed and modified in the work handler rain_irq_work_handler() under the same lock. Multiple interrupt invocations can race, with each reading buf_len before it becomes full and then proceeding. This can lead to both interrupts attempting to write to the buffer, incrementing buf_len beyond its capacity (DATA_SIZE) and causing a buffer overflow. Fix this bug by moving the spin_lock() to before the buffer full check. This ensures that the check and the subsequent buffer modification are performed atomically, preventing the race condition. An corresponding spin_unlock() is added to the overflow path to correctly release the lock. This possible bug was found by an experimental static analysis tool developed by our team. Fixes: 0f314f6c2e77 ("[media] rainshadow-cec: new RainShadow Tech HDMI CEC driver") Cc: stable@vger.kernel.org Signed-off-by: Gui-Dong Han Signed-off-by: Hans Verkuil Signed-off-by: Greg Kroah-Hartman --- drivers/media/cec/usb/rainshadow/rainshadow-cec.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) --- a/drivers/media/cec/usb/rainshadow/rainshadow-cec.c +++ b/drivers/media/cec/usb/rainshadow/rainshadow-cec.c @@ -171,11 +171,12 @@ static irqreturn_t rain_interrupt(struct { struct rain *rain = serio_get_drvdata(serio); + spin_lock(&rain->buf_lock); if (rain->buf_len == DATA_SIZE) { + spin_unlock(&rain->buf_lock); dev_warn_once(rain->dev, "buffer overflow\n"); return IRQ_HANDLED; } - spin_lock(&rain->buf_lock); rain->buf_len++; rain->buf[rain->buf_wr_idx] = data; rain->buf_wr_idx = (rain->buf_wr_idx + 1) & 0xff;