From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D3DE3350842; Tue, 26 Aug 2025 14:23:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756218234; cv=none; b=vACya14zAsFNYYLvsDP/jMy8gIVwvdjB81e1cwaf5dMELKdmIHFGeoZgqX3irvVoi58G01edZOP3mE2f0TGFjrCgXRyjyr4ko5z21B4701R1rOAF1C1Zysc6cw/wtK8cQvFHZnTmHvORJI+cjxZrFp05q8qza2bXl2eoByJpaYw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756218234; c=relaxed/simple; bh=4xl5d6Tp7g1viq1GrOCzhPPvUsIZ5BKqbXVRCderySE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=LT+W4i5eNnagdXf7ish5lOI4OxwjZYu+JnfW6Hpub56QcsHNNFLIFa6XQBlPRhtTJM+OOWLU70oH42FHNXBeXP+mutmVRtXjezq7ZlR69EUTZVliTgdj//36javNDzgL/L6uJB9AkcK+1lnhFU4OLEN6TN4KwYN6WIcttmjHz6o= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=BLuhnR0I; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="BLuhnR0I" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5D100C4CEF1; Tue, 26 Aug 2025 14:23:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1756218234; bh=4xl5d6Tp7g1viq1GrOCzhPPvUsIZ5BKqbXVRCderySE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=BLuhnR0Id6j/KczqS8qUFn8Viik8id8af/+MQHTCDFJY6z+OfcAuvlj48tyRISKVU kpW8sTleD/PWaPpMiPXQEUpzA7DpNOQQd+8GohQpETjdYjRCOwZcXC5N16uTU1OZ+6 xWJgBTOom1KEI/AAQzKqoGoqUq6Sk3hy3hqb6Wsc= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Ma Ke , Ioana Ciornei , Simon Horman , Jakub Kicinski , Sasha Levin Subject: [PATCH 5.10 445/523] dpaa2-eth: Fix device reference count leak in MAC endpoint handling Date: Tue, 26 Aug 2025 13:10:55 +0200 Message-ID: <20250826110935.427405113@linuxfoundation.org> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20250826110924.562212281@linuxfoundation.org> References: <20250826110924.562212281@linuxfoundation.org> User-Agent: quilt/0.68 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Ma Ke [ Upstream commit ee9f3a81ab08dfe0538dbd1746f81fd4d5147fdc ] The fsl_mc_get_endpoint() function uses device_find_child() for localization, which implicitly calls get_device() to increment the device's reference count before returning the pointer. However, the caller dpaa2_eth_connect_mac() fails to properly release this reference in multiple scenarios. We should call put_device() to decrement reference count properly. As comment of device_find_child() says, 'NOTE: you will need to drop the reference with put_device() after use'. Found by code review. Cc: stable@vger.kernel.org Fixes: 719479230893 ("dpaa2-eth: add MAC/PHY support through phylink") Signed-off-by: Ma Ke Tested-by: Ioana Ciornei Reviewed-by: Ioana Ciornei Reviewed-by: Simon Horman Link: https://patch.msgid.link/20250717022309.3339976-2-make24@iscas.ac.cn Signed-off-by: Jakub Kicinski Signed-off-by: Sasha Levin Signed-off-by: Greg Kroah-Hartman --- drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c | 15 ++++++++++++--- 1 file changed, 12 insertions(+), 3 deletions(-) --- a/drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c +++ b/drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c @@ -4138,12 +4138,19 @@ static int dpaa2_eth_connect_mac(struct if (PTR_ERR(dpmac_dev) == -EPROBE_DEFER) return PTR_ERR(dpmac_dev); - if (IS_ERR(dpmac_dev) || dpmac_dev->dev.type != &fsl_mc_bus_dpmac_type) + if (IS_ERR(dpmac_dev)) return 0; + if (dpmac_dev->dev.type != &fsl_mc_bus_dpmac_type) { + err = 0; + goto out_put_device; + } + mac = kzalloc(sizeof(struct dpaa2_mac), GFP_KERNEL); - if (!mac) - return -ENOMEM; + if (!mac) { + err = -ENOMEM; + goto out_put_device; + } mac->mc_dev = dpmac_dev; mac->mc_io = priv->mc_io; @@ -4169,6 +4176,8 @@ err_close_mac: priv->mac = NULL; err_free_mac: kfree(mac); +out_put_device: + put_device(&dpmac_dev->dev); return err; }