From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0B853AD4B; Tue, 26 Aug 2025 13:22:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756214578; cv=none; b=BAV1tBnxbXgRfj2OuWP9IU7RpLGKc5DvRUFgcAMIHVIaXGpGhhFs7YyOAzdlgj2u/YVfYtNJ6ZyYIXTbscrNZ99QOKUIZqk3FwOqIHiRbHZWND+Z6rixzTYHR4GJw8lnFWu4esfiwgBmmEpeLjHqC9uwONB1d4IO+okKfOzb/6E= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756214578; c=relaxed/simple; bh=ZsvwhIn0M9QiUeH/Ia1IRS/Z3o2vUpyisr2Ay9yJeY0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=bLBh/2Az+M8DqaQO3tmS0n0JI+gpSi6e8avyNRrMloC5i5vWDLWKnfysy9qJIp2uCsDOSD5VB9FXfdDJNykPUD/4xALWRHPYfyJthpOrHXvd+QFriUoEM4EHhl9yGDGxZRkfUEkHP1WogA+1X7+T4bAnom8J3dA1QrIyxhFg5zY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=uROjd0qf; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="uROjd0qf" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3794FC4CEF1; Tue, 26 Aug 2025 13:22:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1756214577; bh=ZsvwhIn0M9QiUeH/Ia1IRS/Z3o2vUpyisr2Ay9yJeY0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=uROjd0qfXewTQ5VgiazbG3IV9M7GlqqNxSx49FQ0ogKpGOQbpIfwUBVEm35OLun9k XIiYTsaWrdxeFE9yvPew40XPZA5DMUMVq+3IMGkeG2RebuksOEerttcXMLvH9e1DF4 Cc9vPwfK/lPHNGXzZ1AnqFvFh0eyyBPOe3zwL8wU= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, =?UTF-8?q?Niklas=20S=C3=B6derlund?= , Sakari Ailus , Hans Verkuil , Sasha Levin Subject: [PATCH 6.1 191/482] media: v4l2-common: Reduce warnings about missing V4L2_CID_LINK_FREQ control Date: Tue, 26 Aug 2025 13:07:24 +0200 Message-ID: <20250826110935.523039703@linuxfoundation.org> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20250826110930.769259449@linuxfoundation.org> References: <20250826110930.769259449@linuxfoundation.org> User-Agent: quilt/0.68 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit 6.1-stable review patch. If anyone has any objections, please let me know. ------------------ From: Niklas Söderlund [ Upstream commit 5a0abb8909b9dcf347fce1d201ac6686ac33fd64 ] When operating a pipeline with a missing V4L2_CID_LINK_FREQ control this two line warning is printed each time the pipeline is started. Reduce this excessive logging by only warning once for the missing control. Signed-off-by: Niklas Söderlund Signed-off-by: Sakari Ailus Signed-off-by: Hans Verkuil Signed-off-by: Sasha Levin --- drivers/media/v4l2-core/v4l2-common.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/media/v4l2-core/v4l2-common.c b/drivers/media/v4l2-core/v4l2-common.c index 40f56e044640..1c8d36684809 100644 --- a/drivers/media/v4l2-core/v4l2-common.c +++ b/drivers/media/v4l2-core/v4l2-common.c @@ -475,10 +475,10 @@ s64 v4l2_get_link_freq(struct v4l2_ctrl_handler *handler, unsigned int mul, freq = div_u64(v4l2_ctrl_g_ctrl_int64(ctrl) * mul, div); - pr_warn("%s: Link frequency estimated using pixel rate: result might be inaccurate\n", - __func__); - pr_warn("%s: Consider implementing support for V4L2_CID_LINK_FREQ in the transmitter driver\n", - __func__); + pr_warn_once("%s: Link frequency estimated using pixel rate: result might be inaccurate\n", + __func__); + pr_warn_once("%s: Consider implementing support for V4L2_CID_LINK_FREQ in the transmitter driver\n", + __func__); } return freq > 0 ? freq : -EINVAL; -- 2.39.5