From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6F97826FDBF; Tue, 26 Aug 2025 13:31:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756215066; cv=none; b=Ic0e7xKP9CjDDagknKhz0RU2/9Jgufc5dh7DgPPYD0+tpj/qxvTnH4wgZ9gJ8G/nzdnBIL59EXWWUPI4Kdf+ZrMPc4GbaOurbF4dI2qGT4DABxzpt6umsheLj2wsF/0OBIRKsh5rVsXi53btcgGaAmsFLqSP9UW84vXUeM3J4JM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756215066; c=relaxed/simple; bh=IApXsaxtkh7AmG8c/3UMAWRWHvnjwxin7JzBw8y1KUI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=YQ8djlSCKGn1bhC07ofOH+WZUEZPZK1b5nQrhrlKJ6MhGw6/T35+CSRPB3KLlyXd4TRLy/BN5TrC8S8QdurDOze4HlskX5q1wQlGvs9G4CcvEj1dI/iGoqlDqokr8FbUQYt+a8U3RhmGLERwRzHMHNzx5QId7pki+4Zp6F1NdYI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=hE3XdErH; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="hE3XdErH" Received: by smtp.kernel.org (Postfix) with ESMTPSA id EE12AC4CEF1; Tue, 26 Aug 2025 13:31:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1756215066; bh=IApXsaxtkh7AmG8c/3UMAWRWHvnjwxin7JzBw8y1KUI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=hE3XdErHWQHc4gvvkc+Ul5guy6eKXugcuPz/4VV5WYMvjiqnehrigTJ1fqEv4RfZ9 m06x7AnJNo0BX9yw8vNm3PuAF7eLnxIDoscsjZXH+tRCChsstd59XsPoRGeYnj9XCh lRYO/yOcg+ZF0QXg9n6LTEweHuUXtkabcp5r7MoE= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Li Jun , Johan Hovold , Sasha Levin Subject: [PATCH 6.1 374/482] usb: dwc3: imx8mp: fix device leak at unbind Date: Tue, 26 Aug 2025 13:10:27 +0200 Message-ID: <20250826110940.071468743@linuxfoundation.org> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20250826110930.769259449@linuxfoundation.org> References: <20250826110930.769259449@linuxfoundation.org> User-Agent: quilt/0.68 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.1-stable review patch. If anyone has any objections, please let me know. ------------------ From: Johan Hovold [ Upstream commit 086a0e516f7b3844e6328a5c69e2708b66b0ce18 ] Make sure to drop the reference to the dwc3 device taken by of_find_device_by_node() on probe errors and on driver unbind. Fixes: 6dd2565989b4 ("usb: dwc3: add imx8mp dwc3 glue layer driver") Cc: stable@vger.kernel.org # 5.12 Cc: Li Jun Signed-off-by: Johan Hovold Link: https://lore.kernel.org/r/20250724091910.21092-2-johan@kernel.org Signed-off-by: Greg Kroah-Hartman Signed-off-by: Sasha Levin Signed-off-by: Greg Kroah-Hartman --- drivers/usb/dwc3/dwc3-imx8mp.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) --- a/drivers/usb/dwc3/dwc3-imx8mp.c +++ b/drivers/usb/dwc3/dwc3-imx8mp.c @@ -243,7 +243,7 @@ static int dwc3_imx8mp_probe(struct plat IRQF_ONESHOT, dev_name(dev), dwc3_imx); if (err) { dev_err(dev, "failed to request IRQ #%d --> %d\n", irq, err); - goto depopulate; + goto put_dwc3; } device_set_wakeup_capable(dev, true); @@ -251,6 +251,8 @@ static int dwc3_imx8mp_probe(struct plat return 0; +put_dwc3: + put_device(&dwc3_imx->dwc3->dev); depopulate: of_platform_depopulate(dev); err_node_put: @@ -271,6 +273,8 @@ static int dwc3_imx8mp_remove(struct pla struct dwc3_imx8mp *dwc3_imx = platform_get_drvdata(pdev); struct device *dev = &pdev->dev; + put_device(&dwc3_imx->dwc3->dev); + pm_runtime_get_sync(dev); of_platform_depopulate(dev);