From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EDC96321433; Tue, 26 Aug 2025 11:29:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756207758; cv=none; b=RB3eRCr9RIOP+ihETBp7HGKqC8S7Qt75UX6ajlgzX4hB/CgEZhmgBsBlU7aXejq2h9FtJ7RNJ3mMaQg2G9Etp8LY23GFqxYB/zfpLOQuEQpzo6GT4ZiKm7VQnQk7fWa1fyK6A6ypSxCZ97lP6Pd8LUUv4gJGkPbo8Ct6e/i7RR8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756207758; c=relaxed/simple; bh=XB9FmszDvFw2CD0/rNawhq90bDgMhaLvG6LzFDe1+bs=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=oxLbzd+zXc2GgpXR9gT9mpTQiR/PLkE1UUv96IlXB5KpQtSuOzzTTfscXgEOXZY+YXvAh5NwrTMOFkQnZatAwDxFFZMxDL/PMpCV8JBQ1n4p+Y5EY24peXA6o9p4/QX6hWOuMklLeElCf49apwDnEuc3CwLv8KuUYiF2SDZCYNE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=YofdPCuA; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="YofdPCuA" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 852E8C4CEF1; Tue, 26 Aug 2025 11:29:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1756207757; bh=XB9FmszDvFw2CD0/rNawhq90bDgMhaLvG6LzFDe1+bs=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=YofdPCuAlqI9JLP1P06geAsVegXBuMpuB3+c1qDjkLlx1a5hxGneQIiVbBBV/Em+L u3xnl9kE6+IqTaIzYEhLGkNfz9sZtqX0fNUFCELcbfvUgkzMVpuMw0eQ8me6PEAaTi YSfvg4TAT0kIhT7iK7GeXF+TBsVikXPfxIJGkX1c= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, David Lechner , Stable@vger.kernel.org, Jonathan Cameron Subject: [PATCH 6.16 305/457] iio: proximity: isl29501: fix buffered read on big-endian systems Date: Tue, 26 Aug 2025 13:09:49 +0200 Message-ID: <20250826110944.905737572@linuxfoundation.org> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20250826110937.289866482@linuxfoundation.org> References: <20250826110937.289866482@linuxfoundation.org> User-Agent: quilt/0.68 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.16-stable review patch. If anyone has any objections, please let me know. ------------------ From: David Lechner commit de18e978d0cda23e4c102e18092b63a5b0b3a800 upstream. Fix passing a u32 value as a u16 buffer scan item. This works on little- endian systems, but not on big-endian systems. A new local variable is introduced for getting the register value and the array is changed to a struct to make the data layout more explicit rather than just changing the type and having to recalculate the proper length needed for the timestamp. Fixes: 1c28799257bc ("iio: light: isl29501: Add support for the ISL29501 ToF sensor.") Signed-off-by: David Lechner Link: https://patch.msgid.link/20250722-iio-use-more-iio_declare_buffer_with_ts-7-v2-1-d3ebeb001ed3@baylibre.com Cc: Signed-off-by: Jonathan Cameron Signed-off-by: Greg Kroah-Hartman --- drivers/iio/proximity/isl29501.c | 14 ++++++++++---- 1 file changed, 10 insertions(+), 4 deletions(-) --- a/drivers/iio/proximity/isl29501.c +++ b/drivers/iio/proximity/isl29501.c @@ -938,12 +938,18 @@ static irqreturn_t isl29501_trigger_hand struct iio_dev *indio_dev = pf->indio_dev; struct isl29501_private *isl29501 = iio_priv(indio_dev); const unsigned long *active_mask = indio_dev->active_scan_mask; - u32 buffer[4] __aligned(8) = {}; /* 1x16-bit + naturally aligned ts */ + u32 value; + struct { + u16 data; + aligned_s64 ts; + } scan = { }; - if (test_bit(ISL29501_DISTANCE_SCAN_INDEX, active_mask)) - isl29501_register_read(isl29501, REG_DISTANCE, buffer); + if (test_bit(ISL29501_DISTANCE_SCAN_INDEX, active_mask)) { + isl29501_register_read(isl29501, REG_DISTANCE, &value); + scan.data = value; + } - iio_push_to_buffers_with_timestamp(indio_dev, buffer, pf->timestamp); + iio_push_to_buffers_with_timestamp(indio_dev, &scan, pf->timestamp); iio_trigger_notify_done(indio_dev->trig); return IRQ_HANDLED;