From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CA17034DCEC; Tue, 26 Aug 2025 13:52:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756216323; cv=none; b=FTH+wnRIqKaMpbesSByTAfjOktt4v0TW3aiqEC+JRCQriNK+DBK0FYZES+CsIWwDA4JbYPX05nRQMLwYIFMA5Z3d/sGru0VyIsIS4gPATXxumDWnCx3aMuxJCaRjT7kz3LLtd2hyDQdmodyHCu20whQrCFDZmle1kex4OjWapiM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756216323; c=relaxed/simple; bh=J5F3PLJrQDYhLcjw7WDrPR3g1Y3+mN7mfvca0ILWrgQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=P5yhULskb3A1RInjs0gd4uAiVJifwJoMFD3Xi/T7APdWhbVYnrbsPvlZrJbS06hdPJDKeKamWHPbCq6pBf02xJ2xZpvU8KzzprXlCd45SZjFoVPBPstPWGNjdCtWft1LxWmu4ecV4j/ZHSdZo71uJzMXIzzqWo1sNG4KHf4W6lY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=LmqntNA9; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="LmqntNA9" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5A630C4CEF1; Tue, 26 Aug 2025 13:52:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1756216323; bh=J5F3PLJrQDYhLcjw7WDrPR3g1Y3+mN7mfvca0ILWrgQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=LmqntNA92VJwaRnFcGEaQK+D8InUFMpbX4zLComFXgkTaEM062mVgTpkioJv9/Sdf ARycgHDpyAomynCQqTyeiDDB3q1W82qPjcj2EWHJhgyaqn1pNkGQZomwN9EpjQaf+W CJv4N0vc7uvhxfV7yeDurIrjsRD81Zif0Rm/78q8= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Heiner Kallweit , Jacob Keller , Jakub Kicinski , Sasha Levin Subject: [PATCH 5.15 368/644] dpaa_eth: dont use fixed_phy_change_carrier Date: Tue, 26 Aug 2025 13:07:39 +0200 Message-ID: <20250826110955.535244520@linuxfoundation.org> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20250826110946.507083938@linuxfoundation.org> References: <20250826110946.507083938@linuxfoundation.org> User-Agent: quilt/0.68 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.15-stable review patch. If anyone has any objections, please let me know. ------------------ From: Heiner Kallweit [ Upstream commit d8155c1df5c8b717052567b188455d41fa7a8908 ] This effectively reverts 6e8b0ff1ba4c ("dpaa_eth: Add change_carrier() for Fixed PHYs"). Usage of fixed_phy_change_carrier() requires that fixed_phy_register() has been called before, directly or indirectly. And that's not the case in this driver. Signed-off-by: Heiner Kallweit Reviewed-by: Jacob Keller Link: https://patch.msgid.link/7eb189b3-d5fd-4be6-8517-a66671a4e4e3@gmail.com Signed-off-by: Jakub Kicinski Signed-off-by: Sasha Levin --- drivers/net/ethernet/freescale/dpaa/dpaa_eth.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c b/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c index 6fbf4efa0786..c2fe8827346f 100644 --- a/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c +++ b/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c @@ -52,7 +52,6 @@ #include #include #include -#include #include #include #include @@ -3168,7 +3167,6 @@ static const struct net_device_ops dpaa_ops = { .ndo_stop = dpaa_eth_stop, .ndo_tx_timeout = dpaa_tx_timeout, .ndo_get_stats64 = dpaa_get_stats64, - .ndo_change_carrier = fixed_phy_change_carrier, .ndo_set_mac_address = dpaa_set_mac_address, .ndo_validate_addr = eth_validate_addr, .ndo_set_rx_mode = dpaa_set_rx_mode, -- 2.39.5