From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3BA32187554; Tue, 26 Aug 2025 12:55:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756212933; cv=none; b=F5JxZvx42UOl3poDgagbs8IoiLzgMUOrggm54nZRA0xfK8YlkTZAJxUZfYYIfaoO72h/tuywE54sGXUxmvlNrEckFfkp2lR4RYdlixAxVxAB09q5YIVS3Ot0JzLNZQSe3GsNru8iAR9UdSpJWr7BUuK0QGwfUwFP8y5r3AvfOdw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756212933; c=relaxed/simple; bh=3YTl0d9Sm3J6Z5LPMx824ElMFVURMooMuVyC6EXlbug=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=TqrGxB3WNVQfkrAOfOCjvo6t5YSy95bddJq0X54/Q42fmBZE5V4I1fwjCbTRJ3rXp8WdVQ6HN5/IkvFqrofAinRFNvvp2fOgBvqsduxETSP2hmRyRLgN+U1ALAhIH2yrA64KjhG4m9Dj3RZByXxqHgjqZxSGz+lhsJ6tTcxwZsc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=Z8gLf9Y1; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="Z8gLf9Y1" Received: by smtp.kernel.org (Postfix) with ESMTPSA id C2112C4CEF1; Tue, 26 Aug 2025 12:55:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1756212933; bh=3YTl0d9Sm3J6Z5LPMx824ElMFVURMooMuVyC6EXlbug=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Z8gLf9Y1weoFkY8bckMwGkCKeFWHZO/0fNDJ6zXv7egeih0xFVMuzKwGs6uq9j9/c 68IbhHw3MTeZZGiblEaseDX/Ygh2tCGRnnk8vZCOHrw3/yDIev3jik4kDgVUpecfBs YPXvSMWpNp9o0PuawoU4JsSP//DJl/ivTPJUsg2w= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Oliver Neukum , Alan Stern , Sasha Levin Subject: [PATCH 6.6 127/587] usb: core: usb_submit_urb: downgrade type check Date: Tue, 26 Aug 2025 13:04:36 +0200 Message-ID: <20250826110956.186460395@linuxfoundation.org> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20250826110952.942403671@linuxfoundation.org> References: <20250826110952.942403671@linuxfoundation.org> User-Agent: quilt/0.68 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.6-stable review patch. If anyone has any objections, please let me know. ------------------ From: Oliver Neukum [ Upstream commit 503bbde34cc3dd2acd231f277ba70c3f9ed22e59 ] Checking for the endpoint type is no reason for a WARN, as that can cause a reboot. A driver not checking the endpoint type must not cause a reboot, as there is just no point in this. We cannot prevent a device from doing something incorrect as a reaction to a transfer. Hence warning for a mere assumption being wrong is not sensible. Signed-off-by: Oliver Neukum Acked-by: Alan Stern Link: https://lore.kernel.org/r/20250612122149.2559724-1-oneukum@suse.com Signed-off-by: Greg Kroah-Hartman Signed-off-by: Sasha Levin --- drivers/usb/core/urb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/core/urb.c b/drivers/usb/core/urb.c index 7576920e2d5a..9f202f575cec 100644 --- a/drivers/usb/core/urb.c +++ b/drivers/usb/core/urb.c @@ -500,7 +500,7 @@ int usb_submit_urb(struct urb *urb, gfp_t mem_flags) /* Check that the pipe's type matches the endpoint's type */ if (usb_pipe_type_check(urb->dev, urb->pipe)) - dev_WARN(&dev->dev, "BOGUS urb xfer, pipe %x != type %x\n", + dev_warn_once(&dev->dev, "BOGUS urb xfer, pipe %x != type %x\n", usb_pipetype(urb->pipe), pipetypes[xfertype]); /* Check against a simple/standard policy */ -- 2.39.5