From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7504C221290; Tue, 26 Aug 2025 13:00:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756213214; cv=none; b=PqEN6kGaqwRnG3/vzf2+0rgplGjfxtXiMHy6D1eS7lApoAvnrqNj9U3j66mEHtB00QTf13xtOL/yjY3bwTBqJA/74w7oiJsNIQt+x6p+Z8A/DesbHJb5iusKiJBQSLkxuqFhcdTAzsxUrNKrtxtbAzU53oIEGvB9nwQXvNxEFdI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756213214; c=relaxed/simple; bh=cxjJR0xL96ECTWp4wWucSEk/IZg1wYIb6Pp4IBD5EVw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=maZuUFOGmrOAXatzqJBl+u358LnKC09ebJD7fMUIS0AkcgqREmspuk+gfZoCsG+TrG7u/K9DDujB5+xCjpkKsPaSfmU1CrcaI33cvFB8WzlnU6yCg8StZW4jcp/tHKzWoIjJEhSgZCbCizc2Rbsc4mfB6AqGFy5Hte1i/dppT00= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=OutUvV6n; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="OutUvV6n" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0AD95C4CEF1; Tue, 26 Aug 2025 13:00:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1756213214; bh=cxjJR0xL96ECTWp4wWucSEk/IZg1wYIb6Pp4IBD5EVw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=OutUvV6nkHmhgHAXpBqRL5V2ur6UerHitA+lZpoh6yRTEaJ0F4TABfXzEZtiG/V5D Je/cPKZAfqzu8grA3fbwlv/LtEOgrl8gsGjvE0e5hGF6V5Lhsxdc5zQzpXQa+ffgw2 XahNvDd/J+B1Bp2O2zFGFJRIg+v7z8F8Vqk8rwCU= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Alex Guo , Mauro Carvalho Chehab , Sasha Levin Subject: [PATCH 6.6 256/587] media: dvb-frontends: w7090p: fix null-ptr-deref in w7090p_tuner_write_serpar and w7090p_tuner_read_serpar Date: Tue, 26 Aug 2025 13:06:45 +0200 Message-ID: <20250826110959.443902431@linuxfoundation.org> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20250826110952.942403671@linuxfoundation.org> References: <20250826110952.942403671@linuxfoundation.org> User-Agent: quilt/0.68 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.6-stable review patch. If anyone has any objections, please let me know. ------------------ From: Alex Guo [ Upstream commit ed0234c8458b3149f15e496b48a1c9874dd24a1b ] In w7090p_tuner_write_serpar, msg is controlled by user. When msg[0].buf is null and msg[0].len is zero, former checks on msg[0].buf would be passed. If accessing msg[0].buf[2] without sanity check, null pointer deref would happen. We add check on msg[0].len to prevent crash. Similar commit: commit 0ed554fd769a ("media: dvb-usb: az6027: fix null-ptr-deref in az6027_i2c_xfer()") Signed-off-by: Alex Guo Link: https://lore.kernel.org/r/20250616013353.738790-1-alexguo1023@gmail.com Signed-off-by: Mauro Carvalho Chehab Signed-off-by: Sasha Levin --- drivers/media/dvb-frontends/dib7000p.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/media/dvb-frontends/dib7000p.c b/drivers/media/dvb-frontends/dib7000p.c index f94660dd9df0..e561c7cc35bf 100644 --- a/drivers/media/dvb-frontends/dib7000p.c +++ b/drivers/media/dvb-frontends/dib7000p.c @@ -2198,6 +2198,8 @@ static int w7090p_tuner_write_serpar(struct i2c_adapter *i2c_adap, struct i2c_ms struct dib7000p_state *state = i2c_get_adapdata(i2c_adap); u8 n_overflow = 1; u16 i = 1000; + if (msg[0].len < 3) + return -EOPNOTSUPP; u16 serpar_num = msg[0].buf[0]; while (n_overflow == 1 && i) { @@ -2217,6 +2219,8 @@ static int w7090p_tuner_read_serpar(struct i2c_adapter *i2c_adap, struct i2c_msg struct dib7000p_state *state = i2c_get_adapdata(i2c_adap); u8 n_overflow = 1, n_empty = 1; u16 i = 1000; + if (msg[0].len < 1 || msg[1].len < 2) + return -EOPNOTSUPP; u16 serpar_num = msg[0].buf[0]; u16 read_word; -- 2.39.5