From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 05CCF272E7C; Tue, 2 Sep 2025 13:43:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756820628; cv=none; b=Qjhtczhbre7Bwe3HkKvsgCMsIgSIoNBm6hPNqywDl4eu2qrWSQwejKVnyKPCmtpgT9fTJZFEKuvtGhehlv/Ub4Nep4n8/p0XjDBRqRfNywZGZFUxA9n7NsdM7wvuzumyfxms9DosmeftEWh/iVQRiyxa+KdU23VY4/TqSnE5J80= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756820628; c=relaxed/simple; bh=cLUC+QeffVcpLAWGfL458KWdAcs23xR9r0AW87WfGPA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=r0HeZTzuRFabPVSwp5IqgJa2oF8PSBvthXYMFO/RGo2axjazdfZgspz6bKtoc+Sq68ZOdcipHWhhFhe16Ijix8naocIwnO+UrdQMXMmneSKro2x4hpZCmX+zDf+Q2djr+EvThYrcIXpwpcevmy/Ir8HEFwRlNsL4YFBkBrXdG5k= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=jQA9klQQ; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="jQA9klQQ" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2BA1BC4CEED; Tue, 2 Sep 2025 13:43:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1756820627; bh=cLUC+QeffVcpLAWGfL458KWdAcs23xR9r0AW87WfGPA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=jQA9klQQBEQdBhBcELV4idEbC+Rt60XOlnbZQYitbC1rij/YpIFkCKK6lnHJbAsoa J8ar6nnK09ExkizTi+sgjRJ3Qwp5RNR1pK7zSZPzqwOX7hJNojYP5L5SCoBUc9pDRr GQb708BeO/OohSzqPpeZ95q9yOZzd85PNHBqggic= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Yeounsu Moon , Andrew Lunn , Jakub Kicinski , Sasha Levin Subject: [PATCH 5.15 13/33] net: dlink: fix multicast stats being counted incorrectly Date: Tue, 2 Sep 2025 15:21:31 +0200 Message-ID: <20250902131927.570772007@linuxfoundation.org> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20250902131927.045875971@linuxfoundation.org> References: <20250902131927.045875971@linuxfoundation.org> User-Agent: quilt/0.68 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.15-stable review patch. If anyone has any objections, please let me know. ------------------ From: Yeounsu Moon [ Upstream commit 007a5ffadc4fd51739527f1503b7cf048f31c413 ] `McstFramesRcvdOk` counts the number of received multicast packets, and it reports the value correctly. However, reading `McstFramesRcvdOk` clears the register to zero. As a result, the driver was reporting only the packets since the last read, instead of the accumulated total. Fix this by updating the multicast statistics accumulatively instaed of instantaneously. Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") Tested-on: D-Link DGE-550T Rev-A3 Signed-off-by: Yeounsu Moon Reviewed-by: Andrew Lunn Link: https://patch.msgid.link/20250823182927.6063-3-yyyynoom@gmail.com Signed-off-by: Jakub Kicinski Signed-off-by: Sasha Levin --- drivers/net/ethernet/dlink/dl2k.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/dlink/dl2k.c b/drivers/net/ethernet/dlink/dl2k.c index 09a275eb44487..81395852b4d43 100644 --- a/drivers/net/ethernet/dlink/dl2k.c +++ b/drivers/net/ethernet/dlink/dl2k.c @@ -1095,7 +1095,7 @@ get_stats (struct net_device *dev) dev->stats.rx_bytes += dr32(OctetRcvOk); dev->stats.tx_bytes += dr32(OctetXmtOk); - dev->stats.multicast = dr32(McstFramesRcvdOk); + dev->stats.multicast += dr32(McstFramesRcvdOk); dev->stats.collisions += dr32(SingleColFrames) + dr32(MultiColFrames); -- 2.50.1