From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E6A363093CA; Tue, 2 Sep 2025 13:27:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756819662; cv=none; b=FVE34Ag+CIGaHvI/FtxEm3t527Q4iFUgOLFtHvAH0GGvtcrd7MSPdmE+cfFMC38rnoCABTQZIfRKXsYAErssPqTFS3BZxSYeY+boSYJ0y2Ekn7/v3NRL3Yq+dUugOMIpc4M7sgC96jcgJ0UBs4/cSP6miJ4PZVgn+yDMROG19k4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756819662; c=relaxed/simple; bh=Uv8pcyLDS5ZH135uxz7NrKJGL/bwlF38WqRHtYAIJGE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=H9AEn5F66JMnvj2oEZ3SUejU1JNwAL0EaT6po8xIrw0IlWmVVvJrK7ywOXd8VwFkMfDNGpkRlZAKv2C1V3iYc1gDRDZ9xC+x9eqn7okZSEGz7HsEBXLVEFTAhIo3Yuh9GE8GZRAUQlidcG2vAr4dDZtOMz1GjV2Lbe2yo+1xhB4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=RThKQqPy; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="RThKQqPy" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6451CC4CEED; Tue, 2 Sep 2025 13:27:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1756819661; bh=Uv8pcyLDS5ZH135uxz7NrKJGL/bwlF38WqRHtYAIJGE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=RThKQqPyjcRSOGCxY5Ph0aqwNx+PKCPDNYFZZ1r+WXNV0IueBbN+qR5KSyHUU2Kch qgsaBY0xWHWXe6fJC9VsblBLQfJ8aPJ6gls9Vb/QjO5YDOZWTRI46PkzbNrapn8LpS TjEwjoTSzTyvkAIDqm4XqURtA8EXanPFCXiY15lE= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Jacob Keller , Paul Menzel , Michal Kubiak , Jason Xing , Aleksandr Loktionov , Priya Singh , Tony Nguyen , Sasha Levin Subject: [PATCH 6.16 060/142] ice: fix incorrect counter for buffer allocation failures Date: Tue, 2 Sep 2025 15:19:22 +0200 Message-ID: <20250902131950.550795333@linuxfoundation.org> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20250902131948.154194162@linuxfoundation.org> References: <20250902131948.154194162@linuxfoundation.org> User-Agent: quilt/0.68 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.16-stable review patch. If anyone has any objections, please let me know. ------------------ From: Michal Kubiak [ Upstream commit b1a0c977c6f1130f7dd125ee3db8c2435d7e3d41 ] Currently, the driver increments `alloc_page_failed` when buffer allocation fails in `ice_clean_rx_irq()`. However, this counter is intended for page allocation failures, not buffer allocation issues. This patch corrects the counter by incrementing `alloc_buf_failed` instead, ensuring accurate statistics reporting for buffer allocation failures. Fixes: 2fba7dc5157b ("ice: Add support for XDP multi-buffer on Rx side") Reported-by: Jacob Keller Suggested-by: Paul Menzel Signed-off-by: Michal Kubiak Reviewed-by: Paul Menzel Reviewed-by: Jason Xing Reviewed-by: Aleksandr Loktionov Tested-by: Priya Singh Signed-off-by: Tony Nguyen Signed-off-by: Sasha Levin --- drivers/net/ethernet/intel/ice/ice_txrx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/intel/ice/ice_txrx.c b/drivers/net/ethernet/intel/ice/ice_txrx.c index 0e5107fe62ad5..c50cf3ad190e9 100644 --- a/drivers/net/ethernet/intel/ice/ice_txrx.c +++ b/drivers/net/ethernet/intel/ice/ice_txrx.c @@ -1295,7 +1295,7 @@ int ice_clean_rx_irq(struct ice_rx_ring *rx_ring, int budget) skb = ice_construct_skb(rx_ring, xdp); /* exit if we failed to retrieve a buffer */ if (!skb) { - rx_ring->ring_stats->rx_stats.alloc_page_failed++; + rx_ring->ring_stats->rx_stats.alloc_buf_failed++; xdp_verdict = ICE_XDP_CONSUMED; } ice_put_rx_mbuf(rx_ring, xdp, &xdp_xmit, ntc, xdp_verdict); -- 2.50.1