Re: [PATCH] drm/bridge: cdns-dsi: Select VIDEOMODE_HELPERS

[Nathan Chancellor <nathan@kernel.org>]

Gentle ping, this seems fairly obvious and it continues to break out
builds in -next.

On Thu, Aug 21, 2025 at 01:52:12PM -0700, Nathan Chancellor wrote:
> When no other driver selects CONFIG_VIDEOMODE_HELPERS but
> CONFIG_DRM_CDNS_DSI is enabled, there is a linker or modpost error:
> 
>   ERROR: modpost: "drm_display_mode_to_videomode" [drivers/gpu/drm/bridge/cadence/cdns-dsi.ko] undefined!
> 
> Select VIDEOMODE_HELPERS to ensure that this helper function is
> available to the driver.
> 
> Fixes: ce4bc5ca7c1d ("drm/bridge: cdns-dsi: Use video mode and clean up cdns_dsi_mode2cfg()")
> Signed-off-by: Nathan Chancellor <nathan@kernel.org>
> ---
>  drivers/gpu/drm/bridge/cadence/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/gpu/drm/bridge/cadence/Kconfig b/drivers/gpu/drm/bridge/cadence/Kconfig
> index cced81633ddc..f1d8a8a151d8 100644
> --- a/drivers/gpu/drm/bridge/cadence/Kconfig
> +++ b/drivers/gpu/drm/bridge/cadence/Kconfig
> @@ -6,6 +6,7 @@ config DRM_CDNS_DSI
>  	select DRM_PANEL_BRIDGE
>  	select GENERIC_PHY
>  	select GENERIC_PHY_MIPI_DPHY
> +	select VIDEOMODE_HELPERS
>  	depends on OF
>  	help
>  	  Support Cadence DPI to DSI bridge. This is an internal
> 
> ---
> base-commit: 3f13bcc886fc034113cb75cb32b8d9db1216b846
> change-id: 20250821-cdns-videohelpers-71182a6145bc
> 
> Best regards,
> --  
> Nathan Chancellor <nathan@kernel.org>
>