From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 732291CDFAC; Sun, 7 Sep 2025 20:11:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757275908; cv=none; b=fM7I9W5mdO+vHgHTJ+T1AOjCUsWJyUqz1Kap1sRACPbVYjkMRPisVwOCy+oR8WSv7pyMSTrN56tZfmcARCpUffe/KAU6KeO5fasNOQo4JafZZYl7VAJyzTQkFfn7+i5gndIDfcY3KKUyrnbZacX6WbosU8uRPddVqw96ajckn6I= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757275908; c=relaxed/simple; bh=gQ59zgsOPvIUhHYfENu9sfEv1lyUdJIDB9OwcaPlpUA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=q0XyfJ+PGjsQHajVZx7hSwHiCc4zTBMzMKP/GpzpkhYbcG0iQ+qenOqhv4+qoA9yCJq/AbP3KoA2PTnJw9nkAjdV73e1ZDt1o958+rB/TGu2n3nAo73yxf7mJTZy7rw3IG5fLDHWnMGZx+QbzzAjLFemqA0WbS66l0lzt+56PA0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=CShbQExL; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="CShbQExL" Received: by smtp.kernel.org (Postfix) with ESMTPSA id EC57AC4CEF0; Sun, 7 Sep 2025 20:11:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1757275908; bh=gQ59zgsOPvIUhHYfENu9sfEv1lyUdJIDB9OwcaPlpUA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=CShbQExLmLknBxB9I3/u4OvtU2BS0q3iEDHYqADnlxHJrU+R70tCgoqWdpZcbYG/b tkMkbL8dJWVm52JbKFY4wIdfFul3rBhJoiRAbQ31TVjh0bbqTyaXCUw4y6kCqMh+rM D7MayAGwiCivpCQlAVOqbzPd7U+MrQG3vCiU9vjk= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Dan Carpenter , Johannes Berg , Sasha Levin Subject: [PATCH 5.4 10/45] wifi: cw1200: cap SSID length in cw1200_do_join() Date: Sun, 7 Sep 2025 21:57:56 +0200 Message-ID: <20250907195601.261496164@linuxfoundation.org> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20250907195600.953058118@linuxfoundation.org> References: <20250907195600.953058118@linuxfoundation.org> User-Agent: quilt/0.68 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.4-stable review patch. If anyone has any objections, please let me know. ------------------ From: Dan Carpenter [ Upstream commit f8f15f6742b8874e59c9c715d0af3474608310ad ] If the ssidie[1] length is more that 32 it leads to memory corruption. Fixes: a910e4a94f69 ("cw1200: add driver for the ST-E CW1100 & CW1200 WLAN chipsets") Signed-off-by: Dan Carpenter Link: https://patch.msgid.link/e91fb43fcedc4893b604dfb973131661510901a7.1756456951.git.dan.carpenter@linaro.org Signed-off-by: Johannes Berg Signed-off-by: Sasha Levin --- drivers/net/wireless/st/cw1200/sta.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/st/cw1200/sta.c b/drivers/net/wireless/st/cw1200/sta.c index 236022d4ae2a3..0f2d1ec34cd82 100644 --- a/drivers/net/wireless/st/cw1200/sta.c +++ b/drivers/net/wireless/st/cw1200/sta.c @@ -1289,7 +1289,7 @@ static void cw1200_do_join(struct cw1200_common *priv) rcu_read_lock(); ssidie = ieee80211_bss_get_ie(bss, WLAN_EID_SSID); if (ssidie) { - join.ssid_len = ssidie[1]; + join.ssid_len = min(ssidie[1], IEEE80211_MAX_SSID_LEN); memcpy(join.ssid, &ssidie[2], join.ssid_len); } rcu_read_unlock(); -- 2.50.1