From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8C6FF1CDFAC; Sun, 7 Sep 2025 20:11:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757275914; cv=none; b=AC9NK1qtOxvmBxrJT2RqCY9Z57BUuPWhOqwCuDQYU8DSBq4NRUTpKRXI6X6/wPkmCtLs/eEx3Ns/daAzPWlG/+xunmC+PQwdbbQaMN2Jgh0i0zOoeHmFYUmYE/wsxytHDxxJOaqSxsmOjetEI/Sxxhwj5vQTwHKUqaN6K8p/CJY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757275914; c=relaxed/simple; bh=zep+U4WYNdpY5rptfmuNZx5IiCUkozp3RZC4W5yh8Ng=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=m2IDu21BGZ0g+rctLqVwUCVJHxcvM5wA+1k5JlAV+A5rpHf/pKWhwOQvTx0cRklvmw10pmQQTj8o1fTwSPcEfBi/KnjZ00xqgapFB7vmJASHbVZxsgTXMaomOhSft3JoXQe8C5aVZ3HeYCmc4TCR4cYUsPYJT8n687HwyO9u0IM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=GwUhKHD3; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="GwUhKHD3" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0E0DEC4CEF0; Sun, 7 Sep 2025 20:11:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1757275914; bh=zep+U4WYNdpY5rptfmuNZx5IiCUkozp3RZC4W5yh8Ng=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=GwUhKHD3MmVq/WSkckwv1LSYoeTuPr6+b2caoHIPg9TfTMJzhqSD5Izty+bp6N6cp JTfHPXUjEn2xPcP+acrYWYHeEjjXlkoJSF2+QaA1qtmyNuPN7/boLTH40Fs6UsP+yb ywxSrFnTPDPTKZj0nkg1GoPeEwYt9kgFpUusm5tU= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Rosen Penev , Simon Horman , Jakub Kicinski , Sasha Levin Subject: [PATCH 5.4 12/45] net: thunder_bgx: add a missing of_node_put Date: Sun, 7 Sep 2025 21:57:58 +0200 Message-ID: <20250907195601.319026798@linuxfoundation.org> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20250907195600.953058118@linuxfoundation.org> References: <20250907195600.953058118@linuxfoundation.org> User-Agent: quilt/0.68 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.4-stable review patch. If anyone has any objections, please let me know. ------------------ From: Rosen Penev [ Upstream commit 9d28f94912589f04ab51fbccaef287d4f40e0d1f ] phy_np needs to get freed, just like the other child nodes. Fixes: 5fc7cf179449 ("net: thunderx: Cleanup PHY probing code.") Signed-off-by: Rosen Penev Reviewed-by: Simon Horman Link: https://patch.msgid.link/20250901213018.47392-1-rosenp@gmail.com Signed-off-by: Jakub Kicinski Signed-off-by: Sasha Levin --- .../net/ethernet/cavium/thunder/thunder_bgx.c | 18 +++++++++++------- 1 file changed, 11 insertions(+), 7 deletions(-) diff --git a/drivers/net/ethernet/cavium/thunder/thunder_bgx.c b/drivers/net/ethernet/cavium/thunder/thunder_bgx.c index 8854025610e64..e3acbdbc80993 100644 --- a/drivers/net/ethernet/cavium/thunder/thunder_bgx.c +++ b/drivers/net/ethernet/cavium/thunder/thunder_bgx.c @@ -1497,13 +1497,17 @@ static int bgx_init_of_phy(struct bgx *bgx) * this cortina phy, for which there is no driver * support, ignore it. */ - if (phy_np && - !of_device_is_compatible(phy_np, "cortina,cs4223-slice")) { - /* Wait until the phy drivers are available */ - pd = of_phy_find_device(phy_np); - if (!pd) - goto defer; - bgx->lmac[lmac].phydev = pd; + if (phy_np) { + if (!of_device_is_compatible(phy_np, "cortina,cs4223-slice")) { + /* Wait until the phy drivers are available */ + pd = of_phy_find_device(phy_np); + if (!pd) { + of_node_put(phy_np); + goto defer; + } + bgx->lmac[lmac].phydev = pd; + } + of_node_put(phy_np); } lmac++; -- 2.50.1