From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4699A1F9F70; Sun, 7 Sep 2025 20:10:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757275813; cv=none; b=P4t9r5Zxmzmuj3iDdCSz4W96yPLFtJsCIFeTUmdhu+nDeGuVuPl5mbsQ/PzWpewlrnxfgDZMLFfcRucLHlhGtYgl//XR7FZQZp2Ey3JspCAb6xmlEdHyFMsP+x2yWDvzmA4vtLbk8d4V7/rxaSlTcxI2Gw8pRBQEV+dS3lUsXVI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757275813; c=relaxed/simple; bh=UD4IjMxj4n59NX+vE2qEW3GNYBgW6TP4txcV6DL9P14=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=FuD4h6cSEkh/40jAvK47Nz8fDTz8M6QJqRPme/tJKuuRkT2tcWvOR56TLNjDPceb66N205CqBxu1Hb1zAFlmMhiyXI2KSpIGgPp7K9yPS9ptDsvVKlEr9TPpTpYN6X61LDVnRY50rcOWcK8M538KrX4lqitvh8pCjp3F8oEXdxw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=JMEVXsyi; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="JMEVXsyi" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 77CEEC4CEF0; Sun, 7 Sep 2025 20:10:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1757275812; bh=UD4IjMxj4n59NX+vE2qEW3GNYBgW6TP4txcV6DL9P14=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=JMEVXsyiCeav81a0wRdk5+w8+QfpMngH/RSidsJMge5rg4q1uhLf7iTp4yseKjRnd ER1iHPBz1dQ6VP8xCVMprOsUQWd9BPOHdiS6Hk+ctgH4K0htG8J2CU20DZ/d+zHc5q iteGer3LgiuqMXQOh+yvDZwOIa6oZJudOFdJetOo= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Ma Ke , Dominik Brodowski Subject: [PATCH 5.4 19/45] pcmcia: Fix a NULL pointer dereference in __iodyn_find_io_region() Date: Sun, 7 Sep 2025 21:58:05 +0200 Message-ID: <20250907195601.517785609@linuxfoundation.org> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20250907195600.953058118@linuxfoundation.org> References: <20250907195600.953058118@linuxfoundation.org> User-Agent: quilt/0.68 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.4-stable review patch. If anyone has any objections, please let me know. ------------------ From: Ma Ke commit 44822df89e8f3386871d9cad563ece8e2fd8f0e7 upstream. In __iodyn_find_io_region(), pcmcia_make_resource() is assigned to res and used in pci_bus_alloc_resource(). There is a dereference of res in pci_bus_alloc_resource(), which could lead to a NULL pointer dereference on failure of pcmcia_make_resource(). Fix this bug by adding a check of res. Cc: stable@vger.kernel.org Fixes: 49b1153adfe1 ("pcmcia: move all pcmcia_resource_ops providers into one module") Signed-off-by: Ma Ke Signed-off-by: Dominik Brodowski Signed-off-by: Greg Kroah-Hartman --- drivers/pcmcia/rsrc_iodyn.c | 3 +++ 1 file changed, 3 insertions(+) --- a/drivers/pcmcia/rsrc_iodyn.c +++ b/drivers/pcmcia/rsrc_iodyn.c @@ -62,6 +62,9 @@ static struct resource *__iodyn_find_io_ unsigned long min = base; int ret; + if (!res) + return NULL; + data.mask = align - 1; data.offset = base & data.mask;