From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7886E22F74D; Sun, 7 Sep 2025 20:09:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757275768; cv=none; b=gRnBR8eo472yUO/s5WwLS0V3wZFU+iLkE2PZ2aRjxbYNqyUNSk4gVCPrGW1D4wAFZSwCMI21cLWoK1gnS/6MP91Uz3suArFaTwmnC2yXBo1bcmeBFSLThHc+3ctjwPswQMDVOEeiS/ylU2DaRGgpGIw74xtU8BKYZf+XGZZfiC0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757275768; c=relaxed/simple; bh=2vVZBKvmnsGTppBXb0xczq1u5VjxgtUEBluXTKNydRY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=REdwEgEUpAm2xOZH5ayiOCnbxUsHt/SRJ1F6t3wG7cOypHoNaG131qbHD/7zuXinWG5VoH+6OfaPwPIsZZUO6HQ1q9v8rugCcv+CNLljwP937xBNF7Wyhrct4ecbZ66HNoggJ3+MlkkHbaWDf+8GgmkaadO8Rs5I3qVBEUzr2TE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=jM8NrxTb; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="jM8NrxTb" Received: by smtp.kernel.org (Postfix) with ESMTPSA id A3348C4CEF0; Sun, 7 Sep 2025 20:09:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1757275767; bh=2vVZBKvmnsGTppBXb0xczq1u5VjxgtUEBluXTKNydRY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=jM8NrxTbJKjUGXtONUw0neMokm1T9lh9zWlbSkXduPczoSlxBHKWXqvdu5Sb8YkdZ bBF0XsceBb+lnWlJLd1zipLENwiGyuh2BOXvGmEwYt9BL9TndfYojeLiO9xXgVNLCy rK8OgzlKdSI1YQwffKr3LkXVqEnahfbRzNLgGEEc= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Wentao Liang , Dominik Brodowski , Sasha Levin Subject: [PATCH 5.10 46/52] pcmcia: Add error handling for add_interval() in do_validate_mem() Date: Sun, 7 Sep 2025 21:58:06 +0200 Message-ID: <20250907195603.300141745@linuxfoundation.org> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20250907195601.957051083@linuxfoundation.org> References: <20250907195601.957051083@linuxfoundation.org> User-Agent: quilt/0.68 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Wentao Liang [ Upstream commit 4a81f78caa53e0633cf311ca1526377d9bff7479 ] In the do_validate_mem(), the call to add_interval() does not handle errors. If kmalloc() fails in add_interval(), it could result in a null pointer being inserted into the linked list, leading to illegal memory access when sub_interval() is called next. This patch adds an error handling for the add_interval(). If add_interval() returns an error, the function will return early with the error code. Fixes: 7b4884ca8853 ("pcmcia: validate late-added resources") Signed-off-by: Wentao Liang Signed-off-by: Dominik Brodowski Signed-off-by: Sasha Levin --- drivers/pcmcia/rsrc_nonstatic.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/pcmcia/rsrc_nonstatic.c b/drivers/pcmcia/rsrc_nonstatic.c index 6e90927e65769..ab487edec2e5b 100644 --- a/drivers/pcmcia/rsrc_nonstatic.c +++ b/drivers/pcmcia/rsrc_nonstatic.c @@ -375,7 +375,9 @@ static int do_validate_mem(struct pcmcia_socket *s, if (validate && !s->fake_cis) { /* move it to the validated data set */ - add_interval(&s_data->mem_db_valid, base, size); + ret = add_interval(&s_data->mem_db_valid, base, size); + if (ret) + return ret; sub_interval(&s_data->mem_db, base, size); } -- 2.51.0