From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0E51D17BB21; Sun, 7 Sep 2025 20:28:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757276906; cv=none; b=h0ujWDN3KNM6gTa5SPt5FV95KC/nWwd0qOo4gtVEigroBtoM/op4PbL21125MNE/e3uohCHWpsoe/EDYGso5mpu5xJy+TkR9mgOdlUevCN+TQoXAf2gMrr4482OhZuSLBTyEqwGp310A+0rccyCQ2NpIqGkvuffeoRWHyy2xpz4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757276906; c=relaxed/simple; bh=c4CiaJzS1/vLa8GODuE0U/kJEv7pxMkydB7pxKmH0cg=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=TY6Zp2ZqydZXERTmjRPgBjvamb9uvXCyx6t1Q7kzfRYSgsKcv1lrdCBNDrILB+zth2Q0VjS0LuCuDNEH3FgzMc0mCRcmLyBwUgXfW4PxUOAnXuI2+tu7yl9wzmwy5CqBLIjVKCCVwkGTEuEENScS2KpjDnc2BlxUWA+8jvAj2/0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=iQf5Ou6Q; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="iQf5Ou6Q" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2ED3DC4CEF0; Sun, 7 Sep 2025 20:28:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1757276905; bh=c4CiaJzS1/vLa8GODuE0U/kJEv7pxMkydB7pxKmH0cg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=iQf5Ou6QdoahBjqaOde2ocLx8sBaMR8A05DaKJF59QJNqy8NsuWWdweY6EYvptvya sttVMymW0+qBlPVcCo3ELhSG/z75wYqw6gQeqvIbxDsF+TEJdpsBlHBLUrbOVg+ofp O7lii3sDGiHSFCgdaNqfFCmuHWcp2oBF2Sr/doiI= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Alan Stern , syzbot+b63d677d63bcac06cf90@syzkaller.appspotmail.com, Benjamin Tissoires , Sasha Levin Subject: [PATCH 6.12 025/175] HID: core: Harden s32ton() against conversion to 0 bits Date: Sun, 7 Sep 2025 21:57:00 +0200 Message-ID: <20250907195615.470242216@linuxfoundation.org> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20250907195614.892725141@linuxfoundation.org> References: <20250907195614.892725141@linuxfoundation.org> User-Agent: quilt/0.68 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.12-stable review patch. If anyone has any objections, please let me know. ------------------ From: Alan Stern [ Upstream commit a6b87bfc2ab5bccb7ad953693c85d9062aef3fdd ] Testing by the syzbot fuzzer showed that the HID core gets a shift-out-of-bounds exception when it tries to convert a 32-bit quantity to a 0-bit quantity. Ideally this should never occur, but there are buggy devices and some might have a report field with size set to zero; we shouldn't reject the report or the device just because of that. Instead, harden the s32ton() routine so that it returns a reasonable result instead of crashing when it is called with the number of bits set to 0 -- the same as what snto32() does. Signed-off-by: Alan Stern Reported-by: syzbot+b63d677d63bcac06cf90@syzkaller.appspotmail.com Closes: https://lore.kernel.org/linux-usb/68753a08.050a0220.33d347.0008.GAE@google.com/ Tested-by: syzbot+b63d677d63bcac06cf90@syzkaller.appspotmail.com Fixes: dde5845a529f ("[PATCH] Generic HID layer - code split") Cc: stable@vger.kernel.org Link: https://patch.msgid.link/613a66cd-4309-4bce-a4f7-2905f9bce0c9@rowland.harvard.edu Signed-off-by: Benjamin Tissoires Signed-off-by: Sasha Levin --- drivers/hid/hid-core.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/hid/hid-core.c b/drivers/hid/hid-core.c index 5169d8d56c889..9910c6d3fef30 100644 --- a/drivers/hid/hid-core.c +++ b/drivers/hid/hid-core.c @@ -66,8 +66,12 @@ static s32 snto32(__u32 value, unsigned int n) static u32 s32ton(__s32 value, unsigned int n) { - s32 a = value >> (n - 1); + s32 a; + if (!value || !n) + return 0; + + a = value >> (n - 1); if (a && a != -1) return value < 0 ? 1 << (n - 1) : (1 << (n - 1)) - 1; return value & ((1 << n) - 1); -- 2.50.1