From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 551D74315A; Sun, 7 Sep 2025 20:39:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757277568; cv=none; b=sKLDbIyGi+qrJc47OWaOKajzg1FxCqjlk6Jgz9kE7UtR06nE8/FGc8Gc6Su5EOgSMPx4GDcnDRwtLdntE85xZFfECIOHzMMdgvcyw9JSsT2bBBOwKqaklB2+HbwP7y7dPsdzSKDT79O+/CoMJhDentZRV6GxOaSWFshnSnMuhVw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757277568; c=relaxed/simple; bh=8ATidPw5XOd4/KnU9dZrFNgRhE8rtO3FCUcFVU9/4qg=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=ToHbqFtD+wAQZGTEWqEuYgzHRKyIF33pEiOZUqGavxUoYVUlhEi59HV5sOS9S8FtqKrzd/hA9Oq0+gF3X7VTTSwCpKIqzqyh3ppaz3qKLXQByoHEzFANbQGIkDtmTJn5msFtMV6h7ynXXSkqTYoYnPS+9JPt+UP0bNkRbYqG7JA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=jdEbe5U0; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="jdEbe5U0" Received: by smtp.kernel.org (Postfix) with ESMTPSA id A2559C4CEF0; Sun, 7 Sep 2025 20:39:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1757277568; bh=8ATidPw5XOd4/KnU9dZrFNgRhE8rtO3FCUcFVU9/4qg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=jdEbe5U0i/wgT3RYtjKDyiGWgIqshppysATlt/eqG8epQLsCiBNXwCCQcvHmKyzPk wWuTecwBJk5XUhKjBFzW/WnjFTzNYpGiG0zhgJIcjG+TSAzgOH85DK08NAEk+P3J9w H+FaFyfZF+UQUEQoaHXSHxQzSe9RCBGWHHYtb8JQ= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Miaoqian Lin , Simon Horman , Jakub Kicinski , Sasha Levin Subject: [PATCH 6.16 054/183] mISDN: Fix memory leak in dsp_hwec_enable() Date: Sun, 7 Sep 2025 21:58:01 +0200 Message-ID: <20250907195617.066366706@linuxfoundation.org> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20250907195615.802693401@linuxfoundation.org> References: <20250907195615.802693401@linuxfoundation.org> User-Agent: quilt/0.68 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.16-stable review patch. If anyone has any objections, please let me know. ------------------ From: Miaoqian Lin [ Upstream commit 0704a3da7ce50f972e898bbda88d2692a22922d9 ] dsp_hwec_enable() allocates dup pointer by kstrdup(arg), but then it updates dup variable by strsep(&dup, ","). As a result when it calls kfree(dup), the dup variable may be a modified pointer that no longer points to the original allocated memory, causing a memory leak. The issue is the same pattern as fixed in commit c6a502c22999 ("mISDN: Fix memory leak in dsp_pipeline_build()"). Fixes: 9a4381618262 ("mISDN: Remove VLAs") Signed-off-by: Miaoqian Lin Reviewed-by: Simon Horman Link: https://patch.msgid.link/20250828081457.36061-1-linmq006@gmail.com Signed-off-by: Jakub Kicinski Signed-off-by: Sasha Levin --- drivers/isdn/mISDN/dsp_hwec.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/isdn/mISDN/dsp_hwec.c b/drivers/isdn/mISDN/dsp_hwec.c index 0b3f29195330a..0cd216e28f009 100644 --- a/drivers/isdn/mISDN/dsp_hwec.c +++ b/drivers/isdn/mISDN/dsp_hwec.c @@ -51,14 +51,14 @@ void dsp_hwec_enable(struct dsp *dsp, const char *arg) goto _do; { - char *dup, *tok, *name, *val; + char *dup, *next, *tok, *name, *val; int tmp; - dup = kstrdup(arg, GFP_ATOMIC); + dup = next = kstrdup(arg, GFP_ATOMIC); if (!dup) return; - while ((tok = strsep(&dup, ","))) { + while ((tok = strsep(&next, ","))) { if (!strlen(tok)) continue; name = strsep(&tok, "="); -- 2.50.1