From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3D73C4315A; Sun, 7 Sep 2025 20:43:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757277839; cv=none; b=AAcwsoCN8gZyL36dqiwb1yg07/zqiKJpPPjY8gcLS3QbFtIV90YPOhTpOybhKVT9m4zXc9Ahlchi4LNXtMBMFWnuMx0VpsGt7bPY+HCO10tNHTm+1NUaZ6aZ5tr6kF1LaGgFN973OVcPik8w50y84CPEajl9adVMerkdUMNX4Vc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757277839; c=relaxed/simple; bh=8xwGyeKR/5TkW3VGXfYocmdnWIS+WRYQoXihsgQnKfw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=nKtDeqBLAua5DZEr9mHtVGbgutmfEsb9GU2u6YJkb58kyclRD/Twpprs1UGaugx6y2elyY0HPLja1PUYGQ1mzXfhuK2oIwDZKSbl6gEm8j2es3nVfRNyLn2jeiQbEtrNIxQAstYtI6RpPXe/7Tsps9eoS+9C6P6K0DlpJPe8wRg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=VwdlgTiO; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="VwdlgTiO" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6C849C4CEF0; Sun, 7 Sep 2025 20:43:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1757277838; bh=8xwGyeKR/5TkW3VGXfYocmdnWIS+WRYQoXihsgQnKfw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=VwdlgTiOud4fr0W6Bbez4geF/KNdPfrw7c+cta+UrZn0y/C15sutfjeYBMxeTAxNK xHvvxEpY2UuWqzcwso7AH/HF37KymcG8iti25ONHBrQVPOKSgvmmYT8VtEgF+xTVc3 46uF5w1xrgIuT0mxnstU9Tjsxe/RjZg3HL0KjB6I= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, stable@kernel.org, Lad Prabhakar , Wolfram Sang , "Russell King (Oracle)" , Geert Uytterhoeven , Jakub Kicinski Subject: [PATCH 6.16 139/183] net: pcs: rzn1-miic: Correct MODCTRL register offset Date: Sun, 7 Sep 2025 21:59:26 +0200 Message-ID: <20250907195619.096343749@linuxfoundation.org> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20250907195615.802693401@linuxfoundation.org> References: <20250907195615.802693401@linuxfoundation.org> User-Agent: quilt/0.68 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.16-stable review patch. If anyone has any objections, please let me know. ------------------ From: Lad Prabhakar commit a7195a3d67dace056af7ca65144a11874df79562 upstream. Correct the Mode Control Register (MODCTRL) offset for RZ/N MIIC. According to the R-IN Engine and Ethernet Peripherals Manual (Rev.1.30) [0], Table 10.1 "Ethernet Accessory Register List", MODCTRL is at offset 0x8, not 0x20 as previously defined. Offset 0x20 actually maps to the Port Trigger Control Register (PTCTRL), which controls PTP_MODE[3:0] and RGMII_CLKSEL[4]. Using this incorrect definition prevented the driver from configuring the SW_MODE[4:0] bits in MODCTRL, which control the internal connection of Ethernet ports. As a result, the MIIC could not be switched into the correct mode, leading to link setup failures and non-functional Ethernet ports on affected systems. [0] https://www.renesas.com/en/document/mah/rzn1d-group-rzn1s-group-rzn1l-group-users-manual-r-engine-and-ethernet-peripherals?r=1054571 Fixes: 7dc54d3b8d91 ("net: pcs: add Renesas MII converter driver") Cc: stable@kernel.org Signed-off-by: Lad Prabhakar Reviewed-by: Wolfram Sang Reviewed-by: Russell King (Oracle) Reviewed-by: Geert Uytterhoeven Tested-by: Wolfram Sang Link: https://patch.msgid.link/20250901112019.16278-1-prabhakar.mahadev-lad.rj@bp.renesas.com Signed-off-by: Jakub Kicinski Signed-off-by: Greg Kroah-Hartman --- drivers/net/pcs/pcs-rzn1-miic.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/net/pcs/pcs-rzn1-miic.c +++ b/drivers/net/pcs/pcs-rzn1-miic.c @@ -19,7 +19,7 @@ #define MIIC_PRCMD 0x0 #define MIIC_ESID_CODE 0x4 -#define MIIC_MODCTRL 0x20 +#define MIIC_MODCTRL 0x8 #define MIIC_MODCTRL_SW_MODE GENMASK(4, 0) #define MIIC_CONVCTRL(port) (0x100 + (port) * 4)