From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CDB7936298D for ; Fri, 12 Sep 2025 22:11:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.17 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757715085; cv=none; b=DTY9McjR47mn0zFcG/vvEbNxO5WNc1bGTxIuieoe2g8IiHDji9uECssZPnomPKDYJvlb8YmERJcgcUlcpeqxGvtvi73XV07q6985S7h3gDhqnao2ksGYzbmWbOUlUpCxxgoMQZvmiF4kCTFh8gsbKfRXJ7hjOpRpY/ki0hJxHCg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757715085; c=relaxed/simple; bh=fHUt0o6D3U/SI6ClZl36jl6SZt9KgpqXKy35ebS+MQM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=ddMzhgi3tQ63KzH3yIIxFpEmjdZ3Wr7lF5aPYJTAN2LHHUnwq5dwvgFABln4kGgOtZPT8hmgekd/mfCEVlBHnLnUFzGgz6bNnZarRf3HENOcyv7tm7UCcODs0ueKaGKwixwdRvd1UZ2xnTB31PAQg29uqKAiV594r3JvpnLBLwk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=DmABjH+m; arc=none smtp.client-ip=192.198.163.17 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="DmABjH+m" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1757715083; x=1789251083; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=fHUt0o6D3U/SI6ClZl36jl6SZt9KgpqXKy35ebS+MQM=; b=DmABjH+m9pNU0Y6fTkSkyoSMAb2xBs3SXCot1ldcW4XJl1FMIydFQBxQ NzdsHaykxnBCtw6JmhBxwydf0ZqgIR6qe6aM323c3eUSTqXJmyNuu692v 9BMFVk5MUSgRBNfpIL+9lAaN1dy3+NGbNXCVA/tEOJ6Xxhbw54uUE5KUi mYvytIB/jGSyVqAJqC3J662whPDlgDhAwTvXoECahF5OSSX6mQk5xei54 0q7zni63/8bdySsCpwniNKBP58bi1xuU/1aF15nEfs3+gLisYHh5oApa8 uNmFS1vha5+K8e/8TiAIp1px8fH9FTQk4SiIqgJyo79NQwWbVwdCJLTKx w==; X-CSE-ConnectionGUID: 24IO3UryT7ip6n1W+wBWug== X-CSE-MsgGUID: fsrwWjM4R7ezMrFajylCFA== X-IronPort-AV: E=McAfee;i="6800,10657,11551"; a="60002851" X-IronPort-AV: E=Sophos;i="6.18,260,1751266800"; d="scan'208";a="60002851" Received: from orviesa005.jf.intel.com ([10.64.159.145]) by fmvoesa111.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Sep 2025 15:11:14 -0700 X-CSE-ConnectionGUID: rdOAKNXVQ+O629FQyMDdPQ== X-CSE-MsgGUID: K3xvnpuvSKGbT3LZ0Lpkog== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.18,260,1751266800"; d="scan'208";a="179265235" Received: from smoehrl-linux.amr.corp.intel.com (HELO agluck-desk3.intel.com) ([10.124.221.49]) by orviesa005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Sep 2025 15:11:13 -0700 From: Tony Luck To: Fenghua Yu , Reinette Chatre , Maciej Wieczor-Retman , Peter Newman , James Morse , Babu Moger , Drew Fustini , Dave Martin , Chen Yu Cc: x86@kernel.org, linux-kernel@vger.kernel.org, patches@lists.linux.dev, Tony Luck Subject: [PATCH v10 26/28] fs/resctrl: Provide interface to create architecture specific debugfs area Date: Fri, 12 Sep 2025 15:10:47 -0700 Message-ID: <20250912221053.11349-27-tony.luck@intel.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20250912221053.11349-1-tony.luck@intel.com> References: <20250912221053.11349-1-tony.luck@intel.com> Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit All files below /sys/fs/resctrl are considered user ABI. This leaves no place for architectures to provide additional interfaces. Add resctrl_debugfs_mon_info_arch_mkdir() which creates a directory in the debugfs file system for a monitoring resource. Naming follows the layout of the main resctrl hierarchy: /sys/kernel/debug/resctrl/info/{resource}_MON/{arch} The {arch} last level directory name matches the output of the user level "uname -m" command. Architecture code may use this directory for debug information, or for minor tuning of features. It must not be used for basic feature enabling as debugfs may not be configured/mounted on production systems. Suggested-by: Reinette Chatre Signed-off-by: Tony Luck --- include/linux/resctrl.h | 10 ++++++++++ fs/resctrl/rdtgroup.c | 29 +++++++++++++++++++++++++++++ 2 files changed, 39 insertions(+) diff --git a/include/linux/resctrl.h b/include/linux/resctrl.h index c7b5e56d25bb..d4be0f54c7e8 100644 --- a/include/linux/resctrl.h +++ b/include/linux/resctrl.h @@ -678,6 +678,16 @@ void resctrl_arch_reset_cntr(struct rdt_resource *r, struct rdt_l3_mon_domain *d extern unsigned int resctrl_rmid_realloc_threshold; extern unsigned int resctrl_rmid_realloc_limit; +/** + * resctrl_debugfs_mon_info_arch_mkdir() - Create a debugfs info directory. + * Removed by resctrl_exit(). + * @r: Resource (must be mon_capable). + * + * Return: NULL if resource is not monitoring capable, + * dentry pointer on success, or ERR_PTR(-ERROR) on failure. + */ +struct dentry *resctrl_debugfs_mon_info_arch_mkdir(struct rdt_resource *r); + int resctrl_init(void); void resctrl_exit(void); diff --git a/fs/resctrl/rdtgroup.c b/fs/resctrl/rdtgroup.c index 94fa7fb7d598..134cd5acff66 100644 --- a/fs/resctrl/rdtgroup.c +++ b/fs/resctrl/rdtgroup.c @@ -24,6 +24,7 @@ #include #include #include +#include #include @@ -75,6 +76,8 @@ static void rdtgroup_destroy_root(void); struct dentry *debugfs_resctrl; +static struct dentry *debugfs_resctrl_info; + /* * Memory bandwidth monitoring event to use for the default CTRL_MON group * and each new CTRL_MON group created by the user. Only relevant when @@ -4515,6 +4518,31 @@ int resctrl_init(void) return ret; } +/* + * Create /sys/kernel/debug/resctrl/info/{r->name}_MON/{arch} directory + * by request for architecture to use for debugging or minor tuning. + * Basic functionality of features must not be controlled by files + * added to this directory as debugfs may not be configured/mounted + * on production systems. + */ +struct dentry *resctrl_debugfs_mon_info_arch_mkdir(struct rdt_resource *r) +{ + struct dentry *moninfodir; + char name[32]; + + if (!r->mon_capable) + return NULL; + + if (!debugfs_resctrl_info) + debugfs_resctrl_info = debugfs_create_dir("info", debugfs_resctrl); + + sprintf(name, "%s_MON", r->name); + + moninfodir = debugfs_create_dir(name, debugfs_resctrl_info); + + return debugfs_create_dir(utsname()->machine, moninfodir); +} + static bool resctrl_online_domains_exist(void) { struct rdt_resource *r; @@ -4566,6 +4594,7 @@ void resctrl_exit(void) debugfs_remove_recursive(debugfs_resctrl); debugfs_resctrl = NULL; + debugfs_resctrl_info = NULL; unregister_filesystem(&rdt_fs_type); /* -- 2.51.0