From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B3143303A05; Wed, 17 Sep 2025 13:01:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758114077; cv=none; b=nK2qWdK/5qYRX6X3WgyDNvZHI2dDwiajiBmHsK4bk9GRGzJxLPErdX2vltAi5dN+GDlaWTNJrDfHn8gh/0do1FrmkcS+n2WQoXMQmE7NfKX5jE6PZH9ejtTnEE+ighZBtKZFaoqsjsUZv7xR/YERKj/YJib7WoC4j0TUVQzyZ6I= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758114077; c=relaxed/simple; bh=LXqchSRQlYqzBF5ZeMwoOLOLe6hargq48JTVrMQHWpQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=VcQDI1qz24WqXIMcMQNPNLdx94vWSoXKOizn5yy9goEubEYE02zmKsltjiiacQ17HQny+fKZU0D3Jao7nxtVg8mWh9g/qbff5tXCLBymL4g68pKTZo6UpwYrbxbr1IA2WimeBjdPKCRxKuU/TKY9FfdBEV8caFwwHkkF2r/cM7E= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=o1Dzjyxp; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="o1Dzjyxp" Received: by smtp.kernel.org (Postfix) with ESMTPSA id ED3D7C4CEF0; Wed, 17 Sep 2025 13:01:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1758114077; bh=LXqchSRQlYqzBF5ZeMwoOLOLe6hargq48JTVrMQHWpQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=o1DzjyxpC7IWENd9VMELsYpG3C4CJtVOmRll6S8ciOCVPK+zuIAv9vzhUZ+Onnsf3 +8FuwllLit890YPq3ZdNO2xgeQC+ib4k1TwN3/wA71viWrpwTM+6trAGQSRjfdeLUM +/pfzFTF0S2ahgUMdBgx9dab+P8rztT+QpA4pWAg= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Wei Yang , Dev Jain , Zi Yan , David Hildenbrand , Lorenzo Stoakes , Baolin Wang , "Liam R. Howlett" , Nico Pache , Ryan Roberts , Barry Song , Andrew Morton , Sasha Levin Subject: [PATCH 6.1 40/78] mm/khugepaged: fix the address passed to notifier on testing young Date: Wed, 17 Sep 2025 14:35:01 +0200 Message-ID: <20250917123330.539290871@linuxfoundation.org> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20250917123329.576087662@linuxfoundation.org> References: <20250917123329.576087662@linuxfoundation.org> User-Agent: quilt/0.68 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.1-stable review patch. If anyone has any objections, please let me know. ------------------ From: Wei Yang [ Upstream commit 394bfac1c7f7b701c2c93834c5761b9c9ceeebcf ] Commit 8ee53820edfd ("thp: mmu_notifier_test_young") introduced mmu_notifier_test_young(), but we are passing the wrong address. In xxx_scan_pmd(), the actual iteration address is "_address" not "address". We seem to misuse the variable on the very beginning. Change it to the right one. [akpm@linux-foundation.org fix whitespace, per everyone] Link: https://lkml.kernel.org/r/20250822063318.11644-1-richard.weiyang@gmail.com Fixes: 8ee53820edfd ("thp: mmu_notifier_test_young") Signed-off-by: Wei Yang Reviewed-by: Dev Jain Reviewed-by: Zi Yan Acked-by: David Hildenbrand Reviewed-by: Lorenzo Stoakes Cc: Baolin Wang Cc: Liam R. Howlett Cc: Nico Pache Cc: Ryan Roberts Cc: Barry Song Cc: Signed-off-by: Andrew Morton Signed-off-by: Sasha Levin Signed-off-by: Greg Kroah-Hartman --- mm/khugepaged.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) --- a/mm/khugepaged.c +++ b/mm/khugepaged.c @@ -1276,8 +1276,8 @@ static int hpage_collapse_scan_pmd(struc */ if (cc->is_khugepaged && (pte_young(pteval) || folio_test_young(folio) || - folio_test_referenced(folio) || mmu_notifier_test_young(vma->vm_mm, - address))) + folio_test_referenced(folio) || + mmu_notifier_test_young(vma->vm_mm, _address))) referenced++; } if (!writable) {