From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EE56A189B84; Wed, 17 Sep 2025 12:39:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758112789; cv=none; b=IniViuEzXnPtqQLsmu58F6Q3xm0WHPr47FsZoAI+MlMZcgh0EImHuSR5kDnbaOvVqPUzQmro6xP5NpF0CcOaiqriwYk0b0ak449MiY8CzXk7MRPFhAzOmj5N1rcXqvynawpuMfinwzfrAxph4HGLzsE01I0yazvuNDYEGwMqxiA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758112789; c=relaxed/simple; bh=U69dU552F3ieZ1706+BVyApAz76sxBpD6S4nyuHvd9Q=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=HWthOGh2K4hWDPb50U7sOX7jiVHm7R8hKVmfItIninZtnqupDIXCyEuTidMZ/IjxSowjBt9eF16ZQbPcAhH+rgv3iNUQe8iSKSo4kb438eCXI2rY5dLMhZDIyAo48EJk1qlqMoXC1XoUgrZfQPXq0779jDCCNMjGbF3eUtsBSms= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=ot/HZU3L; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="ot/HZU3L" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 33AFBC4CEF0; Wed, 17 Sep 2025 12:39:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1758112788; bh=U69dU552F3ieZ1706+BVyApAz76sxBpD6S4nyuHvd9Q=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ot/HZU3LNfaX59bHJob6Oz/7Sh35t9PROQdMLWfT6TW/9c4UfF4XKuZ6EDAmtrArm ZdRI58pBVyJQUijsu5OZes+Wq90mCG5FpaScSDziCgBK4hvQaYzHdiCvTnwKfDJvsr 629o6wVueaWbjPD3VNB82IQZp40NJs55GGhY1WHw= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Wei Yang , Dev Jain , Zi Yan , David Hildenbrand , Lorenzo Stoakes , Baolin Wang , "Liam R. Howlett" , Nico Pache , Ryan Roberts , Barry Song , Andrew Morton Subject: [PATCH 6.16 077/189] mm/khugepaged: fix the address passed to notifier on testing young Date: Wed, 17 Sep 2025 14:33:07 +0200 Message-ID: <20250917123353.750157389@linuxfoundation.org> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20250917123351.839989757@linuxfoundation.org> References: <20250917123351.839989757@linuxfoundation.org> User-Agent: quilt/0.68 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.16-stable review patch. If anyone has any objections, please let me know. ------------------ From: Wei Yang commit 394bfac1c7f7b701c2c93834c5761b9c9ceeebcf upstream. Commit 8ee53820edfd ("thp: mmu_notifier_test_young") introduced mmu_notifier_test_young(), but we are passing the wrong address. In xxx_scan_pmd(), the actual iteration address is "_address" not "address". We seem to misuse the variable on the very beginning. Change it to the right one. [akpm@linux-foundation.org fix whitespace, per everyone] Link: https://lkml.kernel.org/r/20250822063318.11644-1-richard.weiyang@gmail.com Fixes: 8ee53820edfd ("thp: mmu_notifier_test_young") Signed-off-by: Wei Yang Reviewed-by: Dev Jain Reviewed-by: Zi Yan Acked-by: David Hildenbrand Reviewed-by: Lorenzo Stoakes Cc: Baolin Wang Cc: Liam R. Howlett Cc: Nico Pache Cc: Ryan Roberts Cc: Barry Song Cc: Signed-off-by: Andrew Morton Signed-off-by: Greg Kroah-Hartman --- mm/khugepaged.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) --- a/mm/khugepaged.c +++ b/mm/khugepaged.c @@ -1400,8 +1400,8 @@ static int hpage_collapse_scan_pmd(struc */ if (cc->is_khugepaged && (pte_young(pteval) || folio_test_young(folio) || - folio_test_referenced(folio) || mmu_notifier_test_young(vma->vm_mm, - address))) + folio_test_referenced(folio) || + mmu_notifier_test_young(vma->vm_mm, _address))) referenced++; } if (!writable) {