patches.lists.linux.dev archive mirror
 help / color / mirror / Atom feed
From: Sasha Levin <sashal@kernel.org>
To: patches@lists.linux.dev, stable@vger.kernel.org
Cc: aprilgrimoire <aprilgrimoire@proton.me>,
	"Mario Limonciello (AMD)" <superm1@kernel.org>,
	"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
	"Sasha Levin" <sashal@kernel.org>,
	Shyam-sundar.S-k@amd.com, platform-driver-x86@vger.kernel.org
Subject: [PATCH AUTOSEL 6.16-6.6] platform/x86/amd/pmc: Add MECHREVO Yilong15Pro to spurious_8042 list
Date: Mon, 22 Sep 2025 13:57:41 -0400	[thread overview]
Message-ID: <20250922175751.3747114-10-sashal@kernel.org> (raw)
In-Reply-To: <20250922175751.3747114-1-sashal@kernel.org>

From: aprilgrimoire <aprilgrimoire@proton.me>

[ Upstream commit 8822e8be86d40410ddd2ac8ff44f3050c9ecf9c6 ]

The firmware of Mechrevo Yilong15Pro emits a spurious keyboard interrupt on
events including closing the lid. When a user closes the lid on an already
suspended system this causes the system to wake up.
Add Mechrevo Yilong15Pro Series (GM5HG7A) to the list of quirk
spurious_8042 to work around this issue.

Link: https://lore.kernel.org/linux-pm/6ww4uu6Gl4F5n6VY5dl1ufASfKzs4DhMxAN8BuqUpCoqU3PQukVSVSBCl_lKIzkQ-S8kt1acPd58eyolhkWN32lMLFj4ViI0Tdu2jwhnYZ8=@proton.me/
Signed-off-by: April Grimoire <aprilgrimoire@proton.me>
Reviewed-by: Mario Limonciello (AMD) <superm1@kernel.org>
Link: https://patch.msgid.link/IvSc_IN5Pa0wRXElTk_fEl-cTpMZxg6TCQk_7aRUkTd9vJUp_ZeC0NdXZ0z6Tn7B-XiqqqQvCH65lq6FqhuECBMEYWcHQmWm1Jo7Br8kpeg=@proton.me
Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
---

LLM Generated explanations, may be completely bogus:

Based on my extensive analysis of the commit and comprehensive research
of the kernel subsystem, stable backporting practices, and similar
commits:

**Backport Status: YES**

## Detailed Justification:

### This commit is suitable for stable backporting because:

1. **Fixes a real user bug**: The commit fixes spurious system wakeups
   when closing the lid on an already suspended MECHREVO Yilong15Pro
   laptop - a frustrating issue that affects real users.

2. **Minimal and contained change**: The patch adds exactly 8 lines to a
   DMI quirk table - one of the safest types of kernel changes with
   virtually zero regression risk.

3. **Strong precedent for backporting**: My research found that similar
   spurious_8042 quirk additions have been regularly backported:
   - `0dd4a4cc9afdd`: TUXEDO IB Pro Gen10 (explicitly marked "Cc:
     stable@vger.kernel.org")
   - `0887817e49538`: MECHREVO Wujie 14XA (has Fixes: tag, auto-selected
     for stable)
   - Multiple other platform quirks routinely backported

4. **Meets stable kernel criteria**: Per Documentation/process/stable-
   kernel-rules.rst:
   - ✅ Fixes a real bug that bothers people
   - ✅ Falls under explicitly allowed "hardware quirks" category
   - ✅ "Just add a device ID" type change
   - ✅ Already merged in mainline with proper maintainer review

5. **Zero impact on other systems**: DMI quirks only affect systems with
   exact DMI string matches - no risk to other hardware.

6. **Well-understood mechanism**: The spurious_8042 quirk has been in
   the kernel since January 2023, is well-tested, and addresses a
   documented AMD platform firmware bug affecting multiple laptop
   models.

### Technical specifics from the code:
```c
+       {
+               .ident = "MECHREVO Yilong15Pro Series GM5HG7A",
+               .driver_data = &quirk_spurious_8042,
+               .matches = {
+                       DMI_MATCH(DMI_SYS_VENDOR, "MECHREVO"),
+                       DMI_MATCH(DMI_PRODUCT_NAME, "Yilong15Pro Series
GM5HG7A"),
+               }
+       },
```

This simply adds the laptop to the `fwbug_list[]` array in
`drivers/platform/x86/amd/pmc/pmc-quirks.c`, applying the existing
`quirk_spurious_8042` workaround that disables IRQ1 wakeup to prevent
spurious keyboard interrupts during suspend.

The commit has been properly reviewed by both Mario Limonciello (AMD
maintainer) and Ilpo Järvinen (platform/x86 maintainer), ensuring
quality and correctness.

**Recommendation**: This commit should be marked with "Cc:
stable@vger.kernel.org" for backporting to stable kernels where the
spurious_8042 quirk mechanism exists (6.2+).

 drivers/platform/x86/amd/pmc/pmc-quirks.c | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/drivers/platform/x86/amd/pmc/pmc-quirks.c b/drivers/platform/x86/amd/pmc/pmc-quirks.c
index 18fb44139de25..4d0a38e06f083 100644
--- a/drivers/platform/x86/amd/pmc/pmc-quirks.c
+++ b/drivers/platform/x86/amd/pmc/pmc-quirks.c
@@ -239,6 +239,14 @@ static const struct dmi_system_id fwbug_list[] = {
 			DMI_MATCH(DMI_BOARD_NAME, "WUJIE14-GX4HRXL"),
 		}
 	},
+	{
+		.ident = "MECHREVO Yilong15Pro Series GM5HG7A",
+		.driver_data = &quirk_spurious_8042,
+		.matches = {
+			DMI_MATCH(DMI_SYS_VENDOR, "MECHREVO"),
+			DMI_MATCH(DMI_PRODUCT_NAME, "Yilong15Pro Series GM5HG7A"),
+		}
+	},
 	/* https://bugzilla.kernel.org/show_bug.cgi?id=220116 */
 	{
 		.ident = "PCSpecialist Lafite Pro V 14M",
-- 
2.51.0


  parent reply	other threads:[~2025-09-22 17:58 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-22 17:57 [PATCH AUTOSEL 6.16-6.1] btrfs: ref-verify: handle damaged extent root tree Sasha Levin
2025-09-22 17:57 ` [PATCH AUTOSEL 6.16-6.12] platform/x86/amd/pmf: Support new ACPI ID AMDI0108 Sasha Levin
2025-09-22 17:57 ` [PATCH AUTOSEL 6.16] gpiolib: acpi: Ignore touchpad wakeup on GPD G1619-05 Sasha Levin
2025-09-22 17:57 ` [PATCH AUTOSEL 6.16] platform/x86: oxpec: Add support for OneXPlayer X1Pro EVA-02 Sasha Levin
2025-09-22 17:57 ` [PATCH AUTOSEL 6.16-6.6] ASoC: qcom: sc8280xp: Enable DAI format configuration for MI2S interfaces Sasha Levin
2025-09-23  7:17   ` Johan Hovold
2025-09-25  1:09     ` Sasha Levin
2025-09-22 17:57 ` [PATCH AUTOSEL 6.16-6.6] ASoC: amd: acp: Adjust pdm gain value Sasha Levin
2025-09-22 17:57 ` [PATCH AUTOSEL 6.16] drm/amdgpu/gfx11: Add Cleaner Shader Support for GFX11.0.1/11.0.4 GPUs Sasha Levin
2025-09-22 17:57 ` [PATCH AUTOSEL 6.16-5.4] perf subcmd: avoid crash in exclude_cmds when excludes is empty Sasha Levin
2025-09-22 17:57 ` [PATCH AUTOSEL 6.16] ASoC: rt712: avoid skipping the blind write Sasha Levin
2025-09-22 17:57 ` Sasha Levin [this message]
2025-09-22 17:57 ` [PATCH AUTOSEL 6.16-5.4] dm-integrity: limit MAX_TAG_SIZE to 255 Sasha Levin
2025-09-22 17:57 ` [PATCH AUTOSEL 6.16-6.1] ASoC: rt5682s: Adjust SAR ADC button mode to fix noise issue Sasha Levin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250922175751.3747114-10-sashal@kernel.org \
    --to=sashal@kernel.org \
    --cc=Shyam-sundar.S-k@amd.com \
    --cc=aprilgrimoire@proton.me \
    --cc=ilpo.jarvinen@linux.intel.com \
    --cc=patches@lists.linux.dev \
    --cc=platform-driver-x86@vger.kernel.org \
    --cc=stable@vger.kernel.org \
    --cc=superm1@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).