[PATCH 0/2] Fixes for pmac32_defconfig after fb.h removal from backlight.h

[PATCH 0/2] Fixes for pmac32_defconfig after fb.h removal from backlight.h

[Nathan Chancellor]

Commit 9f218f9bb9d2 ("backlight: Do not include <linux/fb.h> in header
file") exposed some necessary includes that were missing from a few
powerpc drivers, breaking the build. This series resolves them.

This should go via the backlight tree, which includes 9f218f9bb9d2, but
I have included the PowerPC folks for visibility.

---
Nathan Chancellor (2):
      powerpc/powermac: Include linux/of.h in backlight.c
      macintosh/via-pmu-backlight: Include linux/of.h and uapi/linux/fb.h

 arch/powerpc/platforms/powermac/backlight.c | 1 +
 drivers/macintosh/via-pmu-backlight.c       | 2 ++
 2 files changed, 3 insertions(+)
---
base-commit: 9f218f9bb9d274b9d5d48a4c95e1b199141fc1f2
change-id: 20250925-ppc-fixes-for-backlight-fb-h-removal-2b6a87cced02

Best regards,
--  
Nathan Chancellor <nathan@kernel.org>

[PATCH 1/2] powerpc/powermac: Include linux/of.h in backlight.c

[Nathan Chancellor]

After the recent removal of the fb.h include from backlight.h, which
transitively included of.h, there are several errors in the powermac backlight
driver:

  arch/powerpc/platforms/powermac/backlight.c: In function 'pmac_has_backlight_type':
  arch/powerpc/platforms/powermac/backlight.c:59:39: error: implicit declaration of function 'of_find_node_by_name'; did you mean 'bus_find_device_by_name'? [-Wimplicit-function-declaration]
     59 |         struct device_node* bk_node = of_find_node_by_name(NULL, "backlight");
        |                                       ^~~~~~~~~~~~~~~~~~~~
        |                                       bus_find_device_by_name
  arch/powerpc/platforms/powermac/backlight.c:59:39: error: initialization of 'struct device_node *' from 'int' makes pointer from integer without a cast [-Wint-conversion]
  arch/powerpc/platforms/powermac/backlight.c:60:17: error: implicit declaration of function 'of_property_match_string' [-Wimplicit-function-declaration]
     60 |         int i = of_property_match_string(bk_node, "backlight-control", type);
        |                 ^~~~~~~~~~~~~~~~~~~~~~~~
  arch/powerpc/platforms/powermac/backlight.c:62:9: error: implicit declaration of function 'of_node_put' [-Wimplicit-function-declaration]
     62 |         of_node_put(bk_node);
        |         ^~~~~~~~~~~

Explicitly include of.h to resolve the errors.

Fixes: 9f218f9bb9d2 ("backlight: Do not include <linux/fb.h> in header file")
Signed-off-by: Nathan Chancellor <nathan@kernel.org>
---
 arch/powerpc/platforms/powermac/backlight.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/powerpc/platforms/powermac/backlight.c b/arch/powerpc/platforms/powermac/backlight.c
index 79741370c40c..9afb64723649 100644
--- a/arch/powerpc/platforms/powermac/backlight.c
+++ b/arch/powerpc/platforms/powermac/backlight.c
@@ -14,6 +14,7 @@
 #include <linux/pmu.h>
 #include <linux/atomic.h>
 #include <linux/export.h>
+#include <linux/of.h>
 #include <asm/backlight.h>
 
 #define OLD_BACKLIGHT_MAX 15

-- 
2.51.0

[PATCH 2/2] macintosh/via-pmu-backlight: Include linux/of.h and uapi/linux/fb.h

[Nathan Chancellor]

After the recent removal of the fb.h include from backlight.h, which
transitively included of.h, there are several errors from
via-pmu-backlight.c (errors from bl_curve not being properly defined
omitted):

  drivers/macintosh/via-pmu-backlight.c:22:20: error: 'FB_BACKLIGHT_LEVELS' undeclared here (not in a function)
     22 | static u8 bl_curve[FB_BACKLIGHT_LEVELS];
        |                    ^~~~~~~~~~~~~~~~~~~
  drivers/macintosh/via-pmu-backlight.c: In function 'pmu_backlight_get_level_brightness':
  drivers/macintosh/via-pmu-backlight.c:63:38: error: 'FB_BACKLIGHT_MAX' undeclared (first use in this function); did you mean 'BACKLIGHT_RAW'?
     63 |         pmulevel = bl_curve[level] * FB_BACKLIGHT_MAX / MAX_PMU_LEVEL;
        |                                      ^~~~~~~~~~~~~~~~
        |                                      BACKLIGHT_RAW
  drivers/macintosh/via-pmu-backlight.c: In function 'pmu_backlight_init':
  drivers/macintosh/via-pmu-backlight.c:144:17: error: implicit declaration of function 'of_machine_is_compatible' [-Wimplicit-function-declaration]
    144 |                 of_machine_is_compatible("AAPL,3400/2400") ||
        |                 ^~~~~~~~~~~~~~~~~~~~~~~~

FB_BACKLIGHT_{LEVELS,MAX} are available from the userspace API fb.h so
just include that avoid dragging in the full fb.h header unnecessarily.
Include linux/of.h for of_machine_is_compatible().

Fixes: 9f218f9bb9d2 ("backlight: Do not include <linux/fb.h> in header file")
Signed-off-by: Nathan Chancellor <nathan@kernel.org>
---
 drivers/macintosh/via-pmu-backlight.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/macintosh/via-pmu-backlight.c b/drivers/macintosh/via-pmu-backlight.c
index 26bd9ed5e664..f7b7853b3802 100644
--- a/drivers/macintosh/via-pmu-backlight.c
+++ b/drivers/macintosh/via-pmu-backlight.c
@@ -11,7 +11,9 @@
 #include <asm/ptrace.h>
 #include <linux/adb.h>
 #include <linux/backlight.h>
+#include <linux/of.h>
 #include <linux/pmu.h>
+#include <uapi/linux/fb.h>
 #include <asm/backlight.h>
 
 #define MAX_PMU_LEVEL 0xFF

-- 
2.51.0

Re: [PATCH 1/2] powerpc/powermac: Include linux/of.h in backlight.c

[Christophe Leroy]

Le 26/09/2025 à 01:46, Nathan Chancellor a écrit :
> After the recent removal of the fb.h include from backlight.h, which
> transitively included of.h, there are several errors in the powermac backlight
> driver:
> 
>    arch/powerpc/platforms/powermac/backlight.c: In function 'pmac_has_backlight_type':
>    arch/powerpc/platforms/powermac/backlight.c:59:39: error: implicit declaration of function 'of_find_node_by_name'; did you mean 'bus_find_device_by_name'? [-Wimplicit-function-declaration]
>       59 |         struct device_node* bk_node = of_find_node_by_name(NULL, "backlight");
>          |                                       ^~~~~~~~~~~~~~~~~~~~
>          |                                       bus_find_device_by_name
>    arch/powerpc/platforms/powermac/backlight.c:59:39: error: initialization of 'struct device_node *' from 'int' makes pointer from integer without a cast [-Wint-conversion]
>    arch/powerpc/platforms/powermac/backlight.c:60:17: error: implicit declaration of function 'of_property_match_string' [-Wimplicit-function-declaration]
>       60 |         int i = of_property_match_string(bk_node, "backlight-control", type);
>          |                 ^~~~~~~~~~~~~~~~~~~~~~~~
>    arch/powerpc/platforms/powermac/backlight.c:62:9: error: implicit declaration of function 'of_node_put' [-Wimplicit-function-declaration]
>       62 |         of_node_put(bk_node);
>          |         ^~~~~~~~~~~
> 
> Explicitly include of.h to resolve the errors.
> 
> Fixes: 9f218f9bb9d2 ("backlight: Do not include <linux/fb.h> in header file")
> Signed-off-by: Nathan Chancellor <nathan@kernel.org>

Reviewed-by: Christophe Leroy <christophe.leroy@csgroup.eu>

> ---
>   arch/powerpc/platforms/powermac/backlight.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/arch/powerpc/platforms/powermac/backlight.c b/arch/powerpc/platforms/powermac/backlight.c
> index 79741370c40c..9afb64723649 100644
> --- a/arch/powerpc/platforms/powermac/backlight.c
> +++ b/arch/powerpc/platforms/powermac/backlight.c
> @@ -14,6 +14,7 @@
>   #include <linux/pmu.h>
>   #include <linux/atomic.h>
>   #include <linux/export.h>
> +#include <linux/of.h>
>   #include <asm/backlight.h>
>   
>   #define OLD_BACKLIGHT_MAX 15
> 

Re: [PATCH 2/2] macintosh/via-pmu-backlight: Include linux/of.h and uapi/linux/fb.h

[Christophe Leroy]

Le 26/09/2025 à 01:46, Nathan Chancellor a écrit :
> After the recent removal of the fb.h include from backlight.h, which
> transitively included of.h, there are several errors from
> via-pmu-backlight.c (errors from bl_curve not being properly defined
> omitted):
> 
>    drivers/macintosh/via-pmu-backlight.c:22:20: error: 'FB_BACKLIGHT_LEVELS' undeclared here (not in a function)
>       22 | static u8 bl_curve[FB_BACKLIGHT_LEVELS];
>          |                    ^~~~~~~~~~~~~~~~~~~
>    drivers/macintosh/via-pmu-backlight.c: In function 'pmu_backlight_get_level_brightness':
>    drivers/macintosh/via-pmu-backlight.c:63:38: error: 'FB_BACKLIGHT_MAX' undeclared (first use in this function); did you mean 'BACKLIGHT_RAW'?
>       63 |         pmulevel = bl_curve[level] * FB_BACKLIGHT_MAX / MAX_PMU_LEVEL;
>          |                                      ^~~~~~~~~~~~~~~~
>          |                                      BACKLIGHT_RAW
>    drivers/macintosh/via-pmu-backlight.c: In function 'pmu_backlight_init':
>    drivers/macintosh/via-pmu-backlight.c:144:17: error: implicit declaration of function 'of_machine_is_compatible' [-Wimplicit-function-declaration]
>      144 |                 of_machine_is_compatible("AAPL,3400/2400") ||
>          |                 ^~~~~~~~~~~~~~~~~~~~~~~~
> 
> FB_BACKLIGHT_{LEVELS,MAX} are available from the userspace API fb.h so
> just include that avoid dragging in the full fb.h header unnecessarily.
> Include linux/of.h for of_machine_is_compatible().
> 
> Fixes: 9f218f9bb9d2 ("backlight: Do not include <linux/fb.h> in header file")
> Signed-off-by: Nathan Chancellor <nathan@kernel.org>

Reviewed-by: Christophe Leroy <christophe.leroy@csgroup.eu>

> ---
>   drivers/macintosh/via-pmu-backlight.c | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/macintosh/via-pmu-backlight.c b/drivers/macintosh/via-pmu-backlight.c
> index 26bd9ed5e664..f7b7853b3802 100644
> --- a/drivers/macintosh/via-pmu-backlight.c
> +++ b/drivers/macintosh/via-pmu-backlight.c
> @@ -11,7 +11,9 @@
>   #include <asm/ptrace.h>
>   #include <linux/adb.h>
>   #include <linux/backlight.h>
> +#include <linux/of.h>
>   #include <linux/pmu.h>
> +#include <uapi/linux/fb.h>
>   #include <asm/backlight.h>
>   
>   #define MAX_PMU_LEVEL 0xFF
> 

Re: [PATCH 0/2] Fixes for pmac32_defconfig after fb.h removal from backlight.h

[Christophe Leroy]

Hi All,

Le 26/09/2025 à 01:46, Nathan Chancellor a écrit :
> Commit 9f218f9bb9d2 ("backlight: Do not include <linux/fb.h> in header
> file") exposed some necessary includes that were missing from a few
> powerpc drivers, breaking the build. This series resolves them.
> 
> This should go via the backlight tree, which includes 9f218f9bb9d2, but
> I have included the PowerPC folks for visibility.

What is the status of this fixing series ? I see a couple of similar 
redundant patchs (see below) roaming around, which make me wonder if 
this series has been properly processed in the backlight tree.

https://patchwork.ozlabs.org/project/linuxppc-dev/cover/20251029150940.2523328-1-thierry.reding@gmail.com/
https://patchwork.ozlabs.org/project/linuxppc-dev/cover/20251027140646.227025-1-tzimmermann@suse.de/

Christophe

> 
> ---
> Nathan Chancellor (2):
>        powerpc/powermac: Include linux/of.h in backlight.c
>        macintosh/via-pmu-backlight: Include linux/of.h and uapi/linux/fb.h
> 
>   arch/powerpc/platforms/powermac/backlight.c | 1 +
>   drivers/macintosh/via-pmu-backlight.c       | 2 ++
>   2 files changed, 3 insertions(+)
> ---
> base-commit: 9f218f9bb9d274b9d5d48a4c95e1b199141fc1f2
> change-id: 20250925-ppc-fixes-for-backlight-fb-h-removal-2b6a87cced02
> 
> Best regards,
> --
> Nathan Chancellor <nathan@kernel.org>
> 

Re: [PATCH 0/2] Fixes for pmac32_defconfig after fb.h removal from backlight.h

[Thomas Zimmermann]

Hi

Am 26.09.25 um 01:46 schrieb Nathan Chancellor:
> Commit 9f218f9bb9d2 ("backlight: Do not include <linux/fb.h> in header
> file") exposed some necessary includes that were missing from a few
> powerpc drivers, breaking the build. This series resolves them.
>
> This should go via the backlight tree, which includes 9f218f9bb9d2, but
> I have included the PowerPC folks for visibility.
>
> ---
> Nathan Chancellor (2):
>        powerpc/powermac: Include linux/of.h in backlight.c
>        macintosh/via-pmu-backlight: Include linux/of.h and uapi/linux/fb.h
>
>   arch/powerpc/platforms/powermac/backlight.c | 1 +
>   drivers/macintosh/via-pmu-backlight.c       | 2 ++
>   2 files changed, 3 insertions(+)

Please also see:

  https://lore.kernel.org/dri-devel/20251027140646.227025-1-tzimmermann@suse.de/

Can one of these series please be merged into the respective tree?

Best regards
Thomas

> ---
> base-commit: 9f218f9bb9d274b9d5d48a4c95e1b199141fc1f2
> change-id: 20250925-ppc-fixes-for-backlight-fb-h-removal-2b6a87cced02
>
> Best regards,
> --
> Nathan Chancellor <nathan@kernel.org>
>

-- 
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Frankenstr. 146, 90461 Nürnberg, Germany, www.suse.com
GF: Jochen Jaser, Andrew McDonald, Werner Knoblich, (HRB 36809, AG Nürnberg)

Re: [PATCH 2/2] macintosh/via-pmu-backlight: Include linux/of.h and uapi/linux/fb.h

[Thomas Zimmermann]

Hi

Am 26.09.25 um 01:46 schrieb Nathan Chancellor:
> After the recent removal of the fb.h include from backlight.h, which
> transitively included of.h, there are several errors from
> via-pmu-backlight.c (errors from bl_curve not being properly defined
> omitted):
>
>    drivers/macintosh/via-pmu-backlight.c:22:20: error: 'FB_BACKLIGHT_LEVELS' undeclared here (not in a function)
>       22 | static u8 bl_curve[FB_BACKLIGHT_LEVELS];
>          |                    ^~~~~~~~~~~~~~~~~~~
>    drivers/macintosh/via-pmu-backlight.c: In function 'pmu_backlight_get_level_brightness':
>    drivers/macintosh/via-pmu-backlight.c:63:38: error: 'FB_BACKLIGHT_MAX' undeclared (first use in this function); did you mean 'BACKLIGHT_RAW'?
>       63 |         pmulevel = bl_curve[level] * FB_BACKLIGHT_MAX / MAX_PMU_LEVEL;
>          |                                      ^~~~~~~~~~~~~~~~
>          |                                      BACKLIGHT_RAW
>    drivers/macintosh/via-pmu-backlight.c: In function 'pmu_backlight_init':
>    drivers/macintosh/via-pmu-backlight.c:144:17: error: implicit declaration of function 'of_machine_is_compatible' [-Wimplicit-function-declaration]
>      144 |                 of_machine_is_compatible("AAPL,3400/2400") ||
>          |                 ^~~~~~~~~~~~~~~~~~~~~~~~
>
> FB_BACKLIGHT_{LEVELS,MAX} are available from the userspace API fb.h so
> just include that avoid dragging in the full fb.h header unnecessarily.
> Include linux/of.h for of_machine_is_compatible().
>
> Fixes: 9f218f9bb9d2 ("backlight: Do not include <linux/fb.h> in header file")
> Signed-off-by: Nathan Chancellor <nathan@kernel.org>
> ---
>   drivers/macintosh/via-pmu-backlight.c | 2 ++
>   1 file changed, 2 insertions(+)
>
> diff --git a/drivers/macintosh/via-pmu-backlight.c b/drivers/macintosh/via-pmu-backlight.c
> index 26bd9ed5e664..f7b7853b3802 100644
> --- a/drivers/macintosh/via-pmu-backlight.c
> +++ b/drivers/macintosh/via-pmu-backlight.c
> @@ -11,7 +11,9 @@
>   #include <asm/ptrace.h>
>   #include <linux/adb.h>
>   #include <linux/backlight.h>
> +#include <linux/of.h>
>   #include <linux/pmu.h>
> +#include <uapi/linux/fb.h>

Should this not be <linux/fb.h> ?

Best regards
Thomas


>   #include <asm/backlight.h>
>   
>   #define MAX_PMU_LEVEL 0xFF
>

-- 
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Frankenstr. 146, 90461 Nürnberg, Germany, www.suse.com
GF: Jochen Jaser, Andrew McDonald, Werner Knoblich, (HRB 36809, AG Nürnberg)

Re: [PATCH 2/2] macintosh/via-pmu-backlight: Include linux/of.h and uapi/linux/fb.h

[Nathan Chancellor]

On Tue, Nov 04, 2025 at 01:43:26PM +0100, Thomas Zimmermann wrote:
> Hi
> 
> Am 26.09.25 um 01:46 schrieb Nathan Chancellor:
> > After the recent removal of the fb.h include from backlight.h, which
> > transitively included of.h, there are several errors from
> > via-pmu-backlight.c (errors from bl_curve not being properly defined
> > omitted):
> > 
> >    drivers/macintosh/via-pmu-backlight.c:22:20: error: 'FB_BACKLIGHT_LEVELS' undeclared here (not in a function)
> >       22 | static u8 bl_curve[FB_BACKLIGHT_LEVELS];
> >          |                    ^~~~~~~~~~~~~~~~~~~
> >    drivers/macintosh/via-pmu-backlight.c: In function 'pmu_backlight_get_level_brightness':
> >    drivers/macintosh/via-pmu-backlight.c:63:38: error: 'FB_BACKLIGHT_MAX' undeclared (first use in this function); did you mean 'BACKLIGHT_RAW'?
> >       63 |         pmulevel = bl_curve[level] * FB_BACKLIGHT_MAX / MAX_PMU_LEVEL;
> >          |                                      ^~~~~~~~~~~~~~~~
> >          |                                      BACKLIGHT_RAW
> >    drivers/macintosh/via-pmu-backlight.c: In function 'pmu_backlight_init':
> >    drivers/macintosh/via-pmu-backlight.c:144:17: error: implicit declaration of function 'of_machine_is_compatible' [-Wimplicit-function-declaration]
> >      144 |                 of_machine_is_compatible("AAPL,3400/2400") ||
> >          |                 ^~~~~~~~~~~~~~~~~~~~~~~~
> > 
> > FB_BACKLIGHT_{LEVELS,MAX} are available from the userspace API fb.h so
> > just include that avoid dragging in the full fb.h header unnecessarily.
> > Include linux/of.h for of_machine_is_compatible().
> > 
> > Fixes: 9f218f9bb9d2 ("backlight: Do not include <linux/fb.h> in header file")
> > Signed-off-by: Nathan Chancellor <nathan@kernel.org>
> > ---
> >   drivers/macintosh/via-pmu-backlight.c | 2 ++
> >   1 file changed, 2 insertions(+)
> > 
> > diff --git a/drivers/macintosh/via-pmu-backlight.c b/drivers/macintosh/via-pmu-backlight.c
> > index 26bd9ed5e664..f7b7853b3802 100644
> > --- a/drivers/macintosh/via-pmu-backlight.c
> > +++ b/drivers/macintosh/via-pmu-backlight.c
> > @@ -11,7 +11,9 @@
> >   #include <asm/ptrace.h>
> >   #include <linux/adb.h>
> >   #include <linux/backlight.h>
> > +#include <linux/of.h>
> >   #include <linux/pmu.h>
> > +#include <uapi/linux/fb.h>
> 
> Should this not be <linux/fb.h> ?

It could be but as I mention above, this file only needs the UAPI
FB_BACKLIGHT_LEVELS and FB_BACKLIGHT_MAX constants so I did not really
feel like it was worth it to drag in the whole fb.h header.

> >   #include <asm/backlight.h>
> >   #define MAX_PMU_LEVEL 0xFF
> > 
> 
> -- 
> --
> Thomas Zimmermann
> Graphics Driver Developer
> SUSE Software Solutions Germany GmbH
> Frankenstr. 146, 90461 Nürnberg, Germany, www.suse.com
> GF: Jochen Jaser, Andrew McDonald, Werner Knoblich, (HRB 36809, AG Nürnberg)
> 
> 

Re: [PATCH 2/2] macintosh/via-pmu-backlight: Include linux/of.h and uapi/linux/fb.h

[Thomas Zimmermann]

Hi

Am 04.11.25 um 18:01 schrieb Nathan Chancellor:
> On Tue, Nov 04, 2025 at 01:43:26PM +0100, Thomas Zimmermann wrote:
>> Hi
>>
>> Am 26.09.25 um 01:46 schrieb Nathan Chancellor:
>>> After the recent removal of the fb.h include from backlight.h, which
>>> transitively included of.h, there are several errors from
>>> via-pmu-backlight.c (errors from bl_curve not being properly defined
>>> omitted):
>>>
>>>     drivers/macintosh/via-pmu-backlight.c:22:20: error: 'FB_BACKLIGHT_LEVELS' undeclared here (not in a function)
>>>        22 | static u8 bl_curve[FB_BACKLIGHT_LEVELS];
>>>           |                    ^~~~~~~~~~~~~~~~~~~
>>>     drivers/macintosh/via-pmu-backlight.c: In function 'pmu_backlight_get_level_brightness':
>>>     drivers/macintosh/via-pmu-backlight.c:63:38: error: 'FB_BACKLIGHT_MAX' undeclared (first use in this function); did you mean 'BACKLIGHT_RAW'?
>>>        63 |         pmulevel = bl_curve[level] * FB_BACKLIGHT_MAX / MAX_PMU_LEVEL;
>>>           |                                      ^~~~~~~~~~~~~~~~
>>>           |                                      BACKLIGHT_RAW
>>>     drivers/macintosh/via-pmu-backlight.c: In function 'pmu_backlight_init':
>>>     drivers/macintosh/via-pmu-backlight.c:144:17: error: implicit declaration of function 'of_machine_is_compatible' [-Wimplicit-function-declaration]
>>>       144 |                 of_machine_is_compatible("AAPL,3400/2400") ||
>>>           |                 ^~~~~~~~~~~~~~~~~~~~~~~~
>>>
>>> FB_BACKLIGHT_{LEVELS,MAX} are available from the userspace API fb.h so
>>> just include that avoid dragging in the full fb.h header unnecessarily.
>>> Include linux/of.h for of_machine_is_compatible().
>>>
>>> Fixes: 9f218f9bb9d2 ("backlight: Do not include <linux/fb.h> in header file")
>>> Signed-off-by: Nathan Chancellor <nathan@kernel.org>
>>> ---
>>>    drivers/macintosh/via-pmu-backlight.c | 2 ++
>>>    1 file changed, 2 insertions(+)
>>>
>>> diff --git a/drivers/macintosh/via-pmu-backlight.c b/drivers/macintosh/via-pmu-backlight.c
>>> index 26bd9ed5e664..f7b7853b3802 100644
>>> --- a/drivers/macintosh/via-pmu-backlight.c
>>> +++ b/drivers/macintosh/via-pmu-backlight.c
>>> @@ -11,7 +11,9 @@
>>>    #include <asm/ptrace.h>
>>>    #include <linux/adb.h>
>>>    #include <linux/backlight.h>
>>> +#include <linux/of.h>
>>>    #include <linux/pmu.h>
>>> +#include <uapi/linux/fb.h>
>> Should this not be <linux/fb.h> ?
> It could be but as I mention above, this file only needs the UAPI
> FB_BACKLIGHT_LEVELS and FB_BACKLIGHT_MAX constants so I did not really
> feel like it was worth it to drag in the whole fb.h header.

I mean that I thought that the internal header would be preferred over 
the UAPI header if both exist. But maybe I misremember.

Best regards
Thomas

>
>>>    #include <asm/backlight.h>
>>>    #define MAX_PMU_LEVEL 0xFF
>>>
>> -- 
>> --
>> Thomas Zimmermann
>> Graphics Driver Developer
>> SUSE Software Solutions Germany GmbH
>> Frankenstr. 146, 90461 Nürnberg, Germany, www.suse.com
>> GF: Jochen Jaser, Andrew McDonald, Werner Knoblich, (HRB 36809, AG Nürnberg)
>>
>>

-- 
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Frankenstr. 146, 90461 Nürnberg, Germany, www.suse.com
GF: Jochen Jaser, Andrew McDonald, Werner Knoblich, (HRB 36809, AG Nürnberg)

Re: [PATCH 0/2] Fixes for pmac32_defconfig after fb.h removal from backlight.h

[Madhavan Srinivasan]

On 11/4/25 4:59 PM, Christophe Leroy wrote:
> Hi All,
> 
> Le 26/09/2025 à 01:46, Nathan Chancellor a écrit :
>> Commit 9f218f9bb9d2 ("backlight: Do not include <linux/fb.h> in header
>> file") exposed some necessary includes that were missing from a few
>> powerpc drivers, breaking the build. This series resolves them.
>>
>> This should go via the backlight tree, which includes 9f218f9bb9d2, but
>> I have included the PowerPC folks for visibility.
> 
> What is the status of this fixing series ? I see a couple of similar redundant patchs (see below) roaming around, which make me wonder if this series has been properly processed in the backlight tree.
> 

Yes, i will pull this as part of the powerpc tree.

Maddy
(sorry for the delay)


> https://patchwork.ozlabs.org/project/linuxppc-dev/cover/20251029150940.2523328-1-thierry.reding@gmail.com/
> https://patchwork.ozlabs.org/project/linuxppc-dev/cover/20251027140646.227025-1-tzimmermann@suse.de/
> 
> Christophe
> 
>>
>> ---
>> Nathan Chancellor (2):
>>        powerpc/powermac: Include linux/of.h in backlight.c
>>        macintosh/via-pmu-backlight: Include linux/of.h and uapi/linux/fb.h
>>
>>   arch/powerpc/platforms/powermac/backlight.c | 1 +
>>   drivers/macintosh/via-pmu-backlight.c       | 2 ++
>>   2 files changed, 3 insertions(+)
>> ---
>> base-commit: 9f218f9bb9d274b9d5d48a4c95e1b199141fc1f2
>> change-id: 20250925-ppc-fixes-for-backlight-fb-h-removal-2b6a87cced02
>>
>> Best regards,
>> -- 
>> Nathan Chancellor <nathan@kernel.org>
>>
>