From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 784DE2253FC; Tue, 30 Sep 2025 14:50:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759243813; cv=none; b=RGKuEWX50YRx9SPUSwtfj+zaJfWjMhLHiwKuMKCbksEQqOXm07OYOCHcTse36nel82+cMR+audPcjOH7gxRqnoKjxXb1BZgYSKIjjQAksTvZctpwHa76/CVm4sR0PXgbpeax7+teby1wXw0ysNDYKsQX3JtysfICPdG/+Jt/cZc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759243813; c=relaxed/simple; bh=jbBiHG6FrrWtVa7Nw3zrDxjylcHh9T26UJcfELRjiBY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=LxnbaNe0VvqYUKFnNPNEfO84ncJRSUFZAkq5f4RjmNHEujUA4VXc2EcxGR5U2XRN3kd0w0sSpxCq1GdPJqZSndDjGKbtma+a9w0B0gB05M9/ddDS7do4HtcBj3wlbSHOalybNKkm8zG5Tjs5IKG2nnRf3pJgmCGsRslAO5Ellts= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=DslSwZSN; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="DslSwZSN" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 822CEC4CEF0; Tue, 30 Sep 2025 14:50:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1759243812; bh=jbBiHG6FrrWtVa7Nw3zrDxjylcHh9T26UJcfELRjiBY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=DslSwZSNB+ddar0cykb489lfkSGoLiP/X8mGqLPunCa62/pvG+g2p/peG856g3BB/ q4F7t7sHdYarrwNn3DndK71vmmLNkfXf7vh/QKTAMSKLy7qxDhCMJVjLYVduy4hIl+ 5ozLUGGwOKhr9/mBJcfFIHy/2wzBRmjAZTqi2D+U= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Tetsuo Handa , Oleksij Rempel , Marc Kleine-Budde , Sasha Levin Subject: [PATCH 5.4 24/81] can: j1939: j1939_sk_bind(): call j1939_priv_put() immediately when j1939_local_ecu_get() failed Date: Tue, 30 Sep 2025 16:46:26 +0200 Message-ID: <20250930143820.677386372@linuxfoundation.org> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20250930143819.654157320@linuxfoundation.org> References: <20250930143819.654157320@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.4-stable review patch. If anyone has any objections, please let me know. ------------------ From: Tetsuo Handa [ Upstream commit f214744c8a27c3c1da6b538c232da22cd027530e ] Commit 25fe97cb7620 ("can: j1939: move j1939_priv_put() into sk_destruct callback") expects that a call to j1939_priv_put() can be unconditionally delayed until j1939_sk_sock_destruct() is called. But a refcount leak will happen when j1939_sk_bind() is called again after j1939_local_ecu_get() from previous j1939_sk_bind() call returned an error. We need to call j1939_priv_put() before j1939_sk_bind() returns an error. Fixes: 25fe97cb7620 ("can: j1939: move j1939_priv_put() into sk_destruct callback") Signed-off-by: Tetsuo Handa Tested-by: Oleksij Rempel Acked-by: Oleksij Rempel Link: https://patch.msgid.link/4f49a1bc-a528-42ad-86c0-187268ab6535@I-love.SAKURA.ne.jp Signed-off-by: Marc Kleine-Budde Signed-off-by: Sasha Levin --- net/can/j1939/socket.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/net/can/j1939/socket.c b/net/can/j1939/socket.c index 29f9a343b0dbf..f477add424bc9 100644 --- a/net/can/j1939/socket.c +++ b/net/can/j1939/socket.c @@ -520,6 +520,9 @@ static int j1939_sk_bind(struct socket *sock, struct sockaddr *uaddr, int len) ret = j1939_local_ecu_get(priv, jsk->addr.src_name, jsk->addr.sa); if (ret) { j1939_netdev_stop(priv); + jsk->priv = NULL; + synchronize_rcu(); + j1939_priv_put(priv); goto out_release_sock; } -- 2.51.0