From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A484D29827E; Tue, 30 Sep 2025 15:21:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759245698; cv=none; b=nelhUChmaTJT6x97Y/OyEl9bNwOKDx62taV4RRQ5BxzNN5vHKL2G6KEHgpxVJ60u6J5V52uBMh63bgDrPFhrVW2DwfG/PHVKGoWS0+FBVupi1HfO1m91MuSEdghqZFquiK+VFJm9J2KB4ef1dHIZrUl4NUNSG31YIcg+Pgl5TNY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759245698; c=relaxed/simple; bh=qzeEjgB3vxn3R4Z8Q0WZzjAMmUJtw7UxJrerxpFInxY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=PbA9lOk1tPIUS2rypHb90PdjBa7NcXpsSLByU48MFE9YtzDhSATVx3WjpVH7Idcz2aGG/jTASkuCCmLAamJTVA/5bls4agSu9t7CKGtucFe48lbQITTpDqhkzSl1xVOqYF1ZyELA6DD7XiVAfqD8DRSny4t+EZzUETb4mzVmFA4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=WTWiZFSH; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="WTWiZFSH" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1310AC113D0; Tue, 30 Sep 2025 15:21:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1759245698; bh=qzeEjgB3vxn3R4Z8Q0WZzjAMmUJtw7UxJrerxpFInxY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=WTWiZFSHvqMdDvarDFx3bGIxL8Jg7MWi1CjIyM3CetgYtG0jYK1aR8vmyKBbYNE21 2aAC3aXQITXg6GKerMBCebozZNRN+z/4VdMK/VAFaXQORujTm3Z8d57n4S3J7ykOCV 8Ftq5OnwYGUXF1lNcYFJSyuMh8YNUcB6cllX92SU= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Cristian Ciocaltea , Takashi Iwai , Sasha Levin Subject: [PATCH 6.6 07/91] ALSA: usb-audio: Remove unneeded wmb() in mixer_quirks Date: Tue, 30 Sep 2025 16:47:06 +0200 Message-ID: <20250930143821.422345501@linuxfoundation.org> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20250930143821.118938523@linuxfoundation.org> References: <20250930143821.118938523@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.6-stable review patch. If anyone has any objections, please let me know. ------------------ From: Cristian Ciocaltea [ Upstream commit 9cea7425595697802e8d55a322a251999554b8b1 ] Adding a memory barrier before wake_up() in snd_usb_soundblaster_remote_complete() is supposed to ensure the write to mixer->rc_code is visible in wait_event_interruptible() from snd_usb_sbrc_hwdep_read(). However, this is not really necessary, since wake_up() is just a wrapper over __wake_up() which already executes a full memory barrier before accessing the state of the task to be waken up. Drop the redundant call to wmb() and implicitly fix the checkpatch complaint: WARNING: memory barrier without comment Signed-off-by: Cristian Ciocaltea Signed-off-by: Takashi Iwai Link: https://patch.msgid.link/20250526-dualsense-alsa-jack-v1-8-1a821463b632@collabora.com Signed-off-by: Sasha Levin --- sound/usb/mixer_quirks.c | 1 - 1 file changed, 1 deletion(-) diff --git a/sound/usb/mixer_quirks.c b/sound/usb/mixer_quirks.c index 9a5e8c47ce0d2..e5252167d6a40 100644 --- a/sound/usb/mixer_quirks.c +++ b/sound/usb/mixer_quirks.c @@ -208,7 +208,6 @@ static void snd_usb_soundblaster_remote_complete(struct urb *urb) if (code == rc->mute_code) snd_usb_mixer_notify_id(mixer, rc->mute_mixer_id); mixer->rc_code = code; - wmb(); wake_up(&mixer->rc_waitq); } -- 2.51.0