From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D9254304989; Tue, 30 Sep 2025 14:51:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759243873; cv=none; b=k6MDg0zQbA7UJqJEHLS+FRmuVyLt0vxfAgX0eDDpH/q5x0rar8z85LRZTp+jJyjKeDDcWNAFkFuxbCqpvc5v9rFdXkbD7+M1uE4pkxEJln28pPGoPT6UD4QzwTUY/aKI40Vn4vRXlzeQ1kqAD/Itk5Z66iipEvyU4yCFkRsWCK0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759243873; c=relaxed/simple; bh=LpfdolcASkSuxdy60uqir/3s8leQ1JeyxsVPjnRZvHg=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=JxzuX3ZVbuLjESa0pOSWCWNATbLkyrVmbZxstN1sZF5F40vw820IRD9HhaJw5dkBFMr/nYu9aEFK25Qyq7JcIV6xXGyAGWoM/cOOSvt7f293NbV9mSZ3Xi0OdSMEoFKeMczGd0blDkjPS0LrQ0s/LiuclmVCLXBu/ErJc3fuVb4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=a0dG0BSF; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="a0dG0BSF" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4A982C113D0; Tue, 30 Sep 2025 14:51:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1759243873; bh=LpfdolcASkSuxdy60uqir/3s8leQ1JeyxsVPjnRZvHg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=a0dG0BSFHtu+aZOb7adL6xk1ZSl5kxg0grXVnAky77radxwsE5p0xjjlzdUn60ExU Q3yuPnD1lctTPIrE+pgNeqmWntHp1MhgcfEmW/hKfgRvSFY50OnH8/pO35c5DjVVQ/ Fw2wO5LPyj8U2FRUMu2napFMaz3LsIfe7pz7Nj/Q= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Jerry Lv , "H. Nikolaus Schaller" , Sebastian Reichel Subject: [PATCH 5.4 43/81] power: supply: bq27xxx: restrict no-battery detection to bq27000 Date: Tue, 30 Sep 2025 16:46:45 +0200 Message-ID: <20250930143821.472523369@linuxfoundation.org> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20250930143819.654157320@linuxfoundation.org> References: <20250930143819.654157320@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.4-stable review patch. If anyone has any objections, please let me know. ------------------ From: H. Nikolaus Schaller commit 1e451977e1703b6db072719b37cd1b8e250b9cc9 upstream. There are fuel gauges in the bq27xxx series (e.g. bq27z561) which may in some cases report 0xff as the value of BQ27XXX_REG_FLAGS that should not be interpreted as "no battery" like for a disconnected battery with some built in bq27000 chip. So restrict the no-battery detection originally introduced by commit 3dd843e1c26a ("bq27000: report missing device better.") to the bq27000. There is no need to backport further because this was hidden before commit f16d9fb6cf03 ("power: supply: bq27xxx: Retrieve again when busy") Fixes: f16d9fb6cf03 ("power: supply: bq27xxx: Retrieve again when busy") Suggested-by: Jerry Lv Cc: stable@vger.kernel.org Signed-off-by: H. Nikolaus Schaller Link: https://lore.kernel.org/r/dd979fa6855fd051ee5117016c58daaa05966e24.1755945297.git.hns@goldelico.com Signed-off-by: Sebastian Reichel Signed-off-by: Greg Kroah-Hartman --- drivers/power/supply/bq27xxx_battery.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) --- a/drivers/power/supply/bq27xxx_battery.c +++ b/drivers/power/supply/bq27xxx_battery.c @@ -1552,8 +1552,8 @@ static void bq27xxx_battery_update_unloc bool has_singe_flag = di->opts & BQ27XXX_O_ZERO; cache.flags = bq27xxx_read(di, BQ27XXX_REG_FLAGS, has_singe_flag); - if ((cache.flags & 0xff) == 0xff) - cache.flags = -ENODEV; /* read error */ + if (di->chip == BQ27000 && (cache.flags & 0xff) == 0xff) + cache.flags = -ENODEV; /* bq27000 hdq read error */ if (cache.flags >= 0) { cache.temperature = bq27xxx_battery_read_temperature(di); if (has_ci_flag && (cache.flags & BQ27000_FLAG_CI)) {