From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ECCD12441B8; Tue, 30 Sep 2025 14:51:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759243891; cv=none; b=s+z+ft1yQkYpkpETTWmVQMjPyqBdgTSQQduRGEP72fUC5CVbfx8mc53Pv7UC/kd70RICD2sO5UzamW8k6IbTKQJZ3KnQ9y7JhyH5rXjQ1fFL5Btqv7NWKi6HSGWuF9m2v93m2tbMEIGINdyu3DqEbWnQ74A0pLzMctgeexclUdk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759243891; c=relaxed/simple; bh=CynlTSwuHzs8AGf5T7/cUvxX+Ib5/TtSY7RHdSTMNFY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=nFaWjMGeru4IDtje5y8NZcq7z6QNUgNuKZBw6/aQGMkygxqBMh4Xwp3OeWB1K1uoQWrTbcYEE3BgUrLM1iwD7XaUMgxQYNQ9hlRI3qstv0ebAM1bxjVQOnzxEa0YpI9WRh6C0Dt/4eUgBsD2+Z/F1nmdFb5heam7EYnp8AiAN+c= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=lUmsk+Pl; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="lUmsk+Pl" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 74BB7C4CEF0; Tue, 30 Sep 2025 14:51:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1759243890; bh=CynlTSwuHzs8AGf5T7/cUvxX+Ib5/TtSY7RHdSTMNFY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=lUmsk+PlhyX7cstcUN1iL/Zdat6UuFS+EG072cN1sRppl6IYvk2acRiZFYdeS1vQk wzwqzojXVcjhKbmcnzofyqAqFRpL4mSWG38urdESrlE+do2A48LWCh61nEQFf8Vy88 NZlqa7WeDK2cypSQBvazY0a8gyxNMwbvJ6Nj19AI= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Charles Keepax , Mark Brown , Sasha Levin Subject: [PATCH 5.4 47/81] ASoC: wm8974: Correct PLL rate rounding Date: Tue, 30 Sep 2025 16:46:49 +0200 Message-ID: <20250930143821.646512080@linuxfoundation.org> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20250930143819.654157320@linuxfoundation.org> References: <20250930143819.654157320@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.4-stable review patch. If anyone has any objections, please let me know. ------------------ From: Charles Keepax [ Upstream commit 9b17d3724df55ecc2bc67978822585f2b023be48 ] Using a single value of 22500000 for both 48000Hz and 44100Hz audio will sometimes result in returning wrong dividers due to rounding. Update the code to use the actual value for both. Fixes: 51b2bb3f2568 ("ASoC: wm8974: configure pll and mclk divider automatically") Signed-off-by: Charles Keepax Link: https://patch.msgid.link/20250821082639.1301453-4-ckeepax@opensource.cirrus.com Signed-off-by: Mark Brown Signed-off-by: Sasha Levin --- sound/soc/codecs/wm8974.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/sound/soc/codecs/wm8974.c b/sound/soc/codecs/wm8974.c index dc4fe4f5239d6..f32527ed06fb5 100644 --- a/sound/soc/codecs/wm8974.c +++ b/sound/soc/codecs/wm8974.c @@ -427,10 +427,14 @@ static int wm8974_update_clocks(struct snd_soc_dai *dai) fs256 = 256 * priv->fs; f = wm8974_get_mclkdiv(priv->mclk, fs256, &mclkdiv); - if (f != priv->mclk) { /* The PLL performs best around 90MHz */ - fpll = wm8974_get_mclkdiv(22500000, fs256, &mclkdiv); + if (fs256 % 8000) + f = 22579200; + else + f = 24576000; + + fpll = wm8974_get_mclkdiv(f, fs256, &mclkdiv); } wm8974_set_dai_pll(dai, 0, 0, priv->mclk, fpll); -- 2.51.0