From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 71E6D1F3FED; Tue, 30 Sep 2025 15:25:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759245918; cv=none; b=tgyyQtXVC/HCmRnpZ2e77wr+k4ra8dLQuIClaCLihDTY6tYbw7kqlWKul2pkjUkRabQIHZomAlD8ronPbaqYPJLKEYosreDwtuvtdRB9NObnavUg29BsZ1IFXYjq+sELabmtaSNuoI6AMhyXJfxD37SXaHocHj9lMNSrrzGHjHw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759245918; c=relaxed/simple; bh=E40aEd+Kuvp+M3QpLiY1SKH3o+U71A8LVy0OeVqFRvo=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=rxdYjhdkEvrng8BIB4yU1trH7T/VI2mWPsDSPvZ3XoFX784mpCvIZWGbFBPWEUdtk5c7PjXnRHs3A+nqci3YUWxUhMzBAT5jiBM+lLNIel2Tn/FKRQF8tCijNO8jDahlvS8lEaDXQ4jVOB2lB5mim/wf6PMdM6svBO629O+8DHg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=ID6D58hX; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="ID6D58hX" Received: by smtp.kernel.org (Postfix) with ESMTPSA id CC676C4CEF0; Tue, 30 Sep 2025 15:25:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1759245918; bh=E40aEd+Kuvp+M3QpLiY1SKH3o+U71A8LVy0OeVqFRvo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ID6D58hXNnhtrn9RMBdUH1oHD+0ciOSwSHbDxRfCBSfNzTL2V0aZnwBNj6KANkfIJ DZCVawcWDDv5ItyGiFGcktjnBT5/G8I+magPk2Bd4M1lgse6TZpz4mqRSej59nZ89N kBStPIEx9KtnZLi1cdzzcEUIeZE9+JvcEj1Azd8I= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Lukasz Czapnik , Aleksandr Loktionov , Przemek Kitszel , Simon Horman , Rafal Romanowski , Tony Nguyen Subject: [PATCH 6.6 58/91] i40e: fix input validation logic for action_meta Date: Tue, 30 Sep 2025 16:47:57 +0200 Message-ID: <20250930143823.601786969@linuxfoundation.org> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20250930143821.118938523@linuxfoundation.org> References: <20250930143821.118938523@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.6-stable review patch. If anyone has any objections, please let me know. ------------------ From: Lukasz Czapnik commit 9739d5830497812b0bdeaee356ddefbe60830b88 upstream. Fix condition to check 'greater or equal' to prevent OOB dereference. Fixes: e284fc280473 ("i40e: Add and delete cloud filter") Cc: stable@vger.kernel.org Signed-off-by: Lukasz Czapnik Reviewed-by: Aleksandr Loktionov Signed-off-by: Przemek Kitszel Reviewed-by: Simon Horman Tested-by: Rafal Romanowski Signed-off-by: Tony Nguyen Signed-off-by: Greg Kroah-Hartman --- drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c +++ b/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c @@ -3595,7 +3595,7 @@ static int i40e_validate_cloud_filter(st /* action_meta is TC number here to which the filter is applied */ if (!tc_filter->action_meta || - tc_filter->action_meta > vf->num_tc) { + tc_filter->action_meta >= vf->num_tc) { dev_info(&pf->pdev->dev, "VF %d: Invalid TC number %u\n", vf->vf_id, tc_filter->action_meta); goto err;