From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C4CC41EE02F; Tue, 30 Sep 2025 15:01:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759244495; cv=none; b=lWuTXyoHtSjDSqxb4jPoTxJFH0QOpJ/O7ODIcvG6fNJ24iGXEWYbXMS4WzyuyIcOBJRI1OiOyUKxBC5wM0IfmeeajjkqoKbQupYY9bRkFsUK51kQTw3Ico/4h0HGdl98D1zFcxdyWb2hR2/0J5IMkjm7PxKM0ysBF1tce1gOht8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759244495; c=relaxed/simple; bh=+5YpvCR8+kRYn2sc573ODN6B8OW0ExcKDjmc76cumjg=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=dkbxdNi6W91kOyI6LVRMtyrlAPuGA9dcNjp3l5kKoynXjGjXnG9ufr09WDSynC8eC5PM+zAQbLfG/OOwxTg7IlfggQDSh/J03RRsEXXuF/RtsZTDqGubNxDlTgZocJQU1w5SSvlhJCadhrFFWutEnb2IiF0aX9FGNgLME5pvtiY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=bQBt9YLE; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="bQBt9YLE" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5059BC4CEF0; Tue, 30 Sep 2025 15:01:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1759244495; bh=+5YpvCR8+kRYn2sc573ODN6B8OW0ExcKDjmc76cumjg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=bQBt9YLElEbHbzHjmGCfx/vK9RLdfMTY0Pm+h0DbsXrHZJnjRAFZv2J1Uf68cB14j EH/LrTsuSwRtWtLFlRChiRas9ZScJT2R+DTWZiJSMfYG2UzDz2lNmDXf0PueHJpjCw MtdVKXMC+KPeg8DSACoN+FnQPfz/7bu8U7xgtgRc= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Cristian Ciocaltea , Takashi Iwai , Sasha Levin Subject: [PATCH 6.16 009/143] ALSA: usb-audio: Remove unneeded wmb() in mixer_quirks Date: Tue, 30 Sep 2025 16:45:33 +0200 Message-ID: <20250930143831.618004418@linuxfoundation.org> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20250930143831.236060637@linuxfoundation.org> References: <20250930143831.236060637@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.16-stable review patch. If anyone has any objections, please let me know. ------------------ From: Cristian Ciocaltea [ Upstream commit 9cea7425595697802e8d55a322a251999554b8b1 ] Adding a memory barrier before wake_up() in snd_usb_soundblaster_remote_complete() is supposed to ensure the write to mixer->rc_code is visible in wait_event_interruptible() from snd_usb_sbrc_hwdep_read(). However, this is not really necessary, since wake_up() is just a wrapper over __wake_up() which already executes a full memory barrier before accessing the state of the task to be waken up. Drop the redundant call to wmb() and implicitly fix the checkpatch complaint: WARNING: memory barrier without comment Signed-off-by: Cristian Ciocaltea Signed-off-by: Takashi Iwai Link: https://patch.msgid.link/20250526-dualsense-alsa-jack-v1-8-1a821463b632@collabora.com Signed-off-by: Sasha Levin --- sound/usb/mixer_quirks.c | 1 - 1 file changed, 1 deletion(-) diff --git a/sound/usb/mixer_quirks.c b/sound/usb/mixer_quirks.c index dab6d461cf8cd..5507340a7723e 100644 --- a/sound/usb/mixer_quirks.c +++ b/sound/usb/mixer_quirks.c @@ -212,7 +212,6 @@ static void snd_usb_soundblaster_remote_complete(struct urb *urb) if (code == rc->mute_code) snd_usb_mixer_notify_id(mixer, rc->mute_mixer_id); mixer->rc_code = code; - wmb(); wake_up(&mixer->rc_waitq); } -- 2.51.0