From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9F32F1F63FF; Fri, 10 Oct 2025 13:22:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760102547; cv=none; b=J7Xgt35r80PJPiT5u416skGaei+1A2hHd7i/44UuyQIG3cmfR442a6xlgSxlCTPrDJZsBGFAQxeXKlSCG4BxLWVRTXQi4YPZPE3Fk0/FCBvAG8VW9WjhvdKF7h5ef1NW5AqrExaRxK0Ec0jaEEnuTGYgaSedz1dzS46CBnoyyFc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760102547; c=relaxed/simple; bh=UisoH2MNzCuXYYgskGtxxvzrsfIJNFsIaLNePb4JGok=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=P9j+E5r0UNxA8YACsyzNGg2m76pU4rmsoh6cy6S4IuMqWurLl+zE27h8LyCX54+1M8aeYLwJxBADRKGQWhxh0Z2mml4xiyIj8sDQWUM8bSqdBebPOzuXZRfu0TPGTdLHcWI4PF9Rcu0zykllFIXRkjFwIAUiwNOqrq7mglV+15g= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=spw2rTNi; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="spw2rTNi" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 29C9FC4CEFE; Fri, 10 Oct 2025 13:22:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1760102547; bh=UisoH2MNzCuXYYgskGtxxvzrsfIJNFsIaLNePb4JGok=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=spw2rTNiNsrsn/xQy+RCg9PVpyMfqED/xI2o0F1AVPB9zxgFN1CBJtSvPosM3eAHS 8LFuP7AIWFlpWisMjW8GNxNaHnvygY/etf8EtsQKk5H3Q8f9yH/QGcKtRr0eJ/BF2D XaVNRloMFVPOCiZSJjWxQO9r9N/aOQyS67FYvomw= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, syzbot+f02665daa2abeef4a947@syzkaller.appspotmail.com, Jeongjun Park , Takashi Iwai Subject: [PATCH 6.6 17/28] ALSA: usb-audio: fix race condition to UAF in snd_usbmidi_free Date: Fri, 10 Oct 2025 15:16:35 +0200 Message-ID: <20251010131330.991248370@linuxfoundation.org> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20251010131330.355311487@linuxfoundation.org> References: <20251010131330.355311487@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.6-stable review patch. If anyone has any objections, please let me know. ------------------ From: Jeongjun Park commit 9f2c0ac1423d5f267e7f1d1940780fc764b0fee3 upstream. The previous commit 0718a78f6a9f ("ALSA: usb-audio: Kill timer properly at removal") patched a UAF issue caused by the error timer. However, because the error timer kill added in this patch occurs after the endpoint delete, a race condition to UAF still occurs, albeit rarely. Additionally, since kill-cleanup for urb is also missing, freed memory can be accessed in interrupt context related to urb, which can cause UAF. Therefore, to prevent this, error timer and urb must be killed before freeing the heap memory. Cc: Reported-by: syzbot+f02665daa2abeef4a947@syzkaller.appspotmail.com Closes: https://syzkaller.appspot.com/bug?extid=f02665daa2abeef4a947 Fixes: 0718a78f6a9f ("ALSA: usb-audio: Kill timer properly at removal") Signed-off-by: Jeongjun Park Signed-off-by: Takashi Iwai Signed-off-by: Greg Kroah-Hartman --- sound/usb/midi.c | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) --- a/sound/usb/midi.c +++ b/sound/usb/midi.c @@ -1522,15 +1522,14 @@ static void snd_usbmidi_free(struct snd_ { int i; + if (!umidi->disconnected) + snd_usbmidi_disconnect(&umidi->list); + for (i = 0; i < MIDI_MAX_ENDPOINTS; ++i) { struct snd_usb_midi_endpoint *ep = &umidi->endpoints[i]; - if (ep->out) - snd_usbmidi_out_endpoint_delete(ep->out); - if (ep->in) - snd_usbmidi_in_endpoint_delete(ep->in); + kfree(ep->out); } mutex_destroy(&umidi->mutex); - timer_shutdown_sync(&umidi->error_timer); kfree(umidi); }