From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 916EE30B515; Mon, 13 Oct 2025 15:04:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760367858; cv=none; b=nARDtTRZW3W7JJELVtrJuRwE+BFHvWxVOSbQawVegLQknhlIkyNuD5b+SjbYN75gACVAnpED7p0RSgGN+ENlKDSM9AxBZK1a0X2qsZKArkgGL3OmjFfL/eQXKgnvvTLBoQFexV8EeetKTDbA5PghfUFMb2YLx/gzyzB/J/yo3Ms= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760367858; c=relaxed/simple; bh=WSDWiMWQEKI1SStuWs0F10HYLC49P7HoccMdOI6Qz54=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=VduNQCXOH3Zd2USHwZemlnKYMqfSTheEYFFtPCHgCd2OaEBOCvZ1qQLF7A+8L9miRjkQHU2q7bQerfULCUPxeP/kcmebbqBnQevfACLBGbjqhCOqtUXZj3pcxzi8UrWhnuY6bOEArx3hWktefXTxt5UGXEY8AObOjwQg1IWJ/W8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=rs1lTQ4l; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="rs1lTQ4l" Received: by smtp.kernel.org (Postfix) with ESMTPSA id E4339C4CEE7; Mon, 13 Oct 2025 15:04:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1760367858; bh=WSDWiMWQEKI1SStuWs0F10HYLC49P7HoccMdOI6Qz54=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=rs1lTQ4lQ6t3qrOIhq6qr5ARgqCPr1gxTKxLkB4mBzb3wvGhCGcbhHBqShZBrb5If jcNCM5u0VbmiXBH2a05a+gnYVj0zBLQ8raqNSqjfy8o8iai8u1Pd2T4zniX+6Ht+hZ XiUUSmXBQi2mJkDdlfn1XBbvst6iQlXx/bNTZB3I= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Donet Tom , David Hildenbrand , Oscar Salvador , Alison Schofield , Chris Mason , Danilo Krummrich , Dave Jiang , Hiroyouki Kamezawa , Joanthan Cameron , "Ritesh Harjani (IBM)" , "Yury Norov (NVIDIA)" , Zi Yan , Andrew Morton , Sasha Levin Subject: [PATCH 6.6 157/196] drivers/base/node: fix double free in register_one_node() Date: Mon, 13 Oct 2025 16:45:48 +0200 Message-ID: <20251013144320.991321393@linuxfoundation.org> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20251013144315.184275491@linuxfoundation.org> References: <20251013144315.184275491@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.6-stable review patch. If anyone has any objections, please let me know. ------------------ From: Donet Tom [ Upstream commit 0efdedfa537eb534c251a5b4794caaf72cc55869 ] When device_register() fails in register_node(), it calls put_device(&node->dev). This triggers node_device_release(), which calls kfree(to_node(dev)), thereby freeing the entire node structure. As a result, when register_node() returns an error, the node memory has already been freed. Calling kfree(node) again in register_one_node() leads to a double free. This patch removes the redundant kfree(node) from register_one_node() to prevent the double free. Link: https://lkml.kernel.org/r/20250918054144.58980-1-donettom@linux.ibm.com Fixes: 786eb990cfb7 ("drivers/base/node: handle error properly in register_one_node()") Signed-off-by: Donet Tom Acked-by: David Hildenbrand Acked-by: Oscar Salvador Cc: Alison Schofield Cc: Chris Mason Cc: Danilo Krummrich Cc: Dave Jiang Cc: Greg Kroah-Hartman Cc: Hiroyouki Kamezawa Cc: Joanthan Cameron Cc: "Ritesh Harjani (IBM)" Cc: Yury Norov (NVIDIA) Cc: Zi Yan Signed-off-by: Andrew Morton Signed-off-by: Sasha Levin --- drivers/base/node.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/base/node.c b/drivers/base/node.c index 7b2ff66c119ae..47960a34305d3 100644 --- a/drivers/base/node.c +++ b/drivers/base/node.c @@ -880,7 +880,6 @@ int __register_one_node(int nid) error = register_node(node_devices[nid], nid); if (error) { node_devices[nid] = NULL; - kfree(node); return error; } -- 2.51.0