From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9084730F92A; Mon, 13 Oct 2025 15:04:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760367861; cv=none; b=dWXzL2CY/aCAmp+uCho4b0yvALaFpgaivxhn5Trrc8HG7NSQCX7n193CoJhkwymvw2vN2TzJ1pWkt6RTPdxVxllSrljw48YNaGK9xCffQA/KVD7LLOxXwylgRAIHaPIJR9mCJdB+WKiH9LGMPqblmPhaH1vlQciD0L5evNyna3Y= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760367861; c=relaxed/simple; bh=3K+6Ftsy9gtO08X+WV0RUQuDi0hIRlVGUls9SVgexno=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=P24IGsmRD1W5r08jfKjn4mA9zjOp+bC/4NaTzlhwfsQ+JgtFUwpvMm+I9uEyn0ZLfEZs5ODp8zM0SFGlRfS1ICKruT/KcC2bM7pK+RKBHJbEG5KjYmvbC2ZgU2QYtfHnuJ0lSexc0ojkiNAh41T1FM/lNKClGdE4XUzAdqjOQ5U= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=v5iUlgAM; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="v5iUlgAM" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 10C93C4CEE7; Mon, 13 Oct 2025 15:04:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1760367861; bh=3K+6Ftsy9gtO08X+WV0RUQuDi0hIRlVGUls9SVgexno=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=v5iUlgAM6zKvCRYxoP/1VlR5oBbPZ2nZQbNe8G0NFhFRRPtx6j3WsyXAFYJAp2q86 b7S4xgloqlIOvi2NLq2PxqJHr187U9LJmOWbTzXtVQN3XB0n3J5LEA+0mw4sn9xQ54 1utO5q4zmYwoNZF6N13KSLLmjCQ7fAesz1FrTuBo= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Erick Karanja , Miquel Raynal , Sasha Levin Subject: [PATCH 6.6 158/196] mtd: rawnand: atmel: Fix error handling path in atmel_nand_controller_add_nands Date: Mon, 13 Oct 2025 16:45:49 +0200 Message-ID: <20251013144321.027632941@linuxfoundation.org> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20251013144315.184275491@linuxfoundation.org> References: <20251013144315.184275491@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.6-stable review patch. If anyone has any objections, please let me know. ------------------ From: Erick Karanja [ Upstream commit 8ed4728eb9f10b57c3eb02e0f6933a89ffcb8a91 ] In case of a jump to the err label due to atmel_nand_create() or atmel_nand_controller_add_nand() failure, the reference to nand_np need to be released Use for_each_child_of_node_scoped() to fix the issue. Fixes: f88fc122cc34 ("mtd: nand: Cleanup/rework the atmel_nand driver") Signed-off-by: Erick Karanja Signed-off-by: Miquel Raynal Signed-off-by: Sasha Levin --- drivers/mtd/nand/raw/atmel/nand-controller.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/mtd/nand/raw/atmel/nand-controller.c b/drivers/mtd/nand/raw/atmel/nand-controller.c index c5aff27ec4a89..14a09285f1551 100644 --- a/drivers/mtd/nand/raw/atmel/nand-controller.c +++ b/drivers/mtd/nand/raw/atmel/nand-controller.c @@ -1858,7 +1858,7 @@ atmel_nand_controller_legacy_add_nands(struct atmel_nand_controller *nc) static int atmel_nand_controller_add_nands(struct atmel_nand_controller *nc) { - struct device_node *np, *nand_np; + struct device_node *np; struct device *dev = nc->dev; int ret, reg_cells; u32 val; @@ -1885,7 +1885,7 @@ static int atmel_nand_controller_add_nands(struct atmel_nand_controller *nc) reg_cells += val; - for_each_child_of_node(np, nand_np) { + for_each_child_of_node_scoped(np, nand_np) { struct atmel_nand *nand; nand = atmel_nand_create(nc, nand_np, reg_cells); -- 2.51.0