From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 82A5730DD1D; Mon, 13 Oct 2025 14:56:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760367386; cv=none; b=mzTHkpBg2RSMlwlzdoduJ9CR7WzHx89hdez9AJ7zZO/vdvebcvgfK89ttSXpHaaiQ7p6ILqm8eURfZE/wSJT3xvMZzlrBV65haP34vFvhx/mjF1xc2Ld2pPl+7BwLw4ufmB9dDTT+Zx9TEHB+rTEm4/w0G+KLkViDB+K4KC+z2U= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760367386; c=relaxed/simple; bh=Vm4IuV33O9Xb2xveG7BmLChEFI40tphhmArYYN4F7K8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Gn10ZS9u+UHiSYuTHANfIz8ZXbycckO6jOgvGER8bjxIJ75E2FYobVfBo/FCz2IYK0f0dFVtCIME65TYoWCCnYFA92reFpfIiGMJK81p+HqRv1gGGqboXVZsCgPNsg7qYJHDkAncrltwQHarJwjUzs1+2MwWOWssIaVM8Yu2QOI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=bcxCWnYj; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="bcxCWnYj" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0EDF2C113D0; Mon, 13 Oct 2025 14:56:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1760367386; bh=Vm4IuV33O9Xb2xveG7BmLChEFI40tphhmArYYN4F7K8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=bcxCWnYjA3/lWwazOdw+M9g/YYyHCFrOjHId15o4m8TGIpiSt2AM4ZzhSbuoYmMLN XyuasUIVQKHL5+sbhEa6uQk41YGyo8q5SE5L6vRqxZH32Ewt7cP2lrXf7qqCu/Tab6 zhm1iiTxniXnFAnG2db3u5FqfpJTVhct73vAy75g= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Neil Armstrong , Bartosz Golaszewski , Linus Walleij Subject: [PATCH 6.1 189/196] pinctrl: check the return value of pinmux_ops::get_function_name() Date: Mon, 13 Oct 2025 16:46:02 +0200 Message-ID: <20251013144321.528852252@linuxfoundation.org> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20251013144314.549284796@linuxfoundation.org> References: <20251013144314.549284796@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.1-stable review patch. If anyone has any objections, please let me know. ------------------ From: Bartosz Golaszewski commit 4002ee98c022d671ecc1e4a84029e9ae7d8a5603 upstream. While the API contract in docs doesn't specify it explicitly, the generic implementation of the get_function_name() callback from struct pinmux_ops - pinmux_generic_get_function_name() - can fail and return NULL. This is already checked in pinmux_check_ops() so add a similar check in pinmux_func_name_to_selector() instead of passing the returned pointer right down to strcmp() where the NULL can get dereferenced. This is normal operation when adding new pinfunctions. Cc: stable@vger.kernel.org Tested-by: Neil Armstrong Signed-off-by: Bartosz Golaszewski Signed-off-by: Linus Walleij Signed-off-by: Greg Kroah-Hartman --- drivers/pinctrl/pinmux.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/pinctrl/pinmux.c +++ b/drivers/pinctrl/pinmux.c @@ -328,7 +328,7 @@ static int pinmux_func_name_to_selector( while (selector < nfuncs) { const char *fname = ops->get_function_name(pctldev, selector); - if (!strcmp(function, fname)) + if (fname && !strcmp(function, fname)) return selector; selector++;