From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E226F30FF39; Mon, 13 Oct 2025 15:22:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760368976; cv=none; b=cFaK1znTMewhLSZQ6qaYSBggZuiQ/o1pX019BZroNJA0UJ/P4NnKSUabvgNx6DjsLbvd71XmDYyCZkrmPJdVyK36EPKkYgvvCACn6Na3hZESYP2TxC05bfcyAOynF0Gvxb0KmDc0Otwm7bis/yfheBbv+erKcB7cDvUt/mGSfg8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760368976; c=relaxed/simple; bh=s4ntIGePoPOCJtTBwoJ41P5kjg0scQiWSWV5CVlVsAw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Y/g1Nsl3OKmYs1O3TaewobSWHibkKAZsd3yaGOL/gPRlFs+aJ2JCmzg0x4ma/r7gHT6HUVQvkQR/FJc2uUoqLaCoaoa/4vAAmkPfGXJSq+LAc9vIuFaZONbMCwXXa75CAcT1xRGZsDtglmXP1jdT7FwfwbbfGdOs1A+KVDkdbos= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=K5T/AMG0; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="K5T/AMG0" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5238AC4CEE7; Mon, 13 Oct 2025 15:22:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1760368975; bh=s4ntIGePoPOCJtTBwoJ41P5kjg0scQiWSWV5CVlVsAw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=K5T/AMG0VCuBKNRQls6uiIowMUgWq1PupYNYb8PrmHPBbuqizdtKQcLQ83k19PA63 klPmyoVxpYY9tk25zXBCtycTZJMgN1+kTSL0MDQm/7vGGd9ynMIyQLx7xjArz2Y5MK iiEgvoCnsGb6akShC/6LgjTaSs2iP5XR2eNM/AEQ= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Qianfeng Rong , John Garry , Bart Van Assche , Jens Axboe , Sasha Levin Subject: [PATCH 6.17 083/563] block: use int to store blk_stack_limits() return value Date: Mon, 13 Oct 2025 16:39:04 +0200 Message-ID: <20251013144414.304111181@linuxfoundation.org> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20251013144411.274874080@linuxfoundation.org> References: <20251013144411.274874080@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.17-stable review patch. If anyone has any objections, please let me know. ------------------ From: Qianfeng Rong [ Upstream commit b0b4518c992eb5f316c6e40ff186cbb7a5009518 ] Change the 'ret' variable in blk_stack_limits() from unsigned int to int, as it needs to store negative value -1. Storing the negative error codes in unsigned type, or performing equality comparisons (e.g., ret == -1), doesn't cause an issue at runtime [1] but can be confusing. Additionally, assigning negative error codes to unsigned type may trigger a GCC warning when the -Wsign-conversion flag is enabled. No effect on runtime. Link: https://lore.kernel.org/all/x3wogjf6vgpkisdhg3abzrx7v7zktmdnfmqeih5kosszmagqfs@oh3qxrgzkikf/ #1 Signed-off-by: Qianfeng Rong Reviewed-by: John Garry Fixes: fe0b393f2c0a ("block: Correct handling of bottom device misaligment") Reviewed-by: Bart Van Assche Link: https://lore.kernel.org/r/20250902130930.68317-1-rongqianfeng@vivo.com Signed-off-by: Jens Axboe Signed-off-by: Sasha Levin --- block/blk-settings.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/block/blk-settings.c b/block/blk-settings.c index d6438e6c276dc..693bc8d20acf3 100644 --- a/block/blk-settings.c +++ b/block/blk-settings.c @@ -763,7 +763,8 @@ static void blk_stack_atomic_writes_limits(struct queue_limits *t, int blk_stack_limits(struct queue_limits *t, struct queue_limits *b, sector_t start) { - unsigned int top, bottom, alignment, ret = 0; + unsigned int top, bottom, alignment; + int ret = 0; t->features |= (b->features & BLK_FEAT_INHERIT_MASK); -- 2.51.0