From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A3A572F12CC; Fri, 17 Oct 2025 15:14:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760714059; cv=none; b=HC6q9zJ0BrdKlkvYjaY0P+jWKJkMNw5AJTV3pVPGZb60sQz9gyojFPCislYIn2cuKjrCNZUvs7/4aSj4fSMAcX+/RS3c1hqGNFG4g7kmVjnc5QQEMdx9O1ZRK1NZF7NUvv449eVbGShChuu7GSYkknXZAFEWGWwAFoYQkgqtQf8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760714059; c=relaxed/simple; bh=wdPHeJwkV2LUPgv+UxSZl8zVKk8ilA2HRBMCsj5hiKI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=tsrudNY/ArhAJnJRMq3HWbS569jVs2vBe9R/zTRslmLih//Ea6xC88/yYM4OAm3pshgOS4Wwu4za7pkXr+z/v9tXhPwoflNzY9oOfjtBh5u1RZNAlZv+53CKGsl3zO8RSGyfXUPgDfUpzjcN4t9otPjWrZhV0MgfyYu0rIF7Xy0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=kDEz/bqv; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="kDEz/bqv" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 06B77C4CEE7; Fri, 17 Oct 2025 15:14:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1760714059; bh=wdPHeJwkV2LUPgv+UxSZl8zVKk8ilA2HRBMCsj5hiKI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=kDEz/bqvqMTyZSjU47gS0lEB5Z08e7BxA75Mrj1+xNm9ggE2dkSoYpL7zuJH9tF53 M4V+qWmmA+00O7bo0n7ZDB7Qcep8qd65Bql/jQUzFvwByBUXW2HtVkO/xO57ze1/Tw Fnl957jLN6zP6kXME7T3oV082Ag8FXZ0ovyhH6Wc= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Collin Funk , James Clark , Kuan-Wei Chiu , Ian Rogers , Namhyung Kim , Adrian Hunter , Alexander Shishkin , Athira Rajeev , Blake Jones , Chun-Tse Shao , Howard Chu , Ingo Molnar , Jan Polensky , Jiri Olsa , Kan Liang , Li Huafei , Mark Rutland , Nam Cao , Peter Zijlstra , "Steinar H. Gunderson" , Thomas Gleixner , Arnaldo Carvalho de Melo , Sasha Levin Subject: [PATCH 6.12 013/277] perf disasm: Avoid undefined behavior in incrementing NULL Date: Fri, 17 Oct 2025 16:50:20 +0200 Message-ID: <20251017145147.630060397@linuxfoundation.org> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20251017145147.138822285@linuxfoundation.org> References: <20251017145147.138822285@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.12-stable review patch. If anyone has any objections, please let me know. ------------------ From: Ian Rogers [ Upstream commit 78d853512d6f979cf0cc41566e4f6cd82995ff34 ] Incrementing NULL is undefined behavior and triggers ubsan during the perf annotate test. Split a compound statement over two lines to avoid this. Fixes: 98f69a573c668a18 ("perf annotate: Split out util/disasm.c") Reviewed-by: Collin Funk Reviewed-by: James Clark Reviewed-by: Kuan-Wei Chiu Signed-off-by: Ian Rogers Acked-by: Namhyung Kim Cc: Adrian Hunter Cc: Alexander Shishkin Cc: Athira Rajeev Cc: Blake Jones Cc: Chun-Tse Shao Cc: Howard Chu Cc: Ingo Molnar Cc: Jan Polensky Cc: Jiri Olsa Cc: Kan Liang Cc: Li Huafei Cc: Mark Rutland Cc: Nam Cao Cc: Namhyung Kim Cc: Peter Zijlstra Cc: Steinar H. Gunderson Cc: Thomas Gleixner Link: https://lore.kernel.org/r/20250821163820.1132977-2-irogers@google.com Signed-off-by: Arnaldo Carvalho de Melo Signed-off-by: Sasha Levin --- tools/perf/util/disasm.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/tools/perf/util/disasm.c b/tools/perf/util/disasm.c index 648e8d87ef194..a228a7ba30caa 100644 --- a/tools/perf/util/disasm.c +++ b/tools/perf/util/disasm.c @@ -389,13 +389,16 @@ static int jump__parse(struct arch *arch, struct ins_operands *ops, struct map_s * skip over possible up to 2 operands to get to address, e.g.: * tbnz w0, #26, ffff0000083cd190 */ - if (c++ != NULL) { + if (c != NULL) { + c++; ops->target.addr = strtoull(c, NULL, 16); if (!ops->target.addr) { c = strchr(c, ','); c = validate_comma(c, ops); - if (c++ != NULL) + if (c != NULL) { + c++; ops->target.addr = strtoull(c, NULL, 16); + } } } else { ops->target.addr = strtoull(ops->raw, NULL, 16); -- 2.51.0