From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2C7DE258ECA; Fri, 17 Oct 2025 15:22:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760714565; cv=none; b=BCuqirXEmidvtjmB9KE83vYc2j8SvoqL6BlxIioe7GDVLGI3WxvhMVDRBw3Kjz++Z6XhNin/Iq5HOWvBCeCFC/xqDCYNhLotLW9cFsIMqSS04d6PmjKMnhggwonwTxEaKDxn6N7ZLQaj1uQoJp6nUfUyI04P+eRIU49jZClvLgw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760714565; c=relaxed/simple; bh=baY0wuTM9tVUQN+oRe+qaGHISUUNDfjk2O5DghLMwJs=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=ANPF6y3NQuaAhTCUPsUl4S1l8OI9zFz/u4wzO/7dYXE+x6Lv/x8MbU5r1zsAZtg7f7hV2vJFy0xx7KHiWNzG6UJIWdK32VNgDz9HtakPwjOu4d1oc2DvRKu50w7pfll5dSrHeD8eGx2wYQwg5/+NqFiyIXHyKOsX1NBKNPSj98k= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=uWPSM/Uh; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="uWPSM/Uh" Received: by smtp.kernel.org (Postfix) with ESMTPSA id ADC2BC4CEE7; Fri, 17 Oct 2025 15:22:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1760714565; bh=baY0wuTM9tVUQN+oRe+qaGHISUUNDfjk2O5DghLMwJs=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=uWPSM/UhGQOmkq2rYifqYtpB/suGGNnKbHfR2Ilr+bDDQcTbyGVaJiKFo0B8W8PMV NFHtuy7hx+FxUq4+xGzQ9Y8YiRLXyGJXQIdQ1uG9poE4XWO4CFPWMHLAbDlTBAdVj6 YaspcSd2BCH9jTtUlbbbvDSJBnzaEP0jNoGC/KJs= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Esben Haabendal , Alexandre Belloni Subject: [PATCH 6.12 172/277] rtc: interface: Ensure alarm irq is enabled when UIE is enabled Date: Fri, 17 Oct 2025 16:52:59 +0200 Message-ID: <20251017145153.409206462@linuxfoundation.org> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20251017145147.138822285@linuxfoundation.org> References: <20251017145147.138822285@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.12-stable review patch. If anyone has any objections, please let me know. ------------------ From: Esben Haabendal commit 9db26d5855d0374d4652487bfb5aacf40821c469 upstream. When setting a normal alarm, user-space is responsible for using RTC_AIE_ON/RTC_AIE_OFF to control if alarm irq should be enabled. But when RTC_UIE_ON is used, interrupts must be enabled so that the requested irq events are generated. When RTC_UIE_OFF is used, alarm irq is disabled if there are no other alarms queued, so this commit brings symmetry to that. Signed-off-by: Esben Haabendal Cc: stable@vger.kernel.org Link: https://lore.kernel.org/r/20250516-rtc-uie-irq-fixes-v2-5-3de8e530a39e@geanix.com Signed-off-by: Alexandre Belloni Signed-off-by: Greg Kroah-Hartman --- drivers/rtc/interface.c | 4 ++++ 1 file changed, 4 insertions(+) --- a/drivers/rtc/interface.c +++ b/drivers/rtc/interface.c @@ -594,6 +594,10 @@ int rtc_update_irq_enable(struct rtc_dev rtc->uie_rtctimer.node.expires = ktime_add(now, onesec); rtc->uie_rtctimer.period = ktime_set(1, 0); err = rtc_timer_enqueue(rtc, &rtc->uie_rtctimer); + if (!err && rtc->ops && rtc->ops->alarm_irq_enable) + err = rtc->ops->alarm_irq_enable(rtc->dev.parent, 1); + if (err) + goto out; } else { rtc_timer_remove(rtc, &rtc->uie_rtctimer); }