From: Jason Gunthorpe <jgg@nvidia.com>
To: "Tian, Kevin" <kevin.tian@intel.com>
Cc: Lu Baolu <baolu.lu@linux.intel.com>,
David Woodhouse <dwmw2@infradead.org>,
"iommu@lists.linux.dev" <iommu@lists.linux.dev>,
Joerg Roedel <joro@8bytes.org>,
Robin Murphy <robin.murphy@arm.com>,
Will Deacon <will@kernel.org>,
"patches@lists.linux.dev" <patches@lists.linux.dev>,
Tina Zhang <tina.zhang@intel.com>,
Wei Wang <wei.w.wang@intel.com>
Subject: Re: [PATCH v2 04/10] iommupt: Flush the CPU cache after any writes to the page table
Date: Tue, 21 Oct 2025 10:50:07 -0300 [thread overview]
Message-ID: <20251021135007.GC712833@nvidia.com> (raw)
In-Reply-To: <BL1PR11MB527176E811B4B5C8DCACCAD18CEBA@BL1PR11MB5271.namprd11.prod.outlook.com>
On Tue, Oct 14, 2025 at 07:53:23AM +0000, Tian, Kevin wrote:
> > From: Jason Gunthorpe <jgg@nvidia.com>
> > Sent: Wednesday, August 27, 2025 1:26 AM
> >
> > do {
> > - if (single_page) {
> > + if (single_page &&
> > + !pt_feature(common, PT_FEAT_DMA_INCOHERENT)) {
> > ret = pt_walk_range(&range, __map_single_page,
> > &map);
>
> let's add a comment here for disabling this fastpath.
/*
* The __map_single_page() fast path does not support
* DMA_INCOHERENT flushing to keep its .text small.
*/
Thanks,
Jason
next prev parent reply other threads:[~2025-10-21 13:50 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-26 17:26 [PATCH v2 00/10] Convert Intel VT-D to use the generic iommu page table Jason Gunthorpe
2025-08-26 17:26 ` [PATCH v2 01/10] iommu/pages: Add support for a incoherent IOMMU page walker Jason Gunthorpe
2025-09-21 9:54 ` Baolu Lu
2025-09-22 16:32 ` Jason Gunthorpe
2025-10-14 7:41 ` Tian, Kevin
2025-08-26 17:26 ` [PATCH v2 02/10] iommupt: Add basic support for SW bits in the page table Jason Gunthorpe
2025-09-21 10:21 ` Baolu Lu
2025-10-14 7:45 ` Tian, Kevin
2025-10-21 13:18 ` Jason Gunthorpe
2025-08-26 17:26 ` [PATCH v2 03/10] iommupt: Use the incoherent start/stop functions for PT_FEAT_DMA_INCOHERENT Jason Gunthorpe
2025-09-21 13:29 ` Baolu Lu
2025-10-14 7:51 ` Tian, Kevin
2025-10-21 13:20 ` Jason Gunthorpe
2025-08-26 17:26 ` [PATCH v2 04/10] iommupt: Flush the CPU cache after any writes to the page table Jason Gunthorpe
2025-09-22 2:12 ` Baolu Lu
2025-09-22 14:42 ` Jason Gunthorpe
2025-09-23 2:17 ` Baolu Lu
2025-09-23 14:10 ` Jason Gunthorpe
2025-09-24 2:30 ` Baolu Lu
2025-09-22 2:31 ` Baolu Lu
2025-09-22 14:44 ` Jason Gunthorpe
2025-09-23 2:29 ` Baolu Lu
2025-09-23 14:13 ` Jason Gunthorpe
2025-09-24 3:05 ` Baolu Lu
2025-10-14 7:53 ` Tian, Kevin
2025-10-21 13:50 ` Jason Gunthorpe [this message]
2025-08-26 17:26 ` [PATCH v2 05/10] iommupt: Add the Intel VT-D second stage page table format Jason Gunthorpe
2025-09-22 3:06 ` Baolu Lu
2025-10-14 7:54 ` Tian, Kevin
2025-10-21 13:58 ` Jason Gunthorpe
2025-08-26 17:26 ` [PATCH v2 06/10] iommupt/x86: Set the dirty bit only for writable PTEs Jason Gunthorpe
2025-10-14 7:55 ` Tian, Kevin
2025-08-26 17:26 ` [PATCH v2 07/10] iommupt/x86: Support SW bits and permit PT_FEAT_DMA_INCOHERENT Jason Gunthorpe
2025-10-14 7:55 ` Tian, Kevin
2025-08-26 17:26 ` [PATCH v2 08/10] iommu/vt-d: Use the generic iommu page table Jason Gunthorpe
2025-09-22 11:17 ` Baolu Lu
2025-10-14 7:55 ` Tian, Kevin
2025-08-26 17:26 ` [PATCH v2 09/10] iommu/vt-d: Follow PT_FEAT_DMA_INCOHERENT into the PASID entry Jason Gunthorpe
2025-09-22 13:00 ` Baolu Lu
2025-10-14 7:58 ` Tian, Kevin
2025-08-26 17:26 ` [PATCH v2 10/10] iommupt: Add a kunit test for the SW bits Jason Gunthorpe
2025-10-14 7:58 ` Tian, Kevin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251021135007.GC712833@nvidia.com \
--to=jgg@nvidia.com \
--cc=baolu.lu@linux.intel.com \
--cc=dwmw2@infradead.org \
--cc=iommu@lists.linux.dev \
--cc=joro@8bytes.org \
--cc=kevin.tian@intel.com \
--cc=patches@lists.linux.dev \
--cc=robin.murphy@arm.com \
--cc=tina.zhang@intel.com \
--cc=wei.w.wang@intel.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).