From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 914C02D7806; Mon, 27 Oct 2025 18:40:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761590417; cv=none; b=Sh9HeYDa7Rn2tSz11jWcR/VmTA3UGnJOgauKyjLTkloM3QlkkVMxvkmAqBS6LxA9eHL3tzNCe7lyErcyaVkGGxc14CNnBxjIcA2/2yZkkJcdfR5j/LGUlV7ZPEjmAOtuspKNqtfTisZ0YEOMNvXvWxm2xSfmMsK6Si9vVMMhj+U= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761590417; c=relaxed/simple; bh=rpp7CPgGju0l4Zx7ZGj2KsFP5h9dtxhvfvr3KLQQ/Ss=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=W7TM2Cb2ZPy8w7Qit/MBsSl864ygoI4FowvzMfgpwZXNrBKv8PDPPmSVNp1cGbc57O4kLufSmKyPdfO6/pb71FI00T70P4nH/MVcqyDwJ8/2NXIh7XiUyCcGJImFS5brUNaMumdhSHxoWBgCN8xr9h/m048Ca5XMn6qOG+9Z8ds= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=DL08ZBfC; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="DL08ZBfC" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2341EC4CEF1; Mon, 27 Oct 2025 18:40:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1761590417; bh=rpp7CPgGju0l4Zx7ZGj2KsFP5h9dtxhvfvr3KLQQ/Ss=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=DL08ZBfCjRetaabOWEsZEJhOucqEL+PtAgtr9w+gbJRiykFjSWEfprqd4wlh1n4PE aGFxxyI4Mu66I4vyOytPtrzxx0mWsFKHJ10rfZHLYYKh256Zs6y2B2ghjRD457wO+h 40/GApTz1X8Hro9Tp5yTKq4KI1gRi+jXiigl07ro= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Duoming Zhou , Hans Verkuil , Sasha Levin Subject: [PATCH 5.4 005/224] media: tuner: xc5000: Fix use-after-free in xc5000_release Date: Mon, 27 Oct 2025 19:32:31 +0100 Message-ID: <20251027183509.120044705@linuxfoundation.org> X-Mailer: git-send-email 2.51.1 In-Reply-To: <20251027183508.963233542@linuxfoundation.org> References: <20251027183508.963233542@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.4-stable review patch. If anyone has any objections, please let me know. ------------------ From: Duoming Zhou [ Upstream commit 40b7a19f321e65789612ebaca966472055dab48c ] The original code uses cancel_delayed_work() in xc5000_release(), which does not guarantee that the delayed work item timer_sleep has fully completed if it was already running. This leads to use-after-free scenarios where xc5000_release() may free the xc5000_priv while timer_sleep is still active and attempts to dereference the xc5000_priv. A typical race condition is illustrated below: CPU 0 (release thread) | CPU 1 (delayed work callback) xc5000_release() | xc5000_do_timer_sleep() cancel_delayed_work() | hybrid_tuner_release_state(priv) | kfree(priv) | | priv = container_of() // UAF Replace cancel_delayed_work() with cancel_delayed_work_sync() to ensure that the timer_sleep is properly canceled before the xc5000_priv memory is deallocated. A deadlock concern was considered: xc5000_release() is called in a process context and is not holding any locks that the timer_sleep work item might also need. Therefore, the use of the _sync() variant is safe here. This bug was initially identified through static analysis. Fixes: f7a27ff1fb77 ("[media] xc5000: delay tuner sleep to 5 seconds") Cc: stable@vger.kernel.org Signed-off-by: Duoming Zhou Signed-off-by: Hans Verkuil [hverkuil: fix typo in Subject: tunner -> tuner] Signed-off-by: Sasha Levin Signed-off-by: Greg Kroah-Hartman --- drivers/media/tuners/xc5000.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/media/tuners/xc5000.c +++ b/drivers/media/tuners/xc5000.c @@ -1304,7 +1304,7 @@ static void xc5000_release(struct dvb_fr mutex_lock(&xc5000_list_mutex); if (priv) { - cancel_delayed_work(&priv->timer_sleep); + cancel_delayed_work_sync(&priv->timer_sleep); hybrid_tuner_release_state(priv); }