From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D2FC0218EB1; Mon, 27 Oct 2025 18:39:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761590367; cv=none; b=uumdwa+oYwpt91A2tCNLlLqk4OSW0Gs04Grh46sVEEWt1MsBc4FLHKhzRlQ8dMBjZl88akX5XrGOVc9CsHybvtxhlIOzyZCjWBI13e7ILMkWgCz6Vx88hE535hiiTiw690xuTwsxnk94mcFGtxeBywVnuKHiWrxJaU8UVOpqZXM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761590367; c=relaxed/simple; bh=JSvkol3gAs72usPwiR2tXW7O4vDK3E6LZlXvIXx3uIY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=LAVt4tEkvFn3y03HVZtNSzbP1QvsRGH/mPqAb7znTJXs9DIrJ13/pRy5ffkM2gxHFltwJ2AyfkN3/8pa7Y5Emnt7U5WKRgwQqJp6+OVrZf7uzfs330mwoAYDAHryfXVBounfmkXF2xLwwlWlC4VphrNi5pLt6TvBtYmBQzPYi7k= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=popxEbDE; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="popxEbDE" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1D166C4CEF1; Mon, 27 Oct 2025 18:39:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1761590367; bh=JSvkol3gAs72usPwiR2tXW7O4vDK3E6LZlXvIXx3uIY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=popxEbDEafAcGtXmTuGM4nZYTlII7tnuK1tTCbbdp7V8CFUIgf3K1VdmLxMWwcgQ8 NQh4m6aqcx4ZX0CelmCiSV1Crc8Jyq1mcxAiHCk0gtRDOhRGqJ1LqpCpRCBJtiEJzm Ck5S5AOTgwzKivrbpw3m9PRhVgrp3ANNxukL/DjM= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Uros Bizjak , "Borislav Petkov (AMD)" , Sasha Levin Subject: [PATCH 5.4 019/224] x86/vdso: Fix output operand size of RDPID Date: Mon, 27 Oct 2025 19:32:45 +0100 Message-ID: <20251027183509.510260190@linuxfoundation.org> X-Mailer: git-send-email 2.51.1 In-Reply-To: <20251027183508.963233542@linuxfoundation.org> References: <20251027183508.963233542@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.4-stable review patch. If anyone has any objections, please let me know. ------------------ From: Uros Bizjak [ Upstream commit ac9c408ed19d535289ca59200dd6a44a6a2d6036 ] RDPID instruction outputs to a word-sized register (64-bit on x86_64 and 32-bit on x86_32). Use an unsigned long variable to store the correct size. LSL outputs to 32-bit register, use %k operand prefix to always print the 32-bit name of the register. Use RDPID insn mnemonic while at it as the minimum binutils version of 2.30 supports it. [ bp: Merge two patches touching the same function into a single one. ] Fixes: ffebbaedc861 ("x86/vdso: Introduce helper functions for CPU and node number") Signed-off-by: Uros Bizjak Signed-off-by: Borislav Petkov (AMD) Link: https://lore.kernel.org/20250616095315.230620-1-ubizjak@gmail.com Signed-off-by: Sasha Levin --- arch/x86/include/asm/segment.h | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/arch/x86/include/asm/segment.h b/arch/x86/include/asm/segment.h index 6669164abadcb..531a0cb93b47b 100644 --- a/arch/x86/include/asm/segment.h +++ b/arch/x86/include/asm/segment.h @@ -253,7 +253,7 @@ static inline unsigned long vdso_encode_cpunode(int cpu, unsigned long node) static inline void vdso_read_cpunode(unsigned *cpu, unsigned *node) { - unsigned int p; + unsigned long p; /* * Load CPU and node number from the GDT. LSL is faster than RDTSCP @@ -263,10 +263,10 @@ static inline void vdso_read_cpunode(unsigned *cpu, unsigned *node) * * If RDPID is available, use it. */ - alternative_io ("lsl %[seg],%[p]", - ".byte 0xf3,0x0f,0xc7,0xf8", /* RDPID %eax/rax */ + alternative_io ("lsl %[seg],%k[p]", + "rdpid %[p]", X86_FEATURE_RDPID, - [p] "=a" (p), [seg] "r" (__CPUNODE_SEG)); + [p] "=r" (p), [seg] "r" (__CPUNODE_SEG)); if (cpu) *cpu = (p & VDSO_CPUNODE_MASK); -- 2.51.0