From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3E5D431B80D; Mon, 27 Oct 2025 18:40:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761590434; cv=none; b=cIZTdg+P8WIoimNgoc6YNrCSsQo0nYpO61Jw18V9P56rm5f2ND4u6mbYPA3WEj2q/Z0ineBVN+NQr0Y4ALD6zIlgCFb+eH0g+kdaqYRXveWi1eqVXv6T+wOZV06lDUQc4e4o8js9yqCtOuQD/JI42b8EthKofqBTMLfBz/s/cEE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761590434; c=relaxed/simple; bh=jZBx/9mUmOEMGCUk5VqymZwR+AnCDs7ZgMO0iYRkH7g=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=tE072lPLqQAs28FSZ4xUsK2oVL4tnd9TM8CSN8NxhVMIU0qLjQxBPtFdnq9cRm2vK2kpWu98orRAML0PFujbM7r9TG75vvoWYo8R2EdaZ+4f3InWmA0wIEHS8FRRdlNjQ25FIFzYSOHtPxJFCJfYybcncdn0z716aFDMQyo/4O4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=tTuOMxOf; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="tTuOMxOf" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7DC8DC4CEFD; Mon, 27 Oct 2025 18:40:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1761590433; bh=jZBx/9mUmOEMGCUk5VqymZwR+AnCDs7ZgMO0iYRkH7g=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=tTuOMxOfrY/Pg3NMCSYrNcfX6AMLeXliNJifMpRjaqrqYzA0uDdyrTdJyRB58lTTi 3YG0CFLKUz2alp08mCWKJ+PU2Pz3raEnmQfuaNkoiY7MTic54/fAsLfypc/5CI9csw pyRNPJWzTktglWTS1LmZMWohIjc4kR0e0mJ7gjAg= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Zhang Shurong , Jacopo Mondi , Sakari Ailus , Hans Verkuil , Sasha Levin Subject: [PATCH 5.4 036/224] media: rj54n1cb0c: Fix memleak in rj54n1_probe() Date: Mon, 27 Oct 2025 19:33:02 +0100 Message-ID: <20251027183509.971743762@linuxfoundation.org> X-Mailer: git-send-email 2.51.1 In-Reply-To: <20251027183508.963233542@linuxfoundation.org> References: <20251027183508.963233542@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.4-stable review patch. If anyone has any objections, please let me know. ------------------ From: Zhang Shurong [ Upstream commit fda55673ecdabf25f5ecc61b5ab17239257ac252 ] rj54n1_probe() won't clean all the allocated resources in fail path, which may causes the memleaks. Add v4l2_ctrl_handler_free() to prevent memleak. Fixes: f187352dcd45 ("media: i2c: Copy rj54n1cb0c soc_camera sensor driver") Signed-off-by: Zhang Shurong Reviewed-by: Jacopo Mondi Signed-off-by: Sakari Ailus Signed-off-by: Hans Verkuil Signed-off-by: Sasha Levin --- drivers/media/i2c/rj54n1cb0c.c | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/drivers/media/i2c/rj54n1cb0c.c b/drivers/media/i2c/rj54n1cb0c.c index 4cc51e0018744..b35b3e4286861 100644 --- a/drivers/media/i2c/rj54n1cb0c.c +++ b/drivers/media/i2c/rj54n1cb0c.c @@ -1332,10 +1332,13 @@ static int rj54n1_probe(struct i2c_client *client, V4L2_CID_GAIN, 0, 127, 1, 66); v4l2_ctrl_new_std(&rj54n1->hdl, &rj54n1_ctrl_ops, V4L2_CID_AUTO_WHITE_BALANCE, 0, 1, 1, 1); - rj54n1->subdev.ctrl_handler = &rj54n1->hdl; - if (rj54n1->hdl.error) - return rj54n1->hdl.error; + if (rj54n1->hdl.error) { + ret = rj54n1->hdl.error; + goto err_free_ctrl; + } + + rj54n1->subdev.ctrl_handler = &rj54n1->hdl; rj54n1->clk_div = clk_div; rj54n1->rect.left = RJ54N1_COLUMN_SKIP; rj54n1->rect.top = RJ54N1_ROW_SKIP; -- 2.51.0